Re: [PATCH v5 00/14] software node: add support for reference properties
On Mon, Oct 14, 2019 at 04:57:47PM -0700, Dmitry Torokhov wrote: > On Mon, Oct 14, 2019 at 10:38:37AM +0300, Andy Shevchenko wrote: > > On Fri, Oct 11, 2019 at 04:07:07PM -0700, Dmitry Torokhov wrote: > > > These series implement "references" properties for software nodes as true > > > properties, instead of managing them completely separately. > > > > > > The first 10 patches are generic cleanups and consolidation and > > > unification of the existing code; patch #11 implements moving of small > > > properties inline when copying property entries; patch #12 implements > > > PROPERTY_ENTRY_REF() and friends; patch #13 converts the user of > > > references to the property syntax, and patch #14 removes the remains of > > > references as entities that are managed separately. > > > > Can we get some test cases? > > Something like this? (I'll beef it up if we decide KUnit is OK for > this). As a starter, yes. -- With Best Regards, Andy Shevchenko
Re: [PATCH v5 00/14] software node: add support for reference properties
On Mon, Oct 14, 2019 at 10:38:37AM +0300, Andy Shevchenko wrote:
> On Fri, Oct 11, 2019 at 04:07:07PM -0700, Dmitry Torokhov wrote:
> > These series implement "references" properties for software nodes as true
> > properties, instead of managing them completely separately.
> >
> > The first 10 patches are generic cleanups and consolidation and
> > unification of the existing code; patch #11 implements moving of small
> > properties inline when copying property entries; patch #12 implements
> > PROPERTY_ENTRY_REF() and friends; patch #13 converts the user of
> > references to the property syntax, and patch #14 removes the remains of
> > references as entities that are managed separately.
>
> Can we get some test cases?
Something like this? (I'll beef it up if we decide KUnit is OK for
this).
>From 0b8256ceed44760e63becb5b9636099d9fc17a4c Mon Sep 17 00:00:00 2001
From: Dmitry Torokhov
Date: Mon, 14 Oct 2019 16:55:12 -0700
Subject: [PATCH] software node: add basic init tests
Signed-off-by: Dmitry Torokhov
---
drivers/base/test/Makefile | 2 +
drivers/base/test/property-entry-test.c | 56 +
2 files changed, 58 insertions(+)
create mode 100644 drivers/base/test/property-entry-test.c
diff --git a/drivers/base/test/Makefile b/drivers/base/test/Makefile
index 0f1f7277a013..22143102e5d2 100644
--- a/drivers/base/test/Makefile
+++ b/drivers/base/test/Makefile
@@ -1,2 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE) += test_async_driver_probe.o
+
+obj-$(CONFIG_KUNIT) += property-entry-test.o
diff --git a/drivers/base/test/property-entry-test.c
b/drivers/base/test/property-entry-test.c
new file mode 100644
index ..cd6a405734a0
--- /dev/null
+++ b/drivers/base/test/property-entry-test.c
@@ -0,0 +1,56 @@
+// SPDX-License-Identifier: GPL-2.0
+// Unit tests for property entries API
+//
+// Copyright 2019 Google LLC.
+
+#include
+#include
+#include
+
+static void pe_test_move_inline_u8(struct kunit *test)
+{
+ u8 u8_array_small[8] = { 0 };
+ u8 u8_array_big[128] = { 0 };
+ struct property_entry entries[] = {
+ PROPERTY_ENTRY_U8_ARRAY("small", u8_array_small),
+ PROPERTY_ENTRY_U8_ARRAY("big", u8_array_big),
+ { }
+ };
+ struct property_entry *copy;
+
+ copy = property_entries_dup(entries);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, copy);
+ KUNIT_EXPECT_TRUE(test, copy[0].is_inline);
+ KUNIT_EXPECT_FALSE(test, copy[1].is_inline);
+}
+
+static void pe_test_move_inline_str(struct kunit *test)
+{
+ char *str_array_small[] = { "a" };
+ char *str_array_big[] = { "a", "b", "c", "d" };
+ struct property_entry entries[] = {
+ PROPERTY_ENTRY_STRING_ARRAY("small", str_array_small),
+ PROPERTY_ENTRY_STRING_ARRAY("big", str_array_big),
+ { }
+ };
+ struct property_entry *copy;
+
+ copy = property_entries_dup(entries);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, copy);
+ KUNIT_EXPECT_TRUE(test, copy[0].is_inline);
+ KUNIT_EXPECT_FALSE(test, copy[1].is_inline);
+}
+
+
+static struct kunit_case property_entry_test_cases[] = {
+ KUNIT_CASE(pe_test_move_inline_u8),
+ KUNIT_CASE(pe_test_move_inline_str),
+ { }
+};
+
+static struct kunit_suite property_entry_test_suite = {
+ .name = "property-entry",
+ .test_cases = property_entry_test_cases,
+};
+
+kunit_test_suite(property_entry_test_suite);
--
2.23.0.700.g56cf767bdb-goog
--
Dmitry
Re: [PATCH v5 00/14] software node: add support for reference properties
On Fri, Oct 11, 2019 at 04:07:07PM -0700, Dmitry Torokhov wrote: > These series implement "references" properties for software nodes as true > properties, instead of managing them completely separately. > > The first 10 patches are generic cleanups and consolidation and > unification of the existing code; patch #11 implements moving of small > properties inline when copying property entries; patch #12 implements > PROPERTY_ENTRY_REF() and friends; patch #13 converts the user of > references to the property syntax, and patch #14 removes the remains of > references as entities that are managed separately. Can we get some test cases? -- With Best Regards, Andy Shevchenko
[PATCH v5 00/14] software node: add support for reference properties
These series implement "references" properties for software nodes as true properties, instead of managing them completely separately. The first 10 patches are generic cleanups and consolidation and unification of the existing code; patch #11 implements moving of small properties inline when copying property entries; patch #12 implements PROPERTY_ENTRY_REF() and friends; patch #13 converts the user of references to the property syntax, and patch #14 removes the remains of references as entities that are managed separately. Changes in v5: - rebased onto next-20191011 Changes in v4: - dealt with union aliasing concerns - inline small properties on copy Changes in v3: - added various cleanups before implementing reference properties Changes in v2: - reworked code so that even single-entry reference properties are stored as arrays (i.e. the software_node_ref_args instances are not part of property_entry structure) to avoid size increase. From user's POV nothing is changed, one can still use PROPERTY_ENTRY_REF macro to define reference "inline". - dropped unused DEV_PROP_MAX - rebased on linux-next Dmitry Torokhov (14): software node: remove DEV_PROP_MAX software node: introduce PROPERTY_ENTRY_ARRAY_XXX_LEN() efi/apple-properties: use PROPERTY_ENTRY_U8_ARRAY_LEN software node: mark internal macros with double underscores software node: clean up property_copy_string_array() software node: get rid of property_set_pointer() software node: remove property_entry_read_uNN_array functions software node: unify PROPERTY_ENTRY_XXX macros software node: simplify property_entry_read_string_array() software node: rename is_array to is_inline software node: move small properties inline when copying software node: implement reference properties platform/x86: intel_cht_int33fe: use inline reference properties software node: remove separate handling of references drivers/base/swnode.c| 266 --- drivers/firmware/efi/apple-properties.c | 18 +- drivers/platform/x86/intel_cht_int33fe.c | 81 +++ include/linux/property.h | 177 +++ 4 files changed, 230 insertions(+), 312 deletions(-) -- 2.23.0.700.g56cf767bdb-goog
