Re: [PATCH v5 06/10] x86/hyper-v: implement rep hypercalls

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov  wrote:
> Rep hypercalls are normal hypercalls which perform multiple actions at
> once. Hyper-V guarantees to return exectution to the caller in not more
> than 50us and the caller needs to use hypercall continuation. Touch NMI
> watchdog between hypercall invocations.
>
> This is going to be used for HvFlushVirtualAddressList hypercall for
> remote TLB flushing.


> +   control |= (u64)varhead_size << 17; /* Variable header size */
> +   control |= (u64)rep_count << 32; /* Rep Count */

> +   control &= U64_MAX >> 16;
> +   control |= (u64)rep_comp << 48;

It might make sense to define magics with appropriate names.

-- 
With Best Regards,
Andy Shevchenko


[PATCH v5 06/10] x86/hyper-v: implement rep hypercalls

2017-05-30 Thread Vitaly Kuznetsov
Rep hypercalls are normal hypercalls which perform multiple actions at
once. Hyper-V guarantees to return exectution to the caller in not more
than 50us and the caller needs to use hypercall continuation. Touch NMI
watchdog between hypercall invocations.

This is going to be used for HvFlushVirtualAddressList hypercall for
remote TLB flushing.

Signed-off-by: Vitaly Kuznetsov 
Acked-by: K. Y. Srinivasan 
---
Changes since v4:
- Avoid union aliasing [Andy Shevchenko]
---
 arch/x86/include/asm/mshyperv.h | 36 
 1 file changed, 36 insertions(+)

diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
index d587d1e..7c79a17 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arch/x86/include/asm/mshyperv.h
@@ -4,6 +4,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 /*
@@ -244,6 +245,41 @@ static inline u64 hv_do_fast_hypercall8(u16 code, u64 
input1)
return hv_status;
 }
 
+/*
+ * Rep hypercalls. Callers of this functions are supposed to ensure that
+ * rep_count and varhead_size comply with Hyper-V hypercall definition.
+ */
+static inline u64 hv_do_rep_hypercall(u16 code, u16 rep_count, u16 
varhead_size,
+ void *input, void *output)
+{
+   u64 control = code;
+   u64 status;
+   u16 rep_comp;
+
+   control |= (u64)varhead_size << 17; /* Variable header size */
+   control |= (u64)rep_count << 32; /* Rep Count */
+
+   do {
+   status = hv_do_hypercall(control, input, output);
+   if ((status & 0x) != HV_STATUS_SUCCESS)
+   return status;
+
+   /* Bits 32-43 of status have 'Reps completed' data. */
+   rep_comp = upper_32_bits(status) & 0xfff;
+
+   /*
+* Set Rep Start Index (bits 48-59) for continuation. Upper 4
+* bits are reserved and should be set to 0.
+*/
+   control &= U64_MAX >> 16;
+   control |= (u64)rep_comp << 48;
+
+   touch_nmi_watchdog();
+   } while (rep_comp < rep_count);
+
+   return status;
+}
+
 void hyperv_init(void);
 void hyperv_report_panic(struct pt_regs *regs);
 bool hv_is_hypercall_page_setup(void);
-- 
2.9.4