Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes
Hi Sakari, Mauro,
On Wed, Jan 13, 2021 at 2:26 PM Sakari Ailus
wrote:
> On Sat, Jan 09, 2021 at 04:01:05AM +0200, Laurent Pinchart wrote:
> > Could you please let us know if you're fine with this patch getting
> > merged in v5.12 through the linux-media tree ? The cover letter contains
> > additional details (in a nutshell, this is a cross-tree series and we
> > would like to avoid topic branches if possible).
>
> I'll proceed to merge this patch through the media tree.
Prefixing this patch with "media:"[1] when committing is confusing.
[1] commit f0328be57568c795 ("media: lib/test_printf.c: Use helper
function to unwind array of software_nodes").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes
Hello all, On Sat, Jan 09, 2021 at 04:01:05AM +0200, Laurent Pinchart wrote: > Hi Peter, Steven and Sergey, > > Could you please let us know if you're fine with this patch getting > merged in v5.12 through the linux-media tree ? The cover letter contains > additional details (in a nutshell, this is a cross-tree series and we > would like to avoid topic branches if possible). I'll proceed to merge this patch through the media tree. Thanks. -- Kind regards, Sakari Ailus
Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes
On Sun, Jan 10, 2021 at 05:38:03PM +0200, Andy Shevchenko wrote: > On Sun, Jan 10, 2021 at 1:16 PM Laurent Pinchart wrote: > > On Sat, Jan 09, 2021 at 11:07:33AM +0200, Andy Shevchenko wrote: > > > On Saturday, January 9, 2021, Laurent Pinchart wrote: > > > > Could you please let us know if you're fine with this patch getting > > > > merged in v5.12 through the linux-media tree ? The cover letter contains > > > > additional details (in a nutshell, this is a cross-tree series and we > > > > would like to avoid topic branches if possible). > > > > > > There is already a tag by Petr. > > > > I saw that, but looking at the corresponding e-mail, there was no clear > > acknowledgement that we could merge this patch through a different tree. > > Fair point. > > One question though, what so wrong with topic branches. They're not wrong, they just add more complexity as all maintainers involved would need to create a topic branch based on v5.11-rc1 and merge it in their respective tree. It's certainly doable, but when there's no risk of conflict, merging the whole series through a single tree is just easier. -- Regards, Laurent Pinchart
Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes
On Sun, Jan 10, 2021 at 1:16 PM Laurent Pinchart wrote: > On Sat, Jan 09, 2021 at 11:07:33AM +0200, Andy Shevchenko wrote: > > On Saturday, January 9, 2021, Laurent Pinchart wrote: > > > Could you please let us know if you're fine with this patch getting > > > merged in v5.12 through the linux-media tree ? The cover letter contains > > > additional details (in a nutshell, this is a cross-tree series and we > > > would like to avoid topic branches if possible). > > > > There is already a tag by Petr. > > I saw that, but looking at the corresponding e-mail, there was no clear > acknowledgement that we could merge this patch through a different tree. Fair point. One question though, what so wrong with topic branches. -- With Best Regards, Andy Shevchenko
Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes
Hi Andy, On Sat, Jan 09, 2021 at 11:07:33AM +0200, Andy Shevchenko wrote: > On Saturday, January 9, 2021, Laurent Pinchart wrote: > > > Hi Peter, Steven and Sergey, > > > > Could you please let us know if you're fine with this patch getting > > merged in v5.12 through the linux-media tree ? The cover letter contains > > additional details (in a nutshell, this is a cross-tree series and we > > would like to avoid topic branches if possible). > > There is already a tag by Petr. I saw that, but looking at the corresponding e-mail, there was no clear acknowledgement that we could merge this patch through a different tree. > > On Thu, Jan 07, 2021 at 01:28:32PM +, Daniel Scally wrote: > > > Use the software_node_unregister_nodes() helper function to unwind this > > > array in a cleaner way. > > > > > > Acked-by: Petr Mladek > > > Reviewed-by: Andy Shevchenko > > > Reviewed-by: Laurent Pinchart > > > Reviewed-by: Sergey Senozhatsky > > > Suggested-by: Andy Shevchenko > > > Signed-off-by: Daniel Scally > > > --- > > > Changes in v5: > > > > > > - None > > > > > > lib/test_printf.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/lib/test_printf.c b/lib/test_printf.c > > > index 7ac87f18a10f..7d60f24240a4 100644 > > > --- a/lib/test_printf.c > > > +++ b/lib/test_printf.c > > > @@ -644,9 +644,7 @@ static void __init fwnode_pointer(void) > > > test(second_name, "%pfwP", software_node_fwnode(&softnodes[1])); > > > test(third_name, "%pfwP", software_node_fwnode(&softnodes[2])); > > > > > > - software_node_unregister(&softnodes[2]); > > > - software_node_unregister(&softnodes[1]); > > > - software_node_unregister(&softnodes[0]); > > > + software_node_unregister_nodes(softnodes); > > > } > > > > > > static void __init -- Regards, Laurent Pinchart
Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes
Hi Peter, Steven and Sergey, Could you please let us know if you're fine with this patch getting merged in v5.12 through the linux-media tree ? The cover letter contains additional details (in a nutshell, this is a cross-tree series and we would like to avoid topic branches if possible). On Thu, Jan 07, 2021 at 01:28:32PM +, Daniel Scally wrote: > Use the software_node_unregister_nodes() helper function to unwind this > array in a cleaner way. > > Acked-by: Petr Mladek > Reviewed-by: Andy Shevchenko > Reviewed-by: Laurent Pinchart > Reviewed-by: Sergey Senozhatsky > Suggested-by: Andy Shevchenko > Signed-off-by: Daniel Scally > --- > Changes in v5: > > - None > > lib/test_printf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 7ac87f18a10f..7d60f24240a4 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -644,9 +644,7 @@ static void __init fwnode_pointer(void) > test(second_name, "%pfwP", software_node_fwnode(&softnodes[1])); > test(third_name, "%pfwP", software_node_fwnode(&softnodes[2])); > > - software_node_unregister(&softnodes[2]); > - software_node_unregister(&softnodes[1]); > - software_node_unregister(&softnodes[0]); > + software_node_unregister_nodes(softnodes); > } > > static void __init -- Regards, Laurent Pinchart
[PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes
Use the software_node_unregister_nodes() helper function to unwind this array in a cleaner way. Acked-by: Petr Mladek Reviewed-by: Andy Shevchenko Reviewed-by: Laurent Pinchart Reviewed-by: Sergey Senozhatsky Suggested-by: Andy Shevchenko Signed-off-by: Daniel Scally --- Changes in v5: - None lib/test_printf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/test_printf.c b/lib/test_printf.c index 7ac87f18a10f..7d60f24240a4 100644 --- a/lib/test_printf.c +++ b/lib/test_printf.c @@ -644,9 +644,7 @@ static void __init fwnode_pointer(void) test(second_name, "%pfwP", software_node_fwnode(&softnodes[1])); test(third_name, "%pfwP", software_node_fwnode(&softnodes[2])); - software_node_unregister(&softnodes[2]); - software_node_unregister(&softnodes[1]); - software_node_unregister(&softnodes[0]); + software_node_unregister_nodes(softnodes); } static void __init -- 2.25.1
