Re: [PATCH v5 1/4] dt-bindings: spmi: modify the constraint 'maxItems' to 'minItems'
On Wed, Dec 23, 2020 at 10:44:26AM +0800, Hsin-Hsiung Wang wrote: > The constraint of 'maxItem: 1' might be larger than 1, so we modify it > to 'minItem: 0'. > > Signed-off-by: Hsin-Hsiung Wang > --- > Documentation/devicetree/bindings/spmi/spmi.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spmi/spmi.yaml > b/Documentation/devicetree/bindings/spmi/spmi.yaml > index 173940930719..f1a26391ffde 100644 > --- a/Documentation/devicetree/bindings/spmi/spmi.yaml > +++ b/Documentation/devicetree/bindings/spmi/spmi.yaml > @@ -25,7 +25,7 @@ properties: > pattern: "^spmi@.*" > >reg: > -maxItems: 1 > +minItems: 0 0 is never right. That's 'reg' not present. > >"#address-cells": > const: 2 > -- > 2.18.0 >
Re: [PATCH v5 1/4] dt-bindings: spmi: modify the constraint 'maxItems' to 'minItems'
On Wed, 23 Dec 2020 10:44:26 +0800, Hsin-Hsiung Wang wrote: > The constraint of 'maxItem: 1' might be larger than 1, so we modify it > to 'minItem: 0'. > > Signed-off-by: Hsin-Hsiung Wang > --- > Documentation/devicetree/bindings/spmi/spmi.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/spmi.yaml: properties:reg: 'anyOf' conditional failed, one must be fixed: 'maxItems' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/spmi.yaml: properties:reg: 'oneOf' conditional failed, one must be fixed: 'minItems' is not one of ['maxItems'] 'minItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'default', '$ref'] 0 is less than the minimum of 1 /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/spmi.yaml: ignoring, error in schema: properties: reg warning: no schema found in file: ./Documentation/devicetree/bindings/spmi/spmi.yaml See https://patchwork.ozlabs.org/patch/1419575 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
[PATCH v5 1/4] dt-bindings: spmi: modify the constraint 'maxItems' to 'minItems'
The constraint of 'maxItem: 1' might be larger than 1, so we modify it to 'minItem: 0'. Signed-off-by: Hsin-Hsiung Wang --- Documentation/devicetree/bindings/spmi/spmi.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spmi/spmi.yaml b/Documentation/devicetree/bindings/spmi/spmi.yaml index 173940930719..f1a26391ffde 100644 --- a/Documentation/devicetree/bindings/spmi/spmi.yaml +++ b/Documentation/devicetree/bindings/spmi/spmi.yaml @@ -25,7 +25,7 @@ properties: pattern: "^spmi@.*" reg: -maxItems: 1 +minItems: 0 "#address-cells": const: 2 -- 2.18.0
