Re: [PATCH v5 1/5] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml

[Rob Herring]

On Mon, 19 Apr 2021 07:02:18 +1000, Alistair Francis wrote:
> Initial support for the Silergy SY7636A Power Management chip
> and regulator.
> 
> Signed-off-by: Alistair Francis 
> ---
> v5:
>  - Improve the documentation
> 
>  .../bindings/mfd/silergy,sy7636a.yaml | 70 +++
>  1 file changed, 70 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml:
 properties:regulators:properties:$ref: '/schemas/regulator/regulator.yaml#' is 
not of type 'object', 'boolean'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml:
 properties:regulators:properties: {'enum': ['$ref', 'additionalItems', 
'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 
'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 
'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 
'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 
'then', 'unevaluatedProperties']} is not allowed for '$ref'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml:
 properties:regulators:properties: {'enum': ['$ref', 'additionalItems', 
'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 
'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 
'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 
'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 
'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml:
 ignoring, error in schema: properties: regulators: properties: $ref
warning: no schema found in file: 
./Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
Documentation/devicetree/bindings/mfd/silergy,sy7636a.example.dt.yaml:0:0: 
/example-0/i2c/pmic@62: failed to match any schema with compatible: 
['silergy,sy7636a']
Documentation/devicetree/bindings/mfd/silergy,sy7636a.example.dt.yaml:0:0: 
/example-0/i2c/pmic@62/regulators: failed to match any schema with compatible: 
['silergy,sy7636a-regulator']

See https://patchwork.ozlabs.org/patch/1467830

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

[PATCH v5 1/5] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml

[Alistair Francis]

Initial support for the Silergy SY7636A Power Management chip
and regulator.

Signed-off-by: Alistair Francis 
---
v5:
 - Improve the documentation

 .../bindings/mfd/silergy,sy7636a.yaml | 70 +++
 1 file changed, 70 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml

diff --git a/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml 
b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
new file mode 100644
index ..83050c36acaf
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/silergy,sy7636a.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: silergy sy7636a PMIC
+
+maintainers:
+  - Alistair Francis 
+
+properties:
+  compatible:
+const: silergy,sy7636a
+
+  reg:
+maxItems: 1
+
+  '#thermal-sensor-cells':
+const: 0
+
+  epd-pwr-good-gpios:
+description:
+  Specifying the power good GPIOs. As defined in bindings/gpio.txt.
+maxItems: 1
+
+  regulators:
+type: object
+
+properties:
+  compatible:
+const: silergy,sy7636a-regulator
+  $ref: /schemas/regulator/regulator.yaml#
+
+  regulator-name:
+const: "vcom"
+
+  additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - '#thermal-sensor-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+i2c {
+  #address-cells = <1>;
+  #size-cells = <0>;
+
+  pmic@62 {
+compatible = "silergy,sy7636a";
+reg = <0x62>;
+status = "okay";
+pinctrl-names = "default";
+pinctrl-0 = <_epdpmic>;
+#thermal-sensor-cells = <0>;
+
+regulators {
+  compatible = "silergy,sy7636a-regulator";
+  reg_epdpmic: vcom {
+regulator-name = "vcom";
+regulator-boot-on;
+  };
+};
+  };
+};
+...
-- 
2.31.1