Am Montag, 14. April 2014, 22:51:05 schrieb Joe Perches:
Hi Joe,
> On Tue, 2014-04-15 at 07:35 +0200, Stephan Mueller wrote:
> > diff --git a/crypto/drbg.c b/crypto/drbg.c
>
> []
>
> > @@ -0,0 +1,1997 @@
>
> []
>
> > +/***
> > + * Backend cipher definitions available to DRBG
> > + ***/
> > +
> > +const struct drbg_core cores[] = {
>
> cores isn't a very good global name.
> I presume this should be static.
Agreed. static added and renamed to drbg_cores. I will wait a few days before
releasing a new version. Maybe other comments show up.
Thanks for the review.
Ciao
Stephan
--
| Cui bono? |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/