Re: [PATCH v5 2/4] dt-bindings: spmi: document binding for the Mediatek SPMI controller

[Rob Herring]

On Wed, 23 Dec 2020 10:44:27 +0800, Hsin-Hsiung Wang wrote:
> This adds documentation for the SPMI controller found on Mediatek SoCs.
> 
> Signed-off-by: Hsin-Hsiung Wang 
> ---
>  .../bindings/spmi/mtk,spmi-mtk-pmif.yaml  | 74 +++
>  1 file changed, 74 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> 

Reviewed-by: Rob Herring 

Re: [PATCH v5 2/4] dt-bindings: spmi: document binding for the Mediatek SPMI controller

[Rob Herring]

On Wed, 23 Dec 2020 10:44:27 +0800, Hsin-Hsiung Wang wrote:
> This adds documentation for the SPMI controller found on Mediatek SoCs.
> 
> Signed-off-by: Hsin-Hsiung Wang 
> ---
>  .../bindings/spmi/mtk,spmi-mtk-pmif.yaml  | 74 +++
>  1 file changed, 74 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.example.dts:19:18: 
fatal error: dt-bindings/clock/mt8192-clk.h: No such file or directory
   19 | #include 
  |  ^~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:342: 
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.example.dt.yaml] Error 
1
make: *** [Makefile:1370: dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1419576

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

[PATCH v5 2/4] dt-bindings: spmi: document binding for the Mediatek SPMI controller

[Hsin-Hsiung Wang]

This adds documentation for the SPMI controller found on Mediatek SoCs.

Signed-off-by: Hsin-Hsiung Wang 
---
 .../bindings/spmi/mtk,spmi-mtk-pmif.yaml  | 74 +++
 1 file changed, 74 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml

diff --git a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml 
b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
new file mode 100644
index ..a43b0302d503
--- /dev/null
+++ b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spmi/mtk,spmi-mtk-pmif.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek SPMI Controller Device Tree Bindings
+
+maintainers:
+  - Hsin-Hsiung Wang 
+
+description: |+
+  On MediaTek SoCs the PMIC is connected via SPMI and the controller allows
+  for multiple SoCs to control a single SPMI master.
+
+allOf:
+  - $ref: "spmi.yaml"
+
+properties:
+  compatible:
+const: mediatek,mt6873-spmi
+
+  reg:
+maxItems: 2
+
+  reg-names:
+items:
+  - const: pmif
+  - const: spmimst
+
+  clocks:
+minItems: 3
+maxItems: 3
+
+  clock-names:
+items:
+  - const: pmif_sys_ck
+  - const: pmif_tmr_ck
+  - const: spmimst_clk_mux
+
+  assigned-clocks:
+maxItems: 1
+
+  assigned-clock-parents:
+maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - clocks
+  - clock-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+#include 
+
+spmi: spmi@10027000 {
+compatible = "mediatek,mt6873-spmi";
+reg = <0 0x10027000 0 0x000e00>,
+  <0 0x10029000 0 0x000100>;
+reg-names = "pmif", "spmimst";
+clocks = <&infracfg CLK_INFRA_PMIC_AP>,
+ <&infracfg CLK_INFRA_PMIC_TMR>,
+ <&topckgen CLK_TOP_SPMI_MST_SEL>;
+clock-names = "pmif_sys_ck",
+  "pmif_tmr_ck",
+  "spmimst_clk_mux";
+assigned-clocks = <&topckgen CLK_TOP_PWRAP_ULPOSC_SEL>;
+assigned-clock-parents = <&topckgen CLK_TOP_OSC_D10>;
+};
+...
-- 
2.18.0