Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Lee Jones]

On Sat, 19 Aug 2017, Boris Brezillon wrote:

> Hi Lee,
> 
> Le Tue, 15 Aug 2017 07:58:35 +0100,
> Lee Jones  a écrit :
> 
> > On Mon, 14 Aug 2017, Andrea Adami wrote:
> > 
> > > With the introduction of sharpslpart partition parser we can now read the
> > > offsets from NAND: we specify the list of the parsers as platform data, 
> > > with
> > > cmdlinepart and ofpart parsers first allowing to override the part. table
> > > written in NAND. This is done in the board files using this driver.
> > > 
> > > Thus, we need to extend tmio_nand_data to consider the partition parsers.
> > > 
> > > Signed-off-by: Andrea Adami 
> > > ---
> > >  include/linux/mfd/tmio.h | 1 +
> > >  1 file changed, 1 insertion(+)  
> > 
> > Acked-by: Lee Jones 
> > 
> 
> I'm about to apply patches 1 to 5 of this series to the nand/next
> branch. Do you want me to create an immutable branch with this patch?

No, not for a single line change.  Git should figure that out.

Thanks for asking though.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Lee Jones]

On Sat, 19 Aug 2017, Boris Brezillon wrote:

> Hi Lee,
> 
> Le Tue, 15 Aug 2017 07:58:35 +0100,
> Lee Jones  a écrit :
> 
> > On Mon, 14 Aug 2017, Andrea Adami wrote:
> > 
> > > With the introduction of sharpslpart partition parser we can now read the
> > > offsets from NAND: we specify the list of the parsers as platform data, 
> > > with
> > > cmdlinepart and ofpart parsers first allowing to override the part. table
> > > written in NAND. This is done in the board files using this driver.
> > > 
> > > Thus, we need to extend tmio_nand_data to consider the partition parsers.
> > > 
> > > Signed-off-by: Andrea Adami 
> > > ---
> > >  include/linux/mfd/tmio.h | 1 +
> > >  1 file changed, 1 insertion(+)  
> > 
> > Acked-by: Lee Jones 
> > 
> 
> I'm about to apply patches 1 to 5 of this series to the nand/next
> branch. Do you want me to create an immutable branch with this patch?

No, not for a single line change.  Git should figure that out.

Thanks for asking though.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Boris Brezillon]

Le Sat, 19 Aug 2017 09:26:03 +0200,
Boris Brezillon  a écrit :

> Hi Lee,
> 
> Le Tue, 15 Aug 2017 07:58:35 +0100,
> Lee Jones  a écrit :
> 
> > On Mon, 14 Aug 2017, Andrea Adami wrote:
> >   
> > > With the introduction of sharpslpart partition parser we can now read the
> > > offsets from NAND: we specify the list of the parsers as platform data, 
> > > with
> > > cmdlinepart and ofpart parsers first allowing to override the part. table
> > > written in NAND. This is done in the board files using this driver.
> > > 
> > > Thus, we need to extend tmio_nand_data to consider the partition parsers.
> > > 
> > > Signed-off-by: Andrea Adami 
> > > ---
> > >  include/linux/mfd/tmio.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Acked-by: Lee Jones 
> >   
> 
> I'm about to apply patches 1 to 5 of this series to the nand/next

I meant patches 2 to 5, patch 1 still requires a few adjustments.

> branch. Do you want me to create an immutable branch with this patch?
> 
> Regards,
> 
> Boris

Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Boris Brezillon]

Le Sat, 19 Aug 2017 09:26:03 +0200,
Boris Brezillon  a écrit :

> Hi Lee,
> 
> Le Tue, 15 Aug 2017 07:58:35 +0100,
> Lee Jones  a écrit :
> 
> > On Mon, 14 Aug 2017, Andrea Adami wrote:
> >   
> > > With the introduction of sharpslpart partition parser we can now read the
> > > offsets from NAND: we specify the list of the parsers as platform data, 
> > > with
> > > cmdlinepart and ofpart parsers first allowing to override the part. table
> > > written in NAND. This is done in the board files using this driver.
> > > 
> > > Thus, we need to extend tmio_nand_data to consider the partition parsers.
> > > 
> > > Signed-off-by: Andrea Adami 
> > > ---
> > >  include/linux/mfd/tmio.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Acked-by: Lee Jones 
> >   
> 
> I'm about to apply patches 1 to 5 of this series to the nand/next

I meant patches 2 to 5, patch 1 still requires a few adjustments.

> branch. Do you want me to create an immutable branch with this patch?
> 
> Regards,
> 
> Boris

Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Wolfram Sang]

On Mon, Aug 14, 2017 at 10:48:34PM +0200, Andrea Adami wrote:
> With the introduction of sharpslpart partition parser we can now read the
> offsets from NAND: we specify the list of the parsers as platform data, with
> cmdlinepart and ofpart parsers first allowing to override the part. table
> written in NAND. This is done in the board files using this driver.
> 
> Thus, we need to extend tmio_nand_data to consider the partition parsers.
> 
> Signed-off-by: Andrea Adami 

Acked-by: Wolfram Sang 



signature.asc
Description: PGP signature

Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Wolfram Sang]

On Mon, Aug 14, 2017 at 10:48:34PM +0200, Andrea Adami wrote:
> With the introduction of sharpslpart partition parser we can now read the
> offsets from NAND: we specify the list of the parsers as platform data, with
> cmdlinepart and ofpart parsers first allowing to override the part. table
> written in NAND. This is done in the board files using this driver.
> 
> Thus, we need to extend tmio_nand_data to consider the partition parsers.
> 
> Signed-off-by: Andrea Adami 

Acked-by: Wolfram Sang 



signature.asc
Description: PGP signature

Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Boris Brezillon]

Hi Lee,

Le Tue, 15 Aug 2017 07:58:35 +0100,
Lee Jones  a écrit :

> On Mon, 14 Aug 2017, Andrea Adami wrote:
> 
> > With the introduction of sharpslpart partition parser we can now read the
> > offsets from NAND: we specify the list of the parsers as platform data, with
> > cmdlinepart and ofpart parsers first allowing to override the part. table
> > written in NAND. This is done in the board files using this driver.
> > 
> > Thus, we need to extend tmio_nand_data to consider the partition parsers.
> > 
> > Signed-off-by: Andrea Adami 
> > ---
> >  include/linux/mfd/tmio.h | 1 +
> >  1 file changed, 1 insertion(+)  
> 
> Acked-by: Lee Jones 
> 

I'm about to apply patches 1 to 5 of this series to the nand/next
branch. Do you want me to create an immutable branch with this patch?

Regards,

Boris

Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Boris Brezillon]

Hi Lee,

Le Tue, 15 Aug 2017 07:58:35 +0100,
Lee Jones  a écrit :

> On Mon, 14 Aug 2017, Andrea Adami wrote:
> 
> > With the introduction of sharpslpart partition parser we can now read the
> > offsets from NAND: we specify the list of the parsers as platform data, with
> > cmdlinepart and ofpart parsers first allowing to override the part. table
> > written in NAND. This is done in the board files using this driver.
> > 
> > Thus, we need to extend tmio_nand_data to consider the partition parsers.
> > 
> > Signed-off-by: Andrea Adami 
> > ---
> >  include/linux/mfd/tmio.h | 1 +
> >  1 file changed, 1 insertion(+)  
> 
> Acked-by: Lee Jones 
> 

I'm about to apply patches 1 to 5 of this series to the nand/next
branch. Do you want me to create an immutable branch with this patch?

Regards,

Boris

Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Lee Jones]

On Mon, 14 Aug 2017, Andrea Adami wrote:

> With the introduction of sharpslpart partition parser we can now read the
> offsets from NAND: we specify the list of the parsers as platform data, with
> cmdlinepart and ofpart parsers first allowing to override the part. table
> written in NAND. This is done in the board files using this driver.
> 
> Thus, we need to extend tmio_nand_data to consider the partition parsers.
> 
> Signed-off-by: Andrea Adami 
> ---
>  include/linux/mfd/tmio.h | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Lee Jones 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Lee Jones]

On Mon, 14 Aug 2017, Andrea Adami wrote:

> With the introduction of sharpslpart partition parser we can now read the
> offsets from NAND: we specify the list of the parsers as platform data, with
> cmdlinepart and ofpart parsers first allowing to override the part. table
> written in NAND. This is done in the board files using this driver.
> 
> Thus, we need to extend tmio_nand_data to consider the partition parsers.
> 
> Signed-off-by: Andrea Adami 
> ---
>  include/linux/mfd/tmio.h | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Lee Jones 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Andrea Adami]

With the introduction of sharpslpart partition parser we can now read the
offsets from NAND: we specify the list of the parsers as platform data, with
cmdlinepart and ofpart parsers first allowing to override the part. table
written in NAND. This is done in the board files using this driver.

Thus, we need to extend tmio_nand_data to consider the partition parsers.

Signed-off-by: Andrea Adami 
---
 include/linux/mfd/tmio.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
index 26e8f8c..357b6cfd 100644
--- a/include/linux/mfd/tmio.h
+++ b/include/linux/mfd/tmio.h
@@ -139,6 +139,7 @@ struct tmio_nand_data {
struct nand_bbt_descr   *badblock_pattern;
struct mtd_partition*partition;
unsigned intnum_partitions;
+   const char *const   *part_parsers;
 };
 
 #define FBIO_TMIO_ACC_WRITE0x7C639300
-- 
2.7.4

[PATCH v5 3/9] mfd: tmio: Add partition parsers platform data

[Andrea Adami]

With the introduction of sharpslpart partition parser we can now read the
offsets from NAND: we specify the list of the parsers as platform data, with
cmdlinepart and ofpart parsers first allowing to override the part. table
written in NAND. This is done in the board files using this driver.

Thus, we need to extend tmio_nand_data to consider the partition parsers.

Signed-off-by: Andrea Adami 
---
 include/linux/mfd/tmio.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
index 26e8f8c..357b6cfd 100644
--- a/include/linux/mfd/tmio.h
+++ b/include/linux/mfd/tmio.h
@@ -139,6 +139,7 @@ struct tmio_nand_data {
struct nand_bbt_descr   *badblock_pattern;
struct mtd_partition*partition;
unsigned intnum_partitions;
+   const char *const   *part_parsers;
 };
 
 #define FBIO_TMIO_ACC_WRITE0x7C639300
-- 
2.7.4