Re: [PATCH v5 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420
On Wed, May 14, 2014 at 02:04:51PM +0100, Arnd Bergmann wrote:
> On Wednesday 14 May 2014 13:33:55 Chander Kashyap wrote:
> >
> > diff --git a/drivers/cpuidle/cpuidle-big_little.c
> > b/drivers/cpuidle/cpuidle-big_little.c
> > index 4cd02bd..344d79fa 100644
> > --- a/drivers/cpuidle/cpuidle-big_little.c
> > +++ b/drivers/cpuidle/cpuidle-big_little.c
> > @@ -165,6 +165,7 @@ static int __init bl_idle_driver_init(struct
> > cpuidle_driver *drv, int cpu_id)
> >
> > static const struct of_device_id compatible_machine_match[] = {
> > { .compatible = "arm,vexpress,v2p-ca15_a7" },
> > + { .compatible = "samsung,exynos5420" },
> > {},
> > };
>
> Does the cpuidle-big_little driver actually care about the platform?
No, platform specific bits are hidden behind MCPM. Apart from idle states
data, that will soon be initialized through DT too.
Actually, when idle for arm64 is merged we can even rework it and end up
with a single driver, DT based, that's the ultimate goal.
> If not, it would be good to add a generic string here as well, for
> future platforms to match.
Yes, you have a point.
> It still makes sense to list both the generic string and the platform
> specific one though, in case we have to work around subtle differences.
Agreed, but subtle differences do not belong in this driver, that's the
purpose of abstracting it the best we can. I have no problem in leaving
platform specific compatible there though.
Lorenzo
>
> Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v5 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420
On Wednesday 14 May 2014 13:33:55 Chander Kashyap wrote:
>
> diff --git a/drivers/cpuidle/cpuidle-big_little.c
> b/drivers/cpuidle/cpuidle-big_little.c
> index 4cd02bd..344d79fa 100644
> --- a/drivers/cpuidle/cpuidle-big_little.c
> +++ b/drivers/cpuidle/cpuidle-big_little.c
> @@ -165,6 +165,7 @@ static int __init bl_idle_driver_init(struct
> cpuidle_driver *drv, int cpu_id)
>
> static const struct of_device_id compatible_machine_match[] = {
> { .compatible = "arm,vexpress,v2p-ca15_a7" },
> + { .compatible = "samsung,exynos5420" },
> {},
> };
Does the cpuidle-big_little driver actually care about the platform?
If not, it would be good to add a generic string here as well, for
future platforms to match.
It still makes sense to list both the generic string and the platform
specific one though, in case we have to work around subtle differences.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v5 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420
Add "samsung,exynos5420" compatible string to initialize generic
big-little cpuidle driver for Exynos5420.
Signed-off-by: Chander Kashyap
Signed-off-by: Chander Kashyap
Acked-by: Daniel Lezcano
---
Changes in v4: None
Changes in v3:
1. Add compatible string to of_device_id table insted comparing
directoly
Changes in v2: none
drivers/cpuidle/cpuidle-big_little.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpuidle/cpuidle-big_little.c
b/drivers/cpuidle/cpuidle-big_little.c
index 4cd02bd..344d79fa 100644
--- a/drivers/cpuidle/cpuidle-big_little.c
+++ b/drivers/cpuidle/cpuidle-big_little.c
@@ -165,6 +165,7 @@ static int __init bl_idle_driver_init(struct cpuidle_driver
*drv, int cpu_id)
static const struct of_device_id compatible_machine_match[] = {
{ .compatible = "arm,vexpress,v2p-ca15_a7" },
+ { .compatible = "samsung,exynos5420" },
{},
};
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
