Re: [PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration for Exynos5420
Hi Tomasz, On 16 May 2014 02:56, Tomasz Figa wrote: > Hi Chander, > > On 14.05.2014 10:03, Chander Kashyap wrote: >> Exynos5420 is big.Little Soc. It uses cpuidle-big-litle generic cpuidle >> driver. >> Hence do not allow exynos cpuidle driver registration for Exynos5420. >> >> Signed-off-by: Chander Kashyap >> Signed-off-by: Chander Kashyap >> Acked-by: Daniel Lezcano >> --- >> arch/arm/mach-exynos/cpuidle.c |3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c >> index 3dd385e..807a386 100644 >> --- a/arch/arm/mach-exynos/cpuidle.c >> +++ b/arch/arm/mach-exynos/cpuidle.c >> @@ -218,6 +218,9 @@ static int exynos_cpuidle_probe(struct platform_device >> *pdev) >> int cpu_id, ret; >> struct cpuidle_device *device; >> >> + if (soc_is_exynos5420()) >> + return -ENODEV; >> + >> if (soc_is_exynos5250()) >> exynos5_core_down_clk(); >> >> > > Why not put this in exynos.c in exynos_dt_machine_init(), so > exynos_cpuidle_init() is called only if not running on Exynos5420? > That makes more sense. I will update this Thanks > Best regards, > Tomasz -- with warm regards, Chander Kashyap -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration for Exynos5420
Hi Chander, On 14.05.2014 10:03, Chander Kashyap wrote: > Exynos5420 is big.Little Soc. It uses cpuidle-big-litle generic cpuidle > driver. > Hence do not allow exynos cpuidle driver registration for Exynos5420. > > Signed-off-by: Chander Kashyap > Signed-off-by: Chander Kashyap > Acked-by: Daniel Lezcano > --- > arch/arm/mach-exynos/cpuidle.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c > index 3dd385e..807a386 100644 > --- a/arch/arm/mach-exynos/cpuidle.c > +++ b/arch/arm/mach-exynos/cpuidle.c > @@ -218,6 +218,9 @@ static int exynos_cpuidle_probe(struct platform_device > *pdev) > int cpu_id, ret; > struct cpuidle_device *device; > > + if (soc_is_exynos5420()) > + return -ENODEV; > + > if (soc_is_exynos5250()) > exynos5_core_down_clk(); > > Why not put this in exynos.c in exynos_dt_machine_init(), so exynos_cpuidle_init() is called only if not running on Exynos5420? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration for Exynos5420
Exynos5420 is big.Little Soc. It uses cpuidle-big-litle generic cpuidle driver. Hence do not allow exynos cpuidle driver registration for Exynos5420. Signed-off-by: Chander Kashyap Signed-off-by: Chander Kashyap Acked-by: Daniel Lezcano --- arch/arm/mach-exynos/cpuidle.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index 3dd385e..807a386 100644 --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch/arm/mach-exynos/cpuidle.c @@ -218,6 +218,9 @@ static int exynos_cpuidle_probe(struct platform_device *pdev) int cpu_id, ret; struct cpuidle_device *device; + if (soc_is_exynos5420()) + return -ENODEV; + if (soc_is_exynos5250()) exynos5_core_down_clk(); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
