Re: [PATCH v6 0/4] i.MX7 PCI support

2017-03-20 Thread Andrey Smirnov 
On Mon, Mar 20, 2017 at 12:09 AM, Dong Aisheng  wrote:
> On Tue, Mar 14, 2017 at 08:18:23AM -0700, Andrey Smirnov wrote:
>> Hello, everyone:
>>
>> This is a sixth iteration of the code that adds PCI-subsystem bits
>> necessary for enabling PCI support on i.MX7.
>>
>
> 
>
>> Andrey Smirnov (4):
>>   PCI: imx6: Add code to support i.MX7D
>>   PCI: imx6: Do not wait for speed change on i.MX7
>>   PCI: imx6: Do not switch speed if Gen2 is disabled
>>   PCI: imx6: Allow probe deferal by reset GPIO
>>
>>  .../devicetree/bindings/pci/fsl,imx6q-pcie.txt |  13 +-
>>  drivers/pci/host/pci-imx6.c| 199 
>> +++--
>
> Can't apply and test it.

Sorry about that. I'll rebase the set and submit it as v7.

>
> The directory has been changed to drivers/pci/host/dwc/pci-imx6.c
> since the commit below:
> commit 950bf6388bc22c2749b8b66c501df1462639d6bd
> Author: Kishon Vijay Abraham I 
> Date:   Fri Jan 6 18:22:48 2017 +0530
>
> PCI: Move DesignWare IP support to new drivers/pci/dwc/ directory
>
> Group all the PCI drivers that use DesignWare core in dwc directory.
> dwc IP is capable of operating in both host mode and device mode and
> keeping it inside the *host* directory is misleading.
>
> Signed-off-by: Kishon Vijay Abraham I 
> Signed-off-by: Bjorn Helgaas 
> Acked-by: Jingoo Han 
> Acked-By: Joao Pinto 
>
> Regards
> Dong Aisheng
>
>>  include/linux/mfd/syscon/imx7-iomuxc-gpr.h |   4 +
>>  3 files changed, 161 insertions(+), 55 deletions(-)
>>
>
>
>> --
>> 2.9.3
>>

Re: [PATCH v6 0/4] i.MX7 PCI support

2017-03-20 Thread Andrey Smirnov 
On Mon, Mar 20, 2017 at 12:09 AM, Dong Aisheng  wrote:
> On Tue, Mar 14, 2017 at 08:18:23AM -0700, Andrey Smirnov wrote:
>> Hello, everyone:
>>
>> This is a sixth iteration of the code that adds PCI-subsystem bits
>> necessary for enabling PCI support on i.MX7.
>>
>
> 
>
>> Andrey Smirnov (4):
>>   PCI: imx6: Add code to support i.MX7D
>>   PCI: imx6: Do not wait for speed change on i.MX7
>>   PCI: imx6: Do not switch speed if Gen2 is disabled
>>   PCI: imx6: Allow probe deferal by reset GPIO
>>
>>  .../devicetree/bindings/pci/fsl,imx6q-pcie.txt |  13 +-
>>  drivers/pci/host/pci-imx6.c| 199 
>> +++--
>
> Can't apply and test it.

Sorry about that. I'll rebase the set and submit it as v7.

>
> The directory has been changed to drivers/pci/host/dwc/pci-imx6.c
> since the commit below:
> commit 950bf6388bc22c2749b8b66c501df1462639d6bd
> Author: Kishon Vijay Abraham I 
> Date:   Fri Jan 6 18:22:48 2017 +0530
>
> PCI: Move DesignWare IP support to new drivers/pci/dwc/ directory
>
> Group all the PCI drivers that use DesignWare core in dwc directory.
> dwc IP is capable of operating in both host mode and device mode and
> keeping it inside the *host* directory is misleading.
>
> Signed-off-by: Kishon Vijay Abraham I 
> Signed-off-by: Bjorn Helgaas 
> Acked-by: Jingoo Han 
> Acked-By: Joao Pinto 
>
> Regards
> Dong Aisheng
>
>>  include/linux/mfd/syscon/imx7-iomuxc-gpr.h |   4 +
>>  3 files changed, 161 insertions(+), 55 deletions(-)
>>
>
>
>> --
>> 2.9.3
>>

Re: [PATCH v6 0/4] i.MX7 PCI support

2017-03-19 Thread Dong Aisheng 
On Tue, Mar 14, 2017 at 08:18:23AM -0700, Andrey Smirnov wrote:
> Hello, everyone:
> 
> This is a sixth iteration of the code that adds PCI-subsystem bits
> necessary for enabling PCI support on i.MX7.
> 



> Andrey Smirnov (4):
>   PCI: imx6: Add code to support i.MX7D
>   PCI: imx6: Do not wait for speed change on i.MX7
>   PCI: imx6: Do not switch speed if Gen2 is disabled
>   PCI: imx6: Allow probe deferal by reset GPIO
> 
>  .../devicetree/bindings/pci/fsl,imx6q-pcie.txt |  13 +-
>  drivers/pci/host/pci-imx6.c| 199 
> +++--

Can't apply and test it.

The directory has been changed to drivers/pci/host/dwc/pci-imx6.c
since the commit below:
commit 950bf6388bc22c2749b8b66c501df1462639d6bd
Author: Kishon Vijay Abraham I 
Date:   Fri Jan 6 18:22:48 2017 +0530

PCI: Move DesignWare IP support to new drivers/pci/dwc/ directory

Group all the PCI drivers that use DesignWare core in dwc directory.
dwc IP is capable of operating in both host mode and device mode and
keeping it inside the *host* directory is misleading.

Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Bjorn Helgaas 
Acked-by: Jingoo Han 
Acked-By: Joao Pinto 

Regards
Dong Aisheng

>  include/linux/mfd/syscon/imx7-iomuxc-gpr.h |   4 +
>  3 files changed, 161 insertions(+), 55 deletions(-)
> 


> -- 
> 2.9.3
>

Re: [PATCH v6 0/4] i.MX7 PCI support

2017-03-19 Thread Dong Aisheng 
On Tue, Mar 14, 2017 at 08:18:23AM -0700, Andrey Smirnov wrote:
> Hello, everyone:
> 
> This is a sixth iteration of the code that adds PCI-subsystem bits
> necessary for enabling PCI support on i.MX7.
> 



> Andrey Smirnov (4):
>   PCI: imx6: Add code to support i.MX7D
>   PCI: imx6: Do not wait for speed change on i.MX7
>   PCI: imx6: Do not switch speed if Gen2 is disabled
>   PCI: imx6: Allow probe deferal by reset GPIO
> 
>  .../devicetree/bindings/pci/fsl,imx6q-pcie.txt |  13 +-
>  drivers/pci/host/pci-imx6.c| 199 
> +++--

Can't apply and test it.

The directory has been changed to drivers/pci/host/dwc/pci-imx6.c
since the commit below:
commit 950bf6388bc22c2749b8b66c501df1462639d6bd
Author: Kishon Vijay Abraham I 
Date:   Fri Jan 6 18:22:48 2017 +0530

PCI: Move DesignWare IP support to new drivers/pci/dwc/ directory

Group all the PCI drivers that use DesignWare core in dwc directory.
dwc IP is capable of operating in both host mode and device mode and
keeping it inside the *host* directory is misleading.

Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Bjorn Helgaas 
Acked-by: Jingoo Han 
Acked-By: Joao Pinto 

Regards
Dong Aisheng

>  include/linux/mfd/syscon/imx7-iomuxc-gpr.h |   4 +
>  3 files changed, 161 insertions(+), 55 deletions(-)
> 


> -- 
> 2.9.3
>

[PATCH v6 0/4] i.MX7 PCI support

2017-03-14 Thread Andrey Smirnov 
Hello, everyone:

This is a sixth iteration of the code that adds PCI-subsystem bits
necessary for enabling PCI support on i.MX7.

Chagnes since v5:

- Collected ACKs from Lee and Rob

Changes since v4 (can be found at [version4]):

- Dropped typo-fix patch (originally patch #1 of the
  series). Bjorn, I am assuming that patch from v4 survived
  and stayed in your tree, let me know if that is not true.

- Added patch with workaround to address speed change false
  failures (I kept it as a separate patch to better document
  exchange with NXP/Freescale that lead to that patch)

- Added patch to avoid speed change on links configured Gen1
  only (Let me know if that is a terrible idea)

- Addressed section mismatch problem by moving call to
  hook_fault_code to happend before driver registration.

Changes since v3 (can be found at [version3]):
- Move all of the reset_control_assert's into 
imx6_pcie_assert_core_reset
- Documented required reset and power domain DT bindings

Changes since v2 (can be found at [version2]):

- Collected Reviewed-by for patch #2 from Lucas
- Reset logic implementation moved out into a reset controller
  driver (see [reset1])
- Removed unused leftover code

Changes since v1 (can be found at [version1]):

- All GPC related code moved into a separate driver (see [gpc1])
- Removed GPIO probe deferral logging
- Fixed section mismatch warning
- Minor reformatting of fsl,imx6q-pcie.txt(as per Rob
  Herring's request)

[version5] https://lkml.org/lkml/2017/2/20/376
[version4] https://lkml.org/lkml/2017/2/7/478
[version3] https://lkml.org/lkml/2017/2/6/565
[version2] https://lkml.org/lkml/2017/2/1/510
[version1] https://lkml.org/lkml/2017/1/19/488
[gpc1] https://lkml.org/lkml/2017/2/6/551
[reset1] https://lkml.org/lkml/2017/2/6/554

Andrey Smirnov (4):
  PCI: imx6: Add code to support i.MX7D
  PCI: imx6: Do not wait for speed change on i.MX7
  PCI: imx6: Do not switch speed if Gen2 is disabled
  PCI: imx6: Allow probe deferal by reset GPIO

 .../devicetree/bindings/pci/fsl,imx6q-pcie.txt |  13 +-
 drivers/pci/host/pci-imx6.c| 199 +++--
 include/linux/mfd/syscon/imx7-iomuxc-gpr.h |   4 +
 3 files changed, 161 insertions(+), 55 deletions(-)

-- 
2.9.3

[PATCH v6 0/4] i.MX7 PCI support

2017-03-14 Thread Andrey Smirnov 
Hello, everyone:

This is a sixth iteration of the code that adds PCI-subsystem bits
necessary for enabling PCI support on i.MX7.

Chagnes since v5:

- Collected ACKs from Lee and Rob

Changes since v4 (can be found at [version4]):

- Dropped typo-fix patch (originally patch #1 of the
  series). Bjorn, I am assuming that patch from v4 survived
  and stayed in your tree, let me know if that is not true.

- Added patch with workaround to address speed change false
  failures (I kept it as a separate patch to better document
  exchange with NXP/Freescale that lead to that patch)

- Added patch to avoid speed change on links configured Gen1
  only (Let me know if that is a terrible idea)

- Addressed section mismatch problem by moving call to
  hook_fault_code to happend before driver registration.

Changes since v3 (can be found at [version3]):
- Move all of the reset_control_assert's into 
imx6_pcie_assert_core_reset
- Documented required reset and power domain DT bindings

Changes since v2 (can be found at [version2]):

- Collected Reviewed-by for patch #2 from Lucas
- Reset logic implementation moved out into a reset controller
  driver (see [reset1])
- Removed unused leftover code

Changes since v1 (can be found at [version1]):

- All GPC related code moved into a separate driver (see [gpc1])
- Removed GPIO probe deferral logging
- Fixed section mismatch warning
- Minor reformatting of fsl,imx6q-pcie.txt(as per Rob
  Herring's request)

[version5] https://lkml.org/lkml/2017/2/20/376
[version4] https://lkml.org/lkml/2017/2/7/478
[version3] https://lkml.org/lkml/2017/2/6/565
[version2] https://lkml.org/lkml/2017/2/1/510
[version1] https://lkml.org/lkml/2017/1/19/488
[gpc1] https://lkml.org/lkml/2017/2/6/551
[reset1] https://lkml.org/lkml/2017/2/6/554

Andrey Smirnov (4):
  PCI: imx6: Add code to support i.MX7D
  PCI: imx6: Do not wait for speed change on i.MX7
  PCI: imx6: Do not switch speed if Gen2 is disabled
  PCI: imx6: Allow probe deferal by reset GPIO

 .../devicetree/bindings/pci/fsl,imx6q-pcie.txt |  13 +-
 drivers/pci/host/pci-imx6.c| 199 +++--
 include/linux/mfd/syscon/imx7-iomuxc-gpr.h |   4 +
 3 files changed, 161 insertions(+), 55 deletions(-)

-- 
2.9.3