Re: [PATCH v6 01/17] dt-bindings: mfd: syscon: add some compatible strings for Hisilicon

2020-10-10 Thread Leizhen (ThunderTown)



On 2020/10/1 14:59, Lee Jones wrote:
> On Wed, 30 Sep 2020, Leizhen (ThunderTown) wrote:
> 
>>
>>
>> On 2020/9/30 15:11, Lee Jones wrote:
>>> On Wed, 30 Sep 2020, Zhen Lei wrote:
>>>
 Add some compatible strings for Hisilicon controllers:
 hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
 hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
 hisilicon,peri-subctrl --> HiP05/HiP06 PERI subsystem controller
 hisilicon,dsa-subctrl  --> HiP05/HiP06 DSA subsystem controller

 Signed-off-by: Zhen Lei 
 ---
  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 -
  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> This was already applied by the time you re-sent it.
>>>
>>> Any reason for sending it again?
>>
>> Path 15 are modified. The Document patches except Patch 15 are applied,
>> but the config/DTS patches are not applied(They are applied after I re-sent).
> 
> Could you please only send patches which have not been applied.

No experience. I'll pay attention next time.

> 



Re: [PATCH v6 01/17] dt-bindings: mfd: syscon: add some compatible strings for Hisilicon

2020-10-01 Thread Lee Jones
On Wed, 30 Sep 2020, Leizhen (ThunderTown) wrote:

> 
> 
> On 2020/9/30 15:11, Lee Jones wrote:
> > On Wed, 30 Sep 2020, Zhen Lei wrote:
> > 
> >> Add some compatible strings for Hisilicon controllers:
> >> hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
> >> hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
> >> hisilicon,peri-subctrl --> HiP05/HiP06 PERI subsystem controller
> >> hisilicon,dsa-subctrl  --> HiP05/HiP06 DSA subsystem controller
> >>
> >> Signed-off-by: Zhen Lei 
> >> ---
> >>  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 -
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > This was already applied by the time you re-sent it.
> > 
> > Any reason for sending it again?
> 
> Path 15 are modified. The Document patches except Patch 15 are applied,
> but the config/DTS patches are not applied(They are applied after I re-sent).

Could you please only send patches which have not been applied.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog


Re: [PATCH v6 01/17] dt-bindings: mfd: syscon: add some compatible strings for Hisilicon

2020-09-30 Thread Krzysztof Kozlowski
On Wed, 30 Sep 2020 at 05:19, Zhen Lei  wrote:
>
> Add some compatible strings for Hisilicon controllers:
> hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
> hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
> hisilicon,peri-subctrl --> HiP05/HiP06 PERI subsystem controller
> hisilicon,dsa-subctrl  --> HiP05/HiP06 DSA subsystem controller
>
> Signed-off-by: Zhen Lei 
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml 
> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 049ec2ffc7f97e4..fc2e85004d363bf 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -40,7 +40,10 @@ properties:
>- allwinner,sun50i-a64-system-controller
>- microchip,sparx5-cpu-syscon
>- mstar,msc313-pmsleep
> -
> +  - hisilicon,hi6220-sramctrl
> +  - hisilicon,pcie-sas-subctrl
> +  - hisilicon,peri-subctrl
> +  - hisilicon,dsa-subctrl

Add them in alphabetical order, not at the end of list.

Best regards,
Krzysztof


Re: [PATCH v6 01/17] dt-bindings: mfd: syscon: add some compatible strings for Hisilicon

2020-09-30 Thread Leizhen (ThunderTown)



On 2020/9/30 15:11, Lee Jones wrote:
> On Wed, 30 Sep 2020, Zhen Lei wrote:
> 
>> Add some compatible strings for Hisilicon controllers:
>> hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
>> hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
>> hisilicon,peri-subctrl --> HiP05/HiP06 PERI subsystem controller
>> hisilicon,dsa-subctrl  --> HiP05/HiP06 DSA subsystem controller
>>
>> Signed-off-by: Zhen Lei 
>> ---
>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 -
>>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> This was already applied by the time you re-sent it.
> 
> Any reason for sending it again?

Path 15 are modified. The Document patches except Patch 15 are applied,
but the config/DTS patches are not applied(They are applied after I re-sent).

> 



Re: [PATCH v6 01/17] dt-bindings: mfd: syscon: add some compatible strings for Hisilicon

2020-09-30 Thread Lee Jones
On Wed, 30 Sep 2020, Zhen Lei wrote:

> Add some compatible strings for Hisilicon controllers:
> hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
> hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
> hisilicon,peri-subctrl --> HiP05/HiP06 PERI subsystem controller
> hisilicon,dsa-subctrl  --> HiP05/HiP06 DSA subsystem controller
> 
> Signed-off-by: Zhen Lei 
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)

This was already applied by the time you re-sent it.

Any reason for sending it again?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog


[PATCH v6 01/17] dt-bindings: mfd: syscon: add some compatible strings for Hisilicon

2020-09-29 Thread Zhen Lei
Add some compatible strings for Hisilicon controllers:
hisilicon,hi6220-sramctrl  --> Hi6220 SRAM controller
hisilicon,pcie-sas-subctrl --> HiP05/HiP06 PCIe-SAS subsystem controller
hisilicon,peri-subctrl --> HiP05/HiP06 PERI subsystem controller
hisilicon,dsa-subctrl  --> HiP05/HiP06 DSA subsystem controller

Signed-off-by: Zhen Lei 
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml 
b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 049ec2ffc7f97e4..fc2e85004d363bf 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -40,7 +40,10 @@ properties:
   - allwinner,sun50i-a64-system-controller
   - microchip,sparx5-cpu-syscon
   - mstar,msc313-pmsleep
-
+  - hisilicon,hi6220-sramctrl
+  - hisilicon,pcie-sas-subctrl
+  - hisilicon,peri-subctrl
+  - hisilicon,dsa-subctrl
   - const: syscon
 
   - contains:
-- 
1.8.3