Re: [PATCH v6 2/2] Added AMS tsl2591 device tree binding
On Fri, Mar 26, 2021 at 1:43 AM Rob Herring wrote: > On Thu, 25 Mar 2021 22:05:04 +, Joe Sandom wrote: ... > > Datasheet: https://ams.com/tsl25911#tab/documents Not necessarily needed in this patch, but it's harmless. ... > However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. Joe, seems you missed this part of Rob's message when resending. -- With Best Regards, Andy Shevchenko
[RESEND][PATCH v6 2/2] Added AMS tsl2591 device tree binding
Device tree binding for AMS/TAOS tsl2591 ambient light sensor.
This driver supports configuration via device tree and sysfs.
Supported channels for raw infrared light intensity,
raw combined light intensity and illuminance in lux.
The driver additionally supports iio events on lower and
upper thresholds.
This is a very-high sensitivity light-to-digital converter that
transforms light intensity into a digital signal.
Datasheet: https://ams.com/tsl25911#tab/documents
Signed-off-by: Joe Sandom
Reviewed-by: Rob Herring
---
Changes in v6:
- No changes
Notes:
- Re-submitted to align the version with part 1 of the patch series
Reason for resend:
- Correctly pointed out that I forgot to add reviewed-by tag offered by Rob
Herring
.../bindings/iio/light/amstaos,tsl2591.yaml | 50 +++
1 file changed, 50 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml
diff --git a/Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml
b/Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml
new file mode 100644
index ..596a3bc770f4
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/amstaos,tsl2591.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AMS/TAOS TSL2591 Ambient Light Sensor (ALS)
+
+maintainers:
+ - Joe Sandom
+
+description: |
+ AMS/TAOS TSL2591 is a very-high sensitivity
+ light-to-digital converter that transforms light intensity into a digital
+ signal.
+
+properties:
+ compatible:
+const: amstaos,tsl2591
+
+ reg:
+maxItems: 1
+
+ interrupts:
+maxItems: 1
+description:
+ Interrupt (INT:Pin 2) Active low. Should be set to IRQ_TYPE_EDGE_FALLING.
+ interrupt is used to detect if the light intensity has fallen below
+ or reached above the configured threshold values.
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+#include
+i2c {
+#address-cells = <1>;
+#size-cells = <0>;
+
+tsl2591@29 {
+compatible = "amstaos,tsl2591";
+reg = <0x29>;
+interrupts = <20 IRQ_TYPE_EDGE_FALLING>;
+ };
+};
+...
--
2.17.1
Re: [PATCH v6 2/2] Added AMS tsl2591 device tree binding
On Thu, Mar 25, 2021 at 05:43:43PM -0600, Rob Herring wrote: > On Thu, 25 Mar 2021 22:05:04 +, Joe Sandom wrote: > > Device tree binding for AMS/TAOS tsl2591 ambient light sensor. > > > > This driver supports configuration via device tree and sysfs. > > Supported channels for raw infrared light intensity, > > raw combined light intensity and illuminance in lux. > > The driver additionally supports iio events on lower and > > upper thresholds. > > > > This is a very-high sensitivity light-to-digital converter that > > transforms light intensity into a digital signal. > > > > Datasheet: https://ams.com/tsl25911#tab/documents > > > > Signed-off-by: Joe Sandom > > --- > > Changes in v6: > > - No changes > > > > Notes: > > - Re-submitted to align the version with part 1 of the patch series > > > > .../bindings/iio/light/amstaos,tsl2591.yaml | 50 +++ > > 1 file changed, 50 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. > Thanks for pointing that out Rob, will amend that now and resend for this version.
Re: [PATCH v6 2/2] Added AMS tsl2591 device tree binding
On Thu, 25 Mar 2021 22:05:04 +, Joe Sandom wrote: > Device tree binding for AMS/TAOS tsl2591 ambient light sensor. > > This driver supports configuration via device tree and sysfs. > Supported channels for raw infrared light intensity, > raw combined light intensity and illuminance in lux. > The driver additionally supports iio events on lower and > upper thresholds. > > This is a very-high sensitivity light-to-digital converter that > transforms light intensity into a digital signal. > > Datasheet: https://ams.com/tsl25911#tab/documents > > Signed-off-by: Joe Sandom > --- > Changes in v6: > - No changes > > Notes: > - Re-submitted to align the version with part 1 of the patch series > > .../bindings/iio/light/amstaos,tsl2591.yaml | 50 +++ > 1 file changed, 50 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
[PATCH v6 2/2] Added AMS tsl2591 device tree binding
Device tree binding for AMS/TAOS tsl2591 ambient light sensor.
This driver supports configuration via device tree and sysfs.
Supported channels for raw infrared light intensity,
raw combined light intensity and illuminance in lux.
The driver additionally supports iio events on lower and
upper thresholds.
This is a very-high sensitivity light-to-digital converter that
transforms light intensity into a digital signal.
Datasheet: https://ams.com/tsl25911#tab/documents
Signed-off-by: Joe Sandom
---
Changes in v6:
- No changes
Notes:
- Re-submitted to align the version with part 1 of the patch series
.../bindings/iio/light/amstaos,tsl2591.yaml | 50 +++
1 file changed, 50 insertions(+)
create mode 100644
Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml
diff --git a/Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml
b/Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml
new file mode 100644
index ..596a3bc770f4
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/amstaos,tsl2591.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/amstaos,tsl2591.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AMS/TAOS TSL2591 Ambient Light Sensor (ALS)
+
+maintainers:
+ - Joe Sandom
+
+description: |
+ AMS/TAOS TSL2591 is a very-high sensitivity
+ light-to-digital converter that transforms light intensity into a digital
+ signal.
+
+properties:
+ compatible:
+const: amstaos,tsl2591
+
+ reg:
+maxItems: 1
+
+ interrupts:
+maxItems: 1
+description:
+ Interrupt (INT:Pin 2) Active low. Should be set to IRQ_TYPE_EDGE_FALLING.
+ interrupt is used to detect if the light intensity has fallen below
+ or reached above the configured threshold values.
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+#include
+i2c {
+#address-cells = <1>;
+#size-cells = <0>;
+
+tsl2591@29 {
+compatible = "amstaos,tsl2591";
+reg = <0x29>;
+interrupts = <20 IRQ_TYPE_EDGE_FALLING>;
+ };
+};
+...
--
2.17.1
