Re: [PATCH v6 4/7] pinctrl: mediatek: add pinctrl support for MT6779 SoC

2020-07-07 Thread Linus Walleij
On Thu, Jun 18, 2020 at 1:34 PM Hanks Chen  wrote:

> This adds MT6779 pinctrl driver based on MediaTek pinctrl-paris core.
>
> Acked-by: Sean Wang 
> Signed-off-by: Hanks Chen 
> Signed-off-by: Mars Cheng 
> Signed-off-by: Andy Teng 

Patch applied.

Yours,
Linus Walleij


[PATCH v6 4/7] pinctrl: mediatek: add pinctrl support for MT6779 SoC

2020-06-18 Thread Hanks Chen
This adds MT6779 pinctrl driver based on MediaTek pinctrl-paris core.

Acked-by: Sean Wang 
Signed-off-by: Hanks Chen 
Signed-off-by: Mars Cheng 
Signed-off-by: Andy Teng 
---
 drivers/pinctrl/mediatek/Kconfig  |   12 +
 drivers/pinctrl/mediatek/Makefile |1 +
 drivers/pinctrl/mediatek/pinctrl-mt6779.c |  775 +
 drivers/pinctrl/mediatek/pinctrl-mtk-mt6779.h | 2085 +
 4 files changed, 2873 insertions(+)
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt6779.c
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt6779.h

diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
index f32d364..1cedc5f 100644
--- a/drivers/pinctrl/mediatek/Kconfig
+++ b/drivers/pinctrl/mediatek/Kconfig
@@ -93,6 +93,18 @@ config PINCTRL_MT6765
default ARM64 && ARCH_MEDIATEK
select PINCTRL_MTK_PARIS
 
+config PINCTRL_MT6779
+   tristate "Mediatek MT6779 pin control"
+   depends on OF
+   depends on ARM64 || COMPILE_TEST
+   default ARM64 && ARCH_MEDIATEK
+   select PINCTRL_MTK_PARIS
+   help
+ Say yes here to support pin controller and gpio driver
+ on Mediatek MT6779 SoC.
+ In MTK platform, we support virtual gpio and use it to
+ map specific eint which doesn't have real gpio pin.
+
 config PINCTRL_MT6797
bool "Mediatek MT6797 pin control"
depends on OF
diff --git a/drivers/pinctrl/mediatek/Makefile 
b/drivers/pinctrl/mediatek/Makefile
index 4b71328..b0b07c5 100644
--- a/drivers/pinctrl/mediatek/Makefile
+++ b/drivers/pinctrl/mediatek/Makefile
@@ -12,6 +12,7 @@ obj-$(CONFIG_PINCTRL_MT2712)  += pinctrl-mt2712.o
 obj-$(CONFIG_PINCTRL_MT8135)   += pinctrl-mt8135.o
 obj-$(CONFIG_PINCTRL_MT8127)   += pinctrl-mt8127.o
 obj-$(CONFIG_PINCTRL_MT6765)   += pinctrl-mt6765.o
+obj-$(CONFIG_PINCTRL_MT6779)   += pinctrl-mt6779.o
 obj-$(CONFIG_PINCTRL_MT6797)   += pinctrl-mt6797.o
 obj-$(CONFIG_PINCTRL_MT7622)   += pinctrl-mt7622.o
 obj-$(CONFIG_PINCTRL_MT7623)   += pinctrl-mt7623.o
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt6779.c 
b/drivers/pinctrl/mediatek/pinctrl-mt6779.c
new file mode 100644
index 000..145bf22
--- /dev/null
+++ b/drivers/pinctrl/mediatek/pinctrl-mt6779.c
@@ -0,0 +1,775 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2019 MediaTek Inc.
+ * Author: Andy Teng 
+ *
+ */
+
+#include "pinctrl-mtk-mt6779.h"
+#include "pinctrl-paris.h"
+
+/* MT6779 have multiple bases to program pin configuration listed as the below:
+ * gpio:0x10005000, iocfg_rm:0x11C2, iocfg_br:0x11D1,
+ * iocfg_lm:0x11E2, iocfg_lb:0x11E7, iocfg_rt:0x11EA,
+ * iocfg_lt:0x11F2, iocfg_tl:0x11F3
+ * _i_based could be used to indicate what base the pin should be mapped into.
+ */
+
+#define PIN_FIELD_BASE(s_pin, e_pin, i_base, s_addr, x_addrs, s_bit, x_bits) \
+   PIN_FIELD_CALC(s_pin, e_pin, i_base, s_addr, x_addrs, s_bit, x_bits, \
+  32, 0)
+
+#define PINS_FIELD_BASE(s_pin, e_pin, i_base, s_addr, x_addrs, s_bit, x_bits) \
+   PIN_FIELD_CALC(s_pin, e_pin, i_base, s_addr, x_addrs, s_bit, x_bits,  \
+  32, 1)
+
+static const struct mtk_pin_field_calc mt6779_pin_mode_range[] = {
+   PIN_FIELD_BASE(0, 7, 0, 0x0300, 0x10, 0, 4),
+   PIN_FIELD_BASE(8, 15, 0, 0x0310, 0x10, 0, 4),
+   PIN_FIELD_BASE(16, 23, 0, 0x0320, 0x10, 0, 4),
+   PIN_FIELD_BASE(24, 31, 0, 0x0330, 0x10, 0, 4),
+   PIN_FIELD_BASE(32, 39, 0, 0x0340, 0x10, 0, 4),
+   PIN_FIELD_BASE(40, 47, 0, 0x0350, 0x10, 0, 4),
+   PIN_FIELD_BASE(48, 55, 0, 0x0360, 0x10, 0, 4),
+   PIN_FIELD_BASE(56, 63, 0, 0x0370, 0x10, 0, 4),
+   PIN_FIELD_BASE(64, 71, 0, 0x0380, 0x10, 0, 4),
+   PIN_FIELD_BASE(72, 79, 0, 0x0390, 0x10, 0, 4),
+   PIN_FIELD_BASE(80, 87, 0, 0x03A0, 0x10, 0, 4),
+   PIN_FIELD_BASE(88, 95, 0, 0x03B0, 0x10, 0, 4),
+   PIN_FIELD_BASE(96, 103, 0, 0x03C0, 0x10, 0, 4),
+   PIN_FIELD_BASE(104, 111, 0, 0x03D0, 0x10, 0, 4),
+   PIN_FIELD_BASE(112, 119, 0, 0x03E0, 0x10, 0, 4),
+   PIN_FIELD_BASE(120, 127, 0, 0x03F0, 0x10, 0, 4),
+   PIN_FIELD_BASE(128, 135, 0, 0x0400, 0x10, 0, 4),
+   PIN_FIELD_BASE(136, 143, 0, 0x0410, 0x10, 0, 4),
+   PIN_FIELD_BASE(144, 151, 0, 0x0420, 0x10, 0, 4),
+   PIN_FIELD_BASE(152, 159, 0, 0x0430, 0x10, 0, 4),
+   PIN_FIELD_BASE(160, 167, 0, 0x0440, 0x10, 0, 4),
+   PIN_FIELD_BASE(168, 175, 0, 0x0450, 0x10, 0, 4),
+   PIN_FIELD_BASE(176, 183, 0, 0x0460, 0x10, 0, 4),
+   PIN_FIELD_BASE(184, 191, 0, 0x0470, 0x10, 0, 4),
+   PIN_FIELD_BASE(192, 199, 0, 0x0480, 0x10, 0, 4),
+   PIN_FIELD_BASE(200, 202, 0, 0x0490, 0x10, 0, 4),
+};
+
+static const struct mtk_pin_field_calc mt6779_pin_dir_range[] = {
+   PIN_FIELD_BASE(0, 31, 0, 0x, 0x10, 0, 1),
+   PIN_FIELD_BASE(32, 63, 0, 0x0010, 0x10, 0, 1),
+   PIN_FIELD_BASE(64, 95, 0, 0x0020, 0x10, 0, 1),
+   PIN_FIELD_BASE(96, 127, 0, 0x0030,