Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

2017-03-20 Thread Shawn Guo 
On Mon, Mar 20, 2017 at 11:55:27AM +0530, Jagan Teki wrote:
> >> @@ -0,0 +1,18 @@
> >> +* MAXI MAX11801 Resistive touch screen controller with i2c interface
> >> +
> >> +Required properties:
> >> +- compatible: must be "max11801"
> >
> > Shouldn't it have a vendor prefix?
> 
> Drivers i2c_device_id.name doesn't have vendor prefix, should I fix
> that one as well?

No.  The vendor prefix is only needed for device tree compatible.

Shawn

Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

2017-03-19 Thread Jagan Teki 
On Mon, Mar 20, 2017 at 8:06 AM, Shawn Guo  wrote:
> On Thu, Mar 16, 2017 at 12:35:38PM +0530, Jagan Teki wrote:
>> From: Jagan Teki 
>>
>> Add missing documentation of max11801-ts dt-binding details.
>>
>> Cc: Mark Rutland 
>> Cc: Rob Herring 
>> Cc: Shawn Guo 
>> Cc: Michael Trimarchi 
>> Signed-off-by: Jagan Teki 
>> ---
>> Changes for v6:
>> - Replace the lable and name of the node
>>ts: max11801 => max11801: touchscreen@48
>> Changes for v5:
>> - Newly added patch
>>
>>  .../bindings/input/touchscreen/max11801-ts.txt | 18 
>> ++
>>  1 file changed, 18 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt 
>> b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>> new file mode 100644
>> index 000..4afccbe
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>> @@ -0,0 +1,18 @@
>> +* MAXI MAX11801 Resistive touch screen controller with i2c interface
>> +
>> +Required properties:
>> +- compatible: must be "max11801"
>
> Shouldn't it have a vendor prefix?

Drivers i2c_device_id.name doesn't have vendor prefix, should I fix
that one as well?

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

Re: [PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

2017-03-19 Thread Shawn Guo 
On Thu, Mar 16, 2017 at 12:35:38PM +0530, Jagan Teki wrote:
> From: Jagan Teki 
> 
> Add missing documentation of max11801-ts dt-binding details.
> 
> Cc: Mark Rutland 
> Cc: Rob Herring 
> Cc: Shawn Guo 
> Cc: Michael Trimarchi 
> Signed-off-by: Jagan Teki 
> ---
> Changes for v6:
> - Replace the lable and name of the node
>ts: max11801 => max11801: touchscreen@48
> Changes for v5:
> - Newly added patch
> 
>  .../bindings/input/touchscreen/max11801-ts.txt | 18 
> ++
>  1 file changed, 18 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt 
> b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
> new file mode 100644
> index 000..4afccbe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
> @@ -0,0 +1,18 @@
> +* MAXI MAX11801 Resistive touch screen controller with i2c interface
> +
> +Required properties:
> +- compatible: must be "max11801"

Shouldn't it have a vendor prefix?

Also I will need Rob's ACK to get this go via IMX tree.

Shawn

> +- reg: i2c slave address
> +- interrupt-parent: the phandle for the interrupt controller
> +- interrupts: touch controller interrupt
> +
> +Example:
> +
> +&i2c1 {
> + max11801: touchscreen@48 {
> + compatible = "max11801";
> + reg = <0x48>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <31 2>;
> + };
> +};
> -- 
> 1.9.1
>

[PATCH v6 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

2017-03-16 Thread Jagan Teki 
From: Jagan Teki 

Add missing documentation of max11801-ts dt-binding details.

Cc: Mark Rutland 
Cc: Rob Herring 
Cc: Shawn Guo 
Cc: Michael Trimarchi 
Signed-off-by: Jagan Teki 
---
Changes for v6:
- Replace the lable and name of the node
   ts: max11801 => max11801: touchscreen@48
Changes for v5:
- Newly added patch

 .../bindings/input/touchscreen/max11801-ts.txt | 18 ++
 1 file changed, 18 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt

diff --git 
a/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt 
b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
new file mode 100644
index 000..4afccbe
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
@@ -0,0 +1,18 @@
+* MAXI MAX11801 Resistive touch screen controller with i2c interface
+
+Required properties:
+- compatible: must be "max11801"
+- reg: i2c slave address
+- interrupt-parent: the phandle for the interrupt controller
+- interrupts: touch controller interrupt
+
+Example:
+
+&i2c1 {
+   max11801: touchscreen@48 {
+   compatible = "max11801";
+   reg = <0x48>;
+   interrupt-parent = <&gpio3>;
+   interrupts = <31 2>;
+   };
+};
-- 
1.9.1