Re: [PATCH v6 7/8] uapi: export all headers under uapi directories
Le 20/02/2017 à 11:14, Arnd Bergmann a écrit : > On Mon, Feb 20, 2017 at 10:32 AM, Nicolas Dichtel >wrote: >> Le 13/02/2017 à 08:49, Christoph Hellwig a écrit : linux/genwqe/..install.cmd linux/genwqe/.install >>> >>> Third time: NAK on exporting internal kbuild metadata. >>> >> And for the third time: this is not related to this series. Those files are >> there before my series and the goal of the series has nothing to do with >> that. >> >> Feel free to send a patch. > > Your description literally says "After this patch, the following files, which > were not exported, are now exported (with make headers_install_all)" > for the files that Christoph quoted. It that is not true, then you need to > update the patch description to say what your patch actually does. That is true. But as I explained when the comment was done the first time (and I never got any answer), these files are generated in every exported directory. Because the genwqe directory is now exported, the corresponding '..install.cmd' and '.install' are generated. See http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/Makefile.headersinst#n32 and http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/Makefile.headersinst#n130 for more details. In other words, these files are there because some new directories are exported. If those directories were added to the 'header-y' variable, the result would be the same. Regards, Nicolas
Re: [PATCH v6 7/8] uapi: export all headers under uapi directories
Le 20/02/2017 à 11:14, Arnd Bergmann a écrit : > On Mon, Feb 20, 2017 at 10:32 AM, Nicolas Dichtel > wrote: >> Le 13/02/2017 à 08:49, Christoph Hellwig a écrit : linux/genwqe/..install.cmd linux/genwqe/.install >>> >>> Third time: NAK on exporting internal kbuild metadata. >>> >> And for the third time: this is not related to this series. Those files are >> there before my series and the goal of the series has nothing to do with >> that. >> >> Feel free to send a patch. > > Your description literally says "After this patch, the following files, which > were not exported, are now exported (with make headers_install_all)" > for the files that Christoph quoted. It that is not true, then you need to > update the patch description to say what your patch actually does. That is true. But as I explained when the comment was done the first time (and I never got any answer), these files are generated in every exported directory. Because the genwqe directory is now exported, the corresponding '..install.cmd' and '.install' are generated. See http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/Makefile.headersinst#n32 and http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/Makefile.headersinst#n130 for more details. In other words, these files are there because some new directories are exported. If those directories were added to the 'header-y' variable, the result would be the same. Regards, Nicolas
Re: [PATCH v6 7/8] uapi: export all headers under uapi directories
On Mon, Feb 20, 2017 at 10:32 AM, Nicolas Dichtelwrote: > Le 13/02/2017 à 08:49, Christoph Hellwig a écrit : >>> linux/genwqe/..install.cmd >>> linux/genwqe/.install >> >> Third time: NAK on exporting internal kbuild metadata. >> > And for the third time: this is not related to this series. Those files are > there before my series and the goal of the series has nothing to do with that. > > Feel free to send a patch. Your description literally says "After this patch, the following files, which were not exported, are now exported (with make headers_install_all)" for the files that Christoph quoted. It that is not true, then you need to update the patch description to say what your patch actually does. Arnd
Re: [PATCH v6 7/8] uapi: export all headers under uapi directories
On Mon, Feb 20, 2017 at 10:32 AM, Nicolas Dichtel wrote: > Le 13/02/2017 à 08:49, Christoph Hellwig a écrit : >>> linux/genwqe/..install.cmd >>> linux/genwqe/.install >> >> Third time: NAK on exporting internal kbuild metadata. >> > And for the third time: this is not related to this series. Those files are > there before my series and the goal of the series has nothing to do with that. > > Feel free to send a patch. Your description literally says "After this patch, the following files, which were not exported, are now exported (with make headers_install_all)" for the files that Christoph quoted. It that is not true, then you need to update the patch description to say what your patch actually does. Arnd
Re: [PATCH v6 7/8] uapi: export all headers under uapi directories
Le 13/02/2017 à 08:49, Christoph Hellwig a écrit : >> linux/genwqe/..install.cmd >> linux/genwqe/.install > > Third time: NAK on exporting internal kbuild metadata. > And for the third time: this is not related to this series. Those files are there before my series and the goal of the series has nothing to do with that. Feel free to send a patch. Regards, Nicolas
Re: [PATCH v6 7/8] uapi: export all headers under uapi directories
Le 13/02/2017 à 08:49, Christoph Hellwig a écrit : >> linux/genwqe/..install.cmd >> linux/genwqe/.install > > Third time: NAK on exporting internal kbuild metadata. > And for the third time: this is not related to this series. Those files are there before my series and the goal of the series has nothing to do with that. Feel free to send a patch. Regards, Nicolas
Re: [PATCH v6 7/8] uapi: export all headers under uapi directories
> linux/genwqe/..install.cmd > linux/genwqe/.install Third time: NAK on exporting internal kbuild metadata.
Re: [PATCH v6 7/8] uapi: export all headers under uapi directories
> linux/genwqe/..install.cmd > linux/genwqe/.install Third time: NAK on exporting internal kbuild metadata.
[PATCH v6 7/8] uapi: export all headers under uapi directories
Regularly, when a new header is created in include/uapi/, the developer forgets to add it in the corresponding Kbuild file. This error is usually detected after the release is out. In fact, all headers under uapi directories should be exported, thus it's useless to have an exhaustive list. After this patch, the following files, which were not exported, are now exported (with make headers_install_all): asm-arc/kvm_para.h asm-arc/ucontext.h asm-avr32/kvm_para.h asm-blackfin/shmparam.h asm-blackfin/ucontext.h asm-c6x/shmparam.h asm-c6x/ucontext.h asm-cris/kvm_para.h asm-h8300/shmparam.h asm-h8300/ucontext.h asm-hexagon/shmparam.h asm-m32r/kvm_para.h asm-m68k/kvm_para.h asm-m68k/shmparam.h asm-metag/kvm_para.h asm-metag/shmparam.h asm-metag/ucontext.h asm-mips/hwcap.h asm-mips/reg.h asm-mips/ucontext.h asm-nios2/kvm_para.h asm-nios2/ucontext.h asm-openrisc/shmparam.h asm-parisc/kvm_para.h asm-powerpc/perf_regs.h asm-sh/kvm_para.h asm-sh/ucontext.h asm-tile/shmparam.h asm-unicore32/shmparam.h asm-unicore32/ucontext.h asm-xtensa/kvm_para.h drm/armada_drm.h drm/etnaviv_drm.h drm/omap_drm.h drm/vgem_drm.h linux/auto_dev-ioctl.h linux/batman_adv.h linux/bcache.h linux/btrfs_tree.h linux/cifs linux/cifs/..install.cmd linux/cifs/.install linux/cifs/cifs_mount.h linux/coresight-stm.h linux/cryptouser.h linux/dma-buf.h linux/genwqe linux/genwqe/..install.cmd linux/genwqe/.install linux/genwqe/genwqe_card.h linux/hash_info.h linux/kcm.h linux/kcov.h linux/kfd_ioctl.h linux/lightnvm.h linux/module.h linux/nilfs2_api.h linux/nilfs2_ondisk.h linux/nsfs.h linux/pr.h linux/qrtr.h linux/seg6.h linux/seg6_genl.h linux/seg6_hmac.h linux/seg6_iptunnel.h linux/stm.h linux/userio.h linux/wil6210_uapi.h Thanks to Julien Floretfor the tip to get all subdirs with a pure makefile command. For the record, note that exported files for asm directories are a mix of files listed by: - include/uapi/asm-generic/Kbuild.asm; - arch//include/uapi/asm/Kbuild; - arch//include/asm/Kbuild. Signed-off-by: Nicolas Dichtel Acked-by: Daniel Vetter Acked-by: Russell King Acked-by: Mark Salter Acked-by: Michael Ellerman (powerpc) --- Documentation/kbuild/makefiles.txt | 66 ++-- arch/alpha/include/uapi/asm/Kbuild | 41 --- arch/arc/include/uapi/asm/Kbuild| 3 - arch/arm/include/uapi/asm/Kbuild| 17 - arch/arm64/include/uapi/asm/Kbuild | 18 -- arch/avr32/include/uapi/asm/Kbuild | 20 -- arch/blackfin/include/uapi/asm/Kbuild | 17 - arch/c6x/include/uapi/asm/Kbuild| 8 - arch/cris/include/uapi/arch-v10/arch/Kbuild | 5 - arch/cris/include/uapi/arch-v32/arch/Kbuild | 3 - arch/cris/include/uapi/asm/Kbuild | 43 +-- arch/frv/include/uapi/asm/Kbuild| 33 -- arch/h8300/include/uapi/asm/Kbuild | 28 -- arch/hexagon/include/asm/Kbuild | 3 - arch/hexagon/include/uapi/asm/Kbuild| 13 - arch/ia64/include/uapi/asm/Kbuild | 45 --- arch/m32r/include/uapi/asm/Kbuild | 31 -- arch/m68k/include/uapi/asm/Kbuild | 24 -- arch/metag/include/uapi/asm/Kbuild | 8 - arch/microblaze/include/uapi/asm/Kbuild | 32 -- arch/mips/include/uapi/asm/Kbuild | 37 --- arch/mn10300/include/uapi/asm/Kbuild| 32 -- arch/nios2/include/uapi/asm/Kbuild | 3 +- arch/openrisc/include/asm/Kbuild| 3 - arch/openrisc/include/uapi/asm/Kbuild | 8 - arch/parisc/include/uapi/asm/Kbuild | 28 -- arch/powerpc/include/uapi/asm/Kbuild| 45 --- arch/s390/include/uapi/asm/Kbuild | 52 --- arch/score/include/asm/Kbuild | 4 - arch/score/include/uapi/asm/Kbuild | 32 -- arch/sh/include/uapi/asm/Kbuild | 23 -- arch/sparc/include/uapi/asm/Kbuild | 48 --- arch/tile/include/asm/Kbuild| 3 - arch/tile/include/uapi/arch/Kbuild | 17 - arch/tile/include/uapi/asm/Kbuild | 19 +- arch/unicore32/include/uapi/asm/Kbuild | 6 - arch/x86/include/uapi/asm/Kbuild| 58 arch/xtensa/include/uapi/asm/Kbuild | 23 -- include/Kbuild | 2 - include/asm-generic/Kbuild.asm | 1 - include/scsi/fc/Kbuild | 0 include/uapi/Kbuild | 15 - include/uapi/asm-generic/Kbuild | 36 --- include/uapi/asm-generic/Kbuild.asm | 62 ++-- include/uapi/drm/Kbuild | 22 -- include/uapi/linux/Kbuild | 485 +--- include/uapi/linux/android/Kbuild | 2 - include/uapi/linux/byteorder/Kbuild | 3 - include/uapi/linux/caif/Kbuild | 3 - include/uapi/linux/can/Kbuild | 6 -
[PATCH v6 7/8] uapi: export all headers under uapi directories
Regularly, when a new header is created in include/uapi/, the developer forgets to add it in the corresponding Kbuild file. This error is usually detected after the release is out. In fact, all headers under uapi directories should be exported, thus it's useless to have an exhaustive list. After this patch, the following files, which were not exported, are now exported (with make headers_install_all): asm-arc/kvm_para.h asm-arc/ucontext.h asm-avr32/kvm_para.h asm-blackfin/shmparam.h asm-blackfin/ucontext.h asm-c6x/shmparam.h asm-c6x/ucontext.h asm-cris/kvm_para.h asm-h8300/shmparam.h asm-h8300/ucontext.h asm-hexagon/shmparam.h asm-m32r/kvm_para.h asm-m68k/kvm_para.h asm-m68k/shmparam.h asm-metag/kvm_para.h asm-metag/shmparam.h asm-metag/ucontext.h asm-mips/hwcap.h asm-mips/reg.h asm-mips/ucontext.h asm-nios2/kvm_para.h asm-nios2/ucontext.h asm-openrisc/shmparam.h asm-parisc/kvm_para.h asm-powerpc/perf_regs.h asm-sh/kvm_para.h asm-sh/ucontext.h asm-tile/shmparam.h asm-unicore32/shmparam.h asm-unicore32/ucontext.h asm-xtensa/kvm_para.h drm/armada_drm.h drm/etnaviv_drm.h drm/omap_drm.h drm/vgem_drm.h linux/auto_dev-ioctl.h linux/batman_adv.h linux/bcache.h linux/btrfs_tree.h linux/cifs linux/cifs/..install.cmd linux/cifs/.install linux/cifs/cifs_mount.h linux/coresight-stm.h linux/cryptouser.h linux/dma-buf.h linux/genwqe linux/genwqe/..install.cmd linux/genwqe/.install linux/genwqe/genwqe_card.h linux/hash_info.h linux/kcm.h linux/kcov.h linux/kfd_ioctl.h linux/lightnvm.h linux/module.h linux/nilfs2_api.h linux/nilfs2_ondisk.h linux/nsfs.h linux/pr.h linux/qrtr.h linux/seg6.h linux/seg6_genl.h linux/seg6_hmac.h linux/seg6_iptunnel.h linux/stm.h linux/userio.h linux/wil6210_uapi.h Thanks to Julien Floret for the tip to get all subdirs with a pure makefile command. For the record, note that exported files for asm directories are a mix of files listed by: - include/uapi/asm-generic/Kbuild.asm; - arch//include/uapi/asm/Kbuild; - arch//include/asm/Kbuild. Signed-off-by: Nicolas Dichtel Acked-by: Daniel Vetter Acked-by: Russell King Acked-by: Mark Salter Acked-by: Michael Ellerman (powerpc) --- Documentation/kbuild/makefiles.txt | 66 ++-- arch/alpha/include/uapi/asm/Kbuild | 41 --- arch/arc/include/uapi/asm/Kbuild| 3 - arch/arm/include/uapi/asm/Kbuild| 17 - arch/arm64/include/uapi/asm/Kbuild | 18 -- arch/avr32/include/uapi/asm/Kbuild | 20 -- arch/blackfin/include/uapi/asm/Kbuild | 17 - arch/c6x/include/uapi/asm/Kbuild| 8 - arch/cris/include/uapi/arch-v10/arch/Kbuild | 5 - arch/cris/include/uapi/arch-v32/arch/Kbuild | 3 - arch/cris/include/uapi/asm/Kbuild | 43 +-- arch/frv/include/uapi/asm/Kbuild| 33 -- arch/h8300/include/uapi/asm/Kbuild | 28 -- arch/hexagon/include/asm/Kbuild | 3 - arch/hexagon/include/uapi/asm/Kbuild| 13 - arch/ia64/include/uapi/asm/Kbuild | 45 --- arch/m32r/include/uapi/asm/Kbuild | 31 -- arch/m68k/include/uapi/asm/Kbuild | 24 -- arch/metag/include/uapi/asm/Kbuild | 8 - arch/microblaze/include/uapi/asm/Kbuild | 32 -- arch/mips/include/uapi/asm/Kbuild | 37 --- arch/mn10300/include/uapi/asm/Kbuild| 32 -- arch/nios2/include/uapi/asm/Kbuild | 3 +- arch/openrisc/include/asm/Kbuild| 3 - arch/openrisc/include/uapi/asm/Kbuild | 8 - arch/parisc/include/uapi/asm/Kbuild | 28 -- arch/powerpc/include/uapi/asm/Kbuild| 45 --- arch/s390/include/uapi/asm/Kbuild | 52 --- arch/score/include/asm/Kbuild | 4 - arch/score/include/uapi/asm/Kbuild | 32 -- arch/sh/include/uapi/asm/Kbuild | 23 -- arch/sparc/include/uapi/asm/Kbuild | 48 --- arch/tile/include/asm/Kbuild| 3 - arch/tile/include/uapi/arch/Kbuild | 17 - arch/tile/include/uapi/asm/Kbuild | 19 +- arch/unicore32/include/uapi/asm/Kbuild | 6 - arch/x86/include/uapi/asm/Kbuild| 58 arch/xtensa/include/uapi/asm/Kbuild | 23 -- include/Kbuild | 2 - include/asm-generic/Kbuild.asm | 1 - include/scsi/fc/Kbuild | 0 include/uapi/Kbuild | 15 - include/uapi/asm-generic/Kbuild | 36 --- include/uapi/asm-generic/Kbuild.asm | 62 ++-- include/uapi/drm/Kbuild | 22 -- include/uapi/linux/Kbuild | 485 +--- include/uapi/linux/android/Kbuild | 2 - include/uapi/linux/byteorder/Kbuild | 3 - include/uapi/linux/caif/Kbuild | 3 - include/uapi/linux/can/Kbuild | 6 - include/uapi/linux/dvb/Kbuild | 9 - include/uapi/linux/hdlc/Kbuild | 2 - include/uapi/linux/hsi/Kbuild