Re: [PATCH v7] Add MediaTek MT6779 devapc driver
Hi, Neal: You may find Matthias in IRC [1], the channel name is #linux-mediatek [1] https://webchat.freenode.net/ Neal Liu 於 2020年9月30日 週三 下午3:10寫道： > > Hi Matt, > > Hope this mail could find you well. > Is everything okay? > It would be glad if you could reply me no matter the review status. > > Thanks > > -Neal > > On Tue, 2020-09-22 at 15:13 +0800, Neal Liu wrote: > > Hi Matthias, > > > > We need this driver supported on main-line. > > Could you save your time for us to review it? > > Thanks > > > > -Neal > > > > On Wed, 2020-09-16 at 16:58 +0800, Neal Liu wrote: > > > Hi Rob, Matthias, Chun-Kuang, > > > > > > Sorry for pushing you so hard. > > > May I know is this patch set is comfortable to apply on latest kernel? > > > Thanks > > > > > > -Neal > > > > > > On Wed, 2020-09-09 at 16:37 +0800, Neal Liu wrote: > > > > Hi Rob, Matthias, Chun-Kuang, > > > > > > > > Please kindly let me know your comments about this patch set. > > > > Thanks > > > > > > > > -Neal > > > > > > > > On Wed, 2020-09-02 at 14:40 +0800, Neal Liu wrote: > > > > > Hi Rob, Matthias, Chun-Kuang, > > > > > > > > > > Gentle ping for this patch set. > > > > > Thanks > > > > > > > > > > -Neal > > > > > > > > > > On Thu, 2020-08-27 at 11:06 +0800, Neal Liu wrote: > > > > > > These patch series introduce a MediaTek MT6779 devapc driver. > > > > > > > > > > > > MediaTek bus fabric provides TrustZone security support and data > > > > > > protection to prevent slaves from being accessed by unexpected > > > > > > masters. > > > > > > The security violation is logged and sent to the processor for > > > > > > further analysis or countermeasures. > > > > > > > > > > > > Any occurrence of security violation would raise an interrupt, and > > > > > > it will be handled by mtk-devapc driver. > > > > > > The violation information is printed in order to find the murderer. > > > > > > > > > > > > changes since v6: > > > > > > - remove unnecessary mask/unmask module irq during ISR. > > > > > > > > > > > > changes since v5: > > > > > > - remove redundant write reg operation. > > > > > > - use static variable of vio_dbgs instead. > > > > > > - add stop_devapc() if driver is removed. > > > > > > > > > > > > changes since v4: > > > > > > - refactor data structure. > > > > > > - merge two simple functions into one. > > > > > > - refactor register setting to prevent too many function call > > > > > > overhead. > > > > > > > > > > > > changes since v3: > > > > > > - revise violation handling flow to make it more easily to > > > > > > understand > > > > > > hardware behavior. > > > > > > - add more comments to understand how hardware works. > > > > > > > > > > > > changes since v2: > > > > > > - pass platform info through DT data. > > > > > > - remove unnecessary function. > > > > > > - remove slave_type because it always equals to 1 in current > > > > > > support SoC. > > > > > > - use vio_idx_num instread of list all devices' index. > > > > > > - add more comments to describe hardware behavior. > > > > > > > > > > > > changes since v1: > > > > > > - move SoC specific part to DT data. > > > > > > - remove unnecessary boundary check. > > > > > > - remove unnecessary data type declaration. > > > > > > - use read_poll_timeout() instread of for loop polling. > > > > > > - revise coding style elegantly. > > > > > > > > > > > > > > > > > > *** BLURB HERE *** > > > > > > > > > > > > Neal Liu (2): > > > > > > dt-bindings: devapc: add bindings for mtk-devapc > > > > > > soc: mediatek: add mt6779 devapc driver > > > > > > > > > > > > .../bindings/soc/mediatek/devapc.yaml | 58 > > > > > > drivers/soc/mediatek/Kconfig | 9 + > > > > > > drivers/soc/mediatek/Makefile | 1 + > > > > > > drivers/soc/mediatek/mtk-devapc.c | 305 > > > > > > ++ > > > > > > 4 files changed, 373 insertions(+) > > > > > > create mode 100644 > > > > > > Documentation/devicetree/bindings/soc/mediatek/devapc.yaml > > > > > > create mode 100644 drivers/soc/mediatek/mtk-devapc.c > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
Re: [PATCH v7] Add MediaTek MT6779 devapc driver
Hi Matt, Hope this mail could find you well. Is everything okay? It would be glad if you could reply me no matter the review status. Thanks -Neal On Tue, 2020-09-22 at 15:13 +0800, Neal Liu wrote: > Hi Matthias, > > We need this driver supported on main-line. > Could you save your time for us to review it? > Thanks > > -Neal > > On Wed, 2020-09-16 at 16:58 +0800, Neal Liu wrote: > > Hi Rob, Matthias, Chun-Kuang, > > > > Sorry for pushing you so hard. > > May I know is this patch set is comfortable to apply on latest kernel? > > Thanks > > > > -Neal > > > > On Wed, 2020-09-09 at 16:37 +0800, Neal Liu wrote: > > > Hi Rob, Matthias, Chun-Kuang, > > > > > > Please kindly let me know your comments about this patch set. > > > Thanks > > > > > > -Neal > > > > > > On Wed, 2020-09-02 at 14:40 +0800, Neal Liu wrote: > > > > Hi Rob, Matthias, Chun-Kuang, > > > > > > > > Gentle ping for this patch set. > > > > Thanks > > > > > > > > -Neal > > > > > > > > On Thu, 2020-08-27 at 11:06 +0800, Neal Liu wrote: > > > > > These patch series introduce a MediaTek MT6779 devapc driver. > > > > > > > > > > MediaTek bus fabric provides TrustZone security support and data > > > > > protection to prevent slaves from being accessed by unexpected > > > > > masters. > > > > > The security violation is logged and sent to the processor for > > > > > further analysis or countermeasures. > > > > > > > > > > Any occurrence of security violation would raise an interrupt, and it > > > > > will be handled by mtk-devapc driver. > > > > > The violation information is printed in order to find the murderer. > > > > > > > > > > changes since v6: > > > > > - remove unnecessary mask/unmask module irq during ISR. > > > > > > > > > > changes since v5: > > > > > - remove redundant write reg operation. > > > > > - use static variable of vio_dbgs instead. > > > > > - add stop_devapc() if driver is removed. > > > > > > > > > > changes since v4: > > > > > - refactor data structure. > > > > > - merge two simple functions into one. > > > > > - refactor register setting to prevent too many function call > > > > > overhead. > > > > > > > > > > changes since v3: > > > > > - revise violation handling flow to make it more easily to understand > > > > > hardware behavior. > > > > > - add more comments to understand how hardware works. > > > > > > > > > > changes since v2: > > > > > - pass platform info through DT data. > > > > > - remove unnecessary function. > > > > > - remove slave_type because it always equals to 1 in current support > > > > > SoC. > > > > > - use vio_idx_num instread of list all devices' index. > > > > > - add more comments to describe hardware behavior. > > > > > > > > > > changes since v1: > > > > > - move SoC specific part to DT data. > > > > > - remove unnecessary boundary check. > > > > > - remove unnecessary data type declaration. > > > > > - use read_poll_timeout() instread of for loop polling. > > > > > - revise coding style elegantly. > > > > > > > > > > > > > > > *** BLURB HERE *** > > > > > > > > > > Neal Liu (2): > > > > > dt-bindings: devapc: add bindings for mtk-devapc > > > > > soc: mediatek: add mt6779 devapc driver > > > > > > > > > > .../bindings/soc/mediatek/devapc.yaml | 58 > > > > > drivers/soc/mediatek/Kconfig | 9 + > > > > > drivers/soc/mediatek/Makefile | 1 + > > > > > drivers/soc/mediatek/mtk-devapc.c | 305 > > > > > ++ > > > > > 4 files changed, 373 insertions(+) > > > > > create mode 100644 > > > > > Documentation/devicetree/bindings/soc/mediatek/devapc.yaml > > > > > create mode 100644 drivers/soc/mediatek/mtk-devapc.c > > > > > > > > > > > > > > > > > > > > > > > > >
Re: [PATCH v7] Add MediaTek MT6779 devapc driver
Hi Matthias, We need this driver supported on main-line. Could you save your time for us to review it? Thanks -Neal On Wed, 2020-09-16 at 16:58 +0800, Neal Liu wrote: > Hi Rob, Matthias, Chun-Kuang, > > Sorry for pushing you so hard. > May I know is this patch set is comfortable to apply on latest kernel? > Thanks > > -Neal > > On Wed, 2020-09-09 at 16:37 +0800, Neal Liu wrote: > > Hi Rob, Matthias, Chun-Kuang, > > > > Please kindly let me know your comments about this patch set. > > Thanks > > > > -Neal > > > > On Wed, 2020-09-02 at 14:40 +0800, Neal Liu wrote: > > > Hi Rob, Matthias, Chun-Kuang, > > > > > > Gentle ping for this patch set. > > > Thanks > > > > > > -Neal > > > > > > On Thu, 2020-08-27 at 11:06 +0800, Neal Liu wrote: > > > > These patch series introduce a MediaTek MT6779 devapc driver. > > > > > > > > MediaTek bus fabric provides TrustZone security support and data > > > > protection to prevent slaves from being accessed by unexpected masters. > > > > The security violation is logged and sent to the processor for further > > > > analysis or countermeasures. > > > > > > > > Any occurrence of security violation would raise an interrupt, and it > > > > will be handled by mtk-devapc driver. > > > > The violation information is printed in order to find the murderer. > > > > > > > > changes since v6: > > > > - remove unnecessary mask/unmask module irq during ISR. > > > > > > > > changes since v5: > > > > - remove redundant write reg operation. > > > > - use static variable of vio_dbgs instead. > > > > - add stop_devapc() if driver is removed. > > > > > > > > changes since v4: > > > > - refactor data structure. > > > > - merge two simple functions into one. > > > > - refactor register setting to prevent too many function call overhead. > > > > > > > > changes since v3: > > > > - revise violation handling flow to make it more easily to understand > > > > hardware behavior. > > > > - add more comments to understand how hardware works. > > > > > > > > changes since v2: > > > > - pass platform info through DT data. > > > > - remove unnecessary function. > > > > - remove slave_type because it always equals to 1 in current support > > > > SoC. > > > > - use vio_idx_num instread of list all devices' index. > > > > - add more comments to describe hardware behavior. > > > > > > > > changes since v1: > > > > - move SoC specific part to DT data. > > > > - remove unnecessary boundary check. > > > > - remove unnecessary data type declaration. > > > > - use read_poll_timeout() instread of for loop polling. > > > > - revise coding style elegantly. > > > > > > > > > > > > *** BLURB HERE *** > > > > > > > > Neal Liu (2): > > > > dt-bindings: devapc: add bindings for mtk-devapc > > > > soc: mediatek: add mt6779 devapc driver > > > > > > > > .../bindings/soc/mediatek/devapc.yaml | 58 > > > > drivers/soc/mediatek/Kconfig | 9 + > > > > drivers/soc/mediatek/Makefile | 1 + > > > > drivers/soc/mediatek/mtk-devapc.c | 305 ++ > > > > 4 files changed, 373 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/soc/mediatek/devapc.yaml > > > > create mode 100644 drivers/soc/mediatek/mtk-devapc.c > > > > > > > > > > > > > > > >
Re: [PATCH v7] Add MediaTek MT6779 devapc driver
Hi Rob, Matthias, Chun-Kuang, Sorry for pushing you so hard. May I know is this patch set is comfortable to apply on latest kernel? Thanks -Neal On Wed, 2020-09-09 at 16:37 +0800, Neal Liu wrote: > Hi Rob, Matthias, Chun-Kuang, > > Please kindly let me know your comments about this patch set. > Thanks > > -Neal > > On Wed, 2020-09-02 at 14:40 +0800, Neal Liu wrote: > > Hi Rob, Matthias, Chun-Kuang, > > > > Gentle ping for this patch set. > > Thanks > > > > -Neal > > > > On Thu, 2020-08-27 at 11:06 +0800, Neal Liu wrote: > > > These patch series introduce a MediaTek MT6779 devapc driver. > > > > > > MediaTek bus fabric provides TrustZone security support and data > > > protection to prevent slaves from being accessed by unexpected masters. > > > The security violation is logged and sent to the processor for further > > > analysis or countermeasures. > > > > > > Any occurrence of security violation would raise an interrupt, and it > > > will be handled by mtk-devapc driver. > > > The violation information is printed in order to find the murderer. > > > > > > changes since v6: > > > - remove unnecessary mask/unmask module irq during ISR. > > > > > > changes since v5: > > > - remove redundant write reg operation. > > > - use static variable of vio_dbgs instead. > > > - add stop_devapc() if driver is removed. > > > > > > changes since v4: > > > - refactor data structure. > > > - merge two simple functions into one. > > > - refactor register setting to prevent too many function call overhead. > > > > > > changes since v3: > > > - revise violation handling flow to make it more easily to understand > > > hardware behavior. > > > - add more comments to understand how hardware works. > > > > > > changes since v2: > > > - pass platform info through DT data. > > > - remove unnecessary function. > > > - remove slave_type because it always equals to 1 in current support SoC. > > > - use vio_idx_num instread of list all devices' index. > > > - add more comments to describe hardware behavior. > > > > > > changes since v1: > > > - move SoC specific part to DT data. > > > - remove unnecessary boundary check. > > > - remove unnecessary data type declaration. > > > - use read_poll_timeout() instread of for loop polling. > > > - revise coding style elegantly. > > > > > > > > > *** BLURB HERE *** > > > > > > Neal Liu (2): > > > dt-bindings: devapc: add bindings for mtk-devapc > > > soc: mediatek: add mt6779 devapc driver > > > > > > .../bindings/soc/mediatek/devapc.yaml | 58 > > > drivers/soc/mediatek/Kconfig | 9 + > > > drivers/soc/mediatek/Makefile | 1 + > > > drivers/soc/mediatek/mtk-devapc.c | 305 ++ > > > 4 files changed, 373 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/soc/mediatek/devapc.yaml > > > create mode 100644 drivers/soc/mediatek/mtk-devapc.c > > > > > > > > >
Re: [PATCH v7] Add MediaTek MT6779 devapc driver
Hi Rob, Matthias, Chun-Kuang, Please kindly let me know your comments about this patch set. Thanks -Neal On Wed, 2020-09-02 at 14:40 +0800, Neal Liu wrote: > Hi Rob, Matthias, Chun-Kuang, > > Gentle ping for this patch set. > Thanks > > -Neal > > On Thu, 2020-08-27 at 11:06 +0800, Neal Liu wrote: > > These patch series introduce a MediaTek MT6779 devapc driver. > > > > MediaTek bus fabric provides TrustZone security support and data protection > > to prevent slaves from being accessed by unexpected masters. > > The security violation is logged and sent to the processor for further > > analysis or countermeasures. > > > > Any occurrence of security violation would raise an interrupt, and it will > > be handled by mtk-devapc driver. > > The violation information is printed in order to find the murderer. > > > > changes since v6: > > - remove unnecessary mask/unmask module irq during ISR. > > > > changes since v5: > > - remove redundant write reg operation. > > - use static variable of vio_dbgs instead. > > - add stop_devapc() if driver is removed. > > > > changes since v4: > > - refactor data structure. > > - merge two simple functions into one. > > - refactor register setting to prevent too many function call overhead. > > > > changes since v3: > > - revise violation handling flow to make it more easily to understand > > hardware behavior. > > - add more comments to understand how hardware works. > > > > changes since v2: > > - pass platform info through DT data. > > - remove unnecessary function. > > - remove slave_type because it always equals to 1 in current support SoC. > > - use vio_idx_num instread of list all devices' index. > > - add more comments to describe hardware behavior. > > > > changes since v1: > > - move SoC specific part to DT data. > > - remove unnecessary boundary check. > > - remove unnecessary data type declaration. > > - use read_poll_timeout() instread of for loop polling. > > - revise coding style elegantly. > > > > > > *** BLURB HERE *** > > > > Neal Liu (2): > > dt-bindings: devapc: add bindings for mtk-devapc > > soc: mediatek: add mt6779 devapc driver > > > > .../bindings/soc/mediatek/devapc.yaml | 58 > > drivers/soc/mediatek/Kconfig | 9 + > > drivers/soc/mediatek/Makefile | 1 + > > drivers/soc/mediatek/mtk-devapc.c | 305 ++ > > 4 files changed, 373 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/soc/mediatek/devapc.yaml > > create mode 100644 drivers/soc/mediatek/mtk-devapc.c > > > >
Re: [PATCH v7] Add MediaTek MT6779 devapc driver
Hi Rob, Matthias, Chun-Kuang, Gentle ping for this patch set. Thanks -Neal On Thu, 2020-08-27 at 11:06 +0800, Neal Liu wrote: > These patch series introduce a MediaTek MT6779 devapc driver. > > MediaTek bus fabric provides TrustZone security support and data protection > to prevent slaves from being accessed by unexpected masters. > The security violation is logged and sent to the processor for further > analysis or countermeasures. > > Any occurrence of security violation would raise an interrupt, and it will be > handled by mtk-devapc driver. > The violation information is printed in order to find the murderer. > > changes since v6: > - remove unnecessary mask/unmask module irq during ISR. > > changes since v5: > - remove redundant write reg operation. > - use static variable of vio_dbgs instead. > - add stop_devapc() if driver is removed. > > changes since v4: > - refactor data structure. > - merge two simple functions into one. > - refactor register setting to prevent too many function call overhead. > > changes since v3: > - revise violation handling flow to make it more easily to understand > hardware behavior. > - add more comments to understand how hardware works. > > changes since v2: > - pass platform info through DT data. > - remove unnecessary function. > - remove slave_type because it always equals to 1 in current support SoC. > - use vio_idx_num instread of list all devices' index. > - add more comments to describe hardware behavior. > > changes since v1: > - move SoC specific part to DT data. > - remove unnecessary boundary check. > - remove unnecessary data type declaration. > - use read_poll_timeout() instread of for loop polling. > - revise coding style elegantly. > > > *** BLURB HERE *** > > Neal Liu (2): > dt-bindings: devapc: add bindings for mtk-devapc > soc: mediatek: add mt6779 devapc driver > > .../bindings/soc/mediatek/devapc.yaml | 58 > drivers/soc/mediatek/Kconfig | 9 + > drivers/soc/mediatek/Makefile | 1 + > drivers/soc/mediatek/mtk-devapc.c | 305 ++ > 4 files changed, 373 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/devapc.yaml > create mode 100644 drivers/soc/mediatek/mtk-devapc.c >
[PATCH v7] Add MediaTek MT6779 devapc driver
These patch series introduce a MediaTek MT6779 devapc driver. MediaTek bus fabric provides TrustZone security support and data protection to prevent slaves from being accessed by unexpected masters. The security violation is logged and sent to the processor for further analysis or countermeasures. Any occurrence of security violation would raise an interrupt, and it will be handled by mtk-devapc driver. The violation information is printed in order to find the murderer. changes since v6: - remove unnecessary mask/unmask module irq during ISR. changes since v5: - remove redundant write reg operation. - use static variable of vio_dbgs instead. - add stop_devapc() if driver is removed. changes since v4: - refactor data structure. - merge two simple functions into one. - refactor register setting to prevent too many function call overhead. changes since v3: - revise violation handling flow to make it more easily to understand hardware behavior. - add more comments to understand how hardware works. changes since v2: - pass platform info through DT data. - remove unnecessary function. - remove slave_type because it always equals to 1 in current support SoC. - use vio_idx_num instread of list all devices' index. - add more comments to describe hardware behavior. changes since v1: - move SoC specific part to DT data. - remove unnecessary boundary check. - remove unnecessary data type declaration. - use read_poll_timeout() instread of for loop polling. - revise coding style elegantly. *** BLURB HERE *** Neal Liu (2): dt-bindings: devapc: add bindings for mtk-devapc soc: mediatek: add mt6779 devapc driver .../bindings/soc/mediatek/devapc.yaml | 58 drivers/soc/mediatek/Kconfig | 9 + drivers/soc/mediatek/Makefile | 1 + drivers/soc/mediatek/mtk-devapc.c | 305 ++ 4 files changed, 373 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/mediatek/devapc.yaml create mode 100644 drivers/soc/mediatek/mtk-devapc.c -- 2.18.0
