RE: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver
On Fri, Sep 13, 2016 at 07:46:31AM, Paul Gortmaker wrote:
>> On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker
>> wrote:
>> >> > This looks like an invalid address, and
>> >>
>> >> >> +MODULE_AUTHOR("Ajay Thomas
>> >> >> +");
>> >> >
>> >> > ...the same here. In fact it sure looks like two names. Anyway
>> >> > I just got a bounce when I tried to use it...
>> >>
>> >> It might be that person is no longer working for Intel, though I
>> >> think It would be better log message for that.
>> >
>> > That might make sense if the driver was old, but it hasn't even hit
>> > mainline yet -- it is only in linux-next, so it cant be more than a
>> > few weeks old.
>>
>> It's already quite off topic, so, I would just say that it is still
>> valid point. Starting from some version of the series (which takes
>> couple of months?) Bin Gao did improvements.
>
>Not sure why you would call it off topic -- a new driver appearing in mainline
>should have a valid author entry, and if it is an accidental merge of two
>names into one then Bin Gao is the person who can ack that and subsequently
>fix it.
>
>P.
The original email is correct and it's not an accidental merge of two names.
The cause is Ajay quitted Intel one month back so his email address is no
longer valid.
-Bin
Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver
[Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016
(Tue 17:35) Andy Shevchenko wrote:
> On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker
> wrote:
> >> > This looks like an invalid address, and
> >>
> >> >> +MODULE_AUTHOR("Ajay Thomas
> >> >> ");
> >> >
> >> > ...the same here. In fact it sure looks like two names. Anyway I just
> >> > got a
> >> > bounce when I tried to use it...
> >>
> >> It might be that person is no longer working for Intel, though I think
> >> It would be better log message for that.
> >
> > That might make sense if the driver was old, but it hasn't even hit
> > mainline yet -- it is only in linux-next, so it cant be more than a few
> > weeks old.
>
> It's already quite off topic, so, I would just say that it is still
> valid point. Starting from some version of the series (which takes
> couple of months?) Bin Gao did improvements.
Not sure why you would call it off topic -- a new driver appearing in
mainline should have a valid author entry, and if it is an accidental
merge of two names into one then Bin Gao is the person who can ack that
and subsequently fix it.
P.
--
>
> --
> With Best Regards,
> Andy Shevchenko
Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver
On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker
wrote:
>> > This looks like an invalid address, and
>>
>> >> +MODULE_AUTHOR("Ajay Thomas ");
>> >
>> > ...the same here. In fact it sure looks like two names. Anyway I just
>> > got a
>> > bounce when I tried to use it...
>>
>> It might be that person is no longer working for Intel, though I think
>> It would be better log message for that.
>
> That might make sense if the driver was old, but it hasn't even hit
> mainline yet -- it is only in linux-next, so it cant be more than a few
> weeks old.
It's already quite off topic, so, I would just say that it is still
valid point. Starting from some version of the series (which takes
couple of months?) Bin Gao did improvements.
--
With Best Regards,
Andy Shevchenko
Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver
[Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016
(Tue 10:02) Andy Shevchenko wrote:
> On Tue, Sep 13, 2016 at 1:37 AM, Paul Gortmaker
> wrote:
> >> Signed-off-by: Ajay Thomas
> >
> > This looks like an invalid address, and
>
> >> +MODULE_AUTHOR("Ajay Thomas ");
> >
> > ...the same here. In fact it sure looks like two names. Anyway I just got
> > a
> > bounce when I tried to use it...
>
> It might be that person is no longer working for Intel, though I think
> It would be better log message for that.
That might make sense if the driver was old, but it hasn't even hit
mainline yet -- it is only in linux-next, so it cant be more than a few
weeks old.
P.
--
>
> --
> With Best Regards,
> Andy Shevchenko
Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver
On Tue, Sep 13, 2016 at 1:37 AM, Paul Gortmaker
wrote:
>> Signed-off-by: Ajay Thomas
>
> This looks like an invalid address, and
>> +MODULE_AUTHOR("Ajay Thomas ");
>
> ...the same here. In fact it sure looks like two names. Anyway I just got a
> bounce when I tried to use it...
It might be that person is no longer working for Intel, though I think
It would be better log message for that.
--
With Best Regards,
Andy Shevchenko
Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver
On Mon, Jul 25, 2016 at 5:59 PM, Bin Gao wrote:
> This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC.
> This driver is based on gpio-crystalcove.c.
>
> Signed-off-by: Ajay Thomas
This looks like an invalid address, and
> Signed-off-by: Bin Gao
> Reviewed-by: Andy Shevchenko
> Reviewed-by: Mika Westerberg
> ---
[]
> +module_platform_driver(wcove_gpio_driver);
> +
> +MODULE_AUTHOR("Ajay Thomas ");
...the same here. In fact it sure looks like two names. Anyway I just got a
bounce when I tried to use it...
Paul.
--
> +MODULE_AUTHOR("Bin Gao ");
> +MODULE_DESCRIPTION("Intel Whiskey Cove GPIO Driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:bxt_wcove_gpio");
> --
> 1.9.1
>
Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver
On Mon, Jul 25, 2016 at 11:59 PM, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. > > Signed-off-by: Ajay Thomas > Signed-off-by: Bin Gao > Reviewed-by: Andy Shevchenko > Reviewed-by: Mika Westerberg > --- > Changes in v7: This v7 patch applied. Can you please send a separate patch adding .get_direction() to the gpiochip? It's a feature I've been pushing more and more recently. Yours, Linus Walleij
[PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver
This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao Reviewed-by: Andy Shevchenko Reviewed-by: Mika Westerberg --- Changes in v7: - Fixed various coding style comments from Andy Shevchenko Changes in v6: - Removed unnecessary wcove_gpio_remove() - Used devm_gpiochip_remove() instead of gpiochip_remove() - Various coding style changes per Mika's comment Changes in v5: - Revisited the interrupt handler code to iterate until all pending interrupts are handled. This change is to avoid missing interrupt when we're inside the interrupt handler. - Used regmap_bulk_read() to read address adjacent registers. Changes in v4: - Converted CTLI_INTCNT_XX macros to less verbose ones INT_DETECT_XX. - Add comments about why there is no .pm for the driver. - Header files re-ordered. - Various coding style change to address Andy's comments. Changes in v3: - Fixed the year in copyright line(2015-->2016). - Removed DRV_NAME macro. - Added kernel-doc for regmap_irq_chip of the wcove_gpio structure. - Line length fix. Changes in v2: - Typo fix (Whsikey --> Whiskey). - Included linux/gpio/driver.h instead of linux/gpio.h - Implemented .set_single_ended(). - Added GPIO register description. - Replaced container_of() with gpiochip_get_data(). - Removed unnecessary "if (gpio > WCOVE_VGPIO_NUM" check. - Removed the device id table and added MODULE_ALIAS(). drivers/gpio/Kconfig | 13 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-wcove.c | 455 ++ 3 files changed, 469 insertions(+) create mode 100644 drivers/gpio/gpio-wcove.c diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 536112f..240ae7c 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -972,6 +972,19 @@ config GPIO_UCB1400 This enables support for the Philips UCB1400 GPIO pins. The UCB1400 is an AC97 audio codec. +config GPIO_WHISKEY_COVE + tristate "GPIO support for Whiskey Cove PMIC" + depends on INTEL_SOC_PMIC + select GPIOLIB_IRQCHIP + help + Support for GPIO pins on Whiskey Cove PMIC. + + Say Yes if you have a Intel SoC based tablet with Whiskey Cove PMIC + inside. + + This driver can also be built as a module. If so, the module will be + called gpio-wcove. + config GPIO_WM831X tristate "WM831x GPIOs" depends on MFD_WM831X diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index 991598e..fff27b0 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile @@ -118,6 +118,7 @@ obj-$(CONFIG_GPIO_VF610)+= gpio-vf610.o obj-$(CONFIG_GPIO_VIPERBOARD) += gpio-viperboard.o obj-$(CONFIG_GPIO_VR41XX) += gpio-vr41xx.o obj-$(CONFIG_GPIO_VX855) += gpio-vx855.o +obj-$(CONFIG_GPIO_WHISKEY_COVE)+= gpio-wcove.o obj-$(CONFIG_GPIO_WM831X) += gpio-wm831x.o obj-$(CONFIG_GPIO_WM8350) += gpio-wm8350.o obj-$(CONFIG_GPIO_WM8994) += gpio-wm8994.o diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c new file mode 100644 index 000..f5c88df --- /dev/null +++ b/drivers/gpio/gpio-wcove.c @@ -0,0 +1,455 @@ +/* + * Intel Whiskey Cove PMIC GPIO Driver + * + * This driver is written based on gpio-crystalcove.c + * + * Copyright (C) 2016 Intel Corporation. All rights reserved. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License version + * 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include +#include +#include +#include +#include +#include + +/* + * Whiskey Cove PMIC has 13 physical GPIO pins divided into 3 banks: + * Bank 0: Pin 0 - 6 + * Bank 1: Pin 7 - 10 + * Bank 2: Pin 11 -12 + * Each pin has one output control register and one input control register. + */ +#define BANK0_NR_PINS 7 +#define BANK1_NR_PINS 4 +#define BANK2_NR_PINS 2 +#define WCOVE_GPIO_NUM (BANK0_NR_PINS + BANK1_NR_PINS + BANK2_NR_PINS) +#define WCOVE_VGPIO_NUM94 +/* GPIO output control registers (one per pin): 0x4e44 - 0x4e50 */ +#define GPIO_OUT_CTRL_BASE 0x4e44 +/* GPIO input control registers (one per pin): 0x4e51 - 0x4e5d */ +#define GPIO_IN_CTRL_BASE 0x4e51 + +/* + * GPIO interrupts are organized in two groups: + * Group 0: Bank 0 pins (Pin 0 - 6) + * Group 1: Bank 1 and Bank 2 pins (Pin 7 - 12) + * Each group has two registers (one bit per pin): status and mask. + */ +#define GROUP0_NR_IRQS 7 +#define GROUP1_NR_IRQS 6 +#define IRQ_MASK_BASE 0x4e19 +#define IRQ_STATUS_BASE0x4
