Re: [PATCH v7 00/33] Provide netdev naming-policy via sysfs
From: Tom Gundersen Date: Thu, 10 Jul 2014 11:19:42 +0200 > Thanks for the quick answer. > > On Thu, Jul 10, 2014 at 10:43 AM, David Miller wrote: >> It is not reasonable to expect people to review such a large number of >> patches at one time. >> >> Split your series up into logical, and more reasonably sized chunks. >> >> I'd say 14 or 15 at a time is the limit. >> >> I'm not even looking at this series until you submit it more reasonably. >> >> Thank you. > > Ok. I suggest you review patches 1-7, as these are the generic ones. > Then once they have been applied I can resubmit the subsequent patches > individually. > > Do you want me to resubmit patches 1-7, or do you just want to pick > them from this series as they are? I said submit it more reasonably, what do you think that means? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v7 00/33] Provide netdev naming-policy via sysfs
On Thu, Jul 10, 2014 at 11:19 AM, Tom Gundersen wrote: > Thanks for the quick answer. > > On Thu, Jul 10, 2014 at 10:43 AM, David Miller wrote: >> It is not reasonable to expect people to review such a large number of >> patches at one time. >> >> Split your series up into logical, and more reasonably sized chunks. >> >> I'd say 14 or 15 at a time is the limit. >> >> I'm not even looking at this series until you submit it more reasonably. >> >> Thank you. > > Ok. I suggest you review patches 1-7, as these are the generic ones. > Then once they have been applied I can resubmit the subsequent patches > individually. > > Do you want me to resubmit patches 1-7, or do you just want to pick > them from this series as they are? I'll redo the first few patches based on the comments received so far, and resend them in a shorter series, so no need to review the current one. Thanks. Tom -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v7 00/33] Provide netdev naming-policy via sysfs
Thanks for the quick answer. On Thu, Jul 10, 2014 at 10:43 AM, David Miller wrote: > It is not reasonable to expect people to review such a large number of > patches at one time. > > Split your series up into logical, and more reasonably sized chunks. > > I'd say 14 or 15 at a time is the limit. > > I'm not even looking at this series until you submit it more reasonably. > > Thank you. Ok. I suggest you review patches 1-7, as these are the generic ones. Then once they have been applied I can resubmit the subsequent patches individually. Do you want me to resubmit patches 1-7, or do you just want to pick them from this series as they are? Cheers, Tom -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v7 00/33] Provide netdev naming-policy via sysfs
It is not reasonable to expect people to review such a large number of patches at one time. Split your series up into logical, and more reasonably sized chunks. I'd say 14 or 15 at a time is the limit. I'm not even looking at this series until you submit it more reasonably. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v7 00/33] Provide netdev naming-policy via sysfs
This picks up the patch series where David Herrmann left off, incorporating the feedback from David Miller. Overview (see Patch 1 for more details): Patch 1: Introduce the enums, documentation and userspace API Patch 2: Hook up with device renaming Patch 3: change the alloc_netdev*() API to take the name_assign_type The following patches actually converts to the correct name assign type, these can be applied in any order, and we could even delay some/all to a subsequent release if that makes things simpler. Patch 4-6: convert the trivial cases. Patch 7-9: convert the netlink interfaces to pass down the assign type Patch 10-33: convert the remaining drivers one-by-one Cheers, Tom Changes since v6: - change alloc_netdev to take the name assign type as an argument. - introduce an internal assign type NET_NAME_UNKNOWN, which makes it simpler to split up the patches, but may eventually be dropped. - introduce a new assign type NET_NAME_PREDICTABLE to indicate to userspace that the kernel-assigned names are well-behaved. Tom Gundersen (33): net: add name_assign_type netdev attribute net: set name assign type for renamed devices net: set name_assign_type in alloc_netdev() net: set name assign type for names assigned using a static template net: set name assign type for names assigned using a static string net: set name assign type for names passed directly from userspace net: rtnetlink - make create_link take name_assign_type net: nl80211 - make rdev_add_virtual_intf take name_assign_type net: nl802154 - make add_iface take name assign type net: dummy - set name assign type net: af_netrom - set name assign type net: af_rose - set name assign type net: mrt - set name assign type net: caif_serial - set name assign type net: xen-netback - set name assign type net: gdm_lte - set name assign type net: airo - set name assign type net: arcdev - label alloc_arcdev names net: isdn - set name assign type net: irlan - set name assign type net: batman-adv - set name assign type net: hamradio - set name assign type net: openvswitch - set name assign type net: vlan - set name assign type net: infiniband - steal ifname label net: ipoib - set name assign type net: tile - set name assign type net: dsa - set name assign type net: brcmfmac - set name assign type net: ppp - set name assign type net: slcan - set name assign type net: x25_asy - set name assign type net: slip - set name assign type Documentation/ABI/testing/sysfs-class-net| 11 +++ drivers/firewire/net.c | 3 ++- drivers/hsi/clients/ssi_protocol.c | 3 ++- drivers/infiniband/hw/amso1100/c2_provider.c | 2 +- drivers/infiniband/ulp/ipoib/ipoib.h | 2 +- drivers/infiniband/ulp/ipoib/ipoib_main.c| 10 ++ drivers/infiniband/ulp/ipoib/ipoib_vlan.c| 2 +- drivers/isdn/i4l/isdn_common.c | 4 ++-- drivers/isdn/i4l/isdn_net.c | 9 + drivers/isdn/i4l/isdn_net.h | 4 ++-- drivers/media/dvb-core/dvb_net.c | 3 ++- drivers/misc/sgi-xp/xpnet.c | 3 ++- drivers/net/arcnet/arc-rimi.c| 2 +- drivers/net/arcnet/arcnet.c | 9 +++-- drivers/net/arcnet/com20020-isa.c| 2 +- drivers/net/arcnet/com20020-pci.c| 2 +- drivers/net/arcnet/com20020_cs.c | 2 +- drivers/net/arcnet/com90io.c | 2 +- drivers/net/arcnet/com90xx.c | 2 +- drivers/net/bonding/bond_main.c | 1 + drivers/net/caif/caif_serial.c | 3 ++- drivers/net/caif/caif_spi.c | 2 +- drivers/net/caif/caif_virtio.c | 2 +- drivers/net/can/dev.c| 2 +- drivers/net/can/slcan.c | 2 +- drivers/net/dummy.c | 2 +- drivers/net/eql.c| 3 ++- drivers/net/ethernet/8390/lib8390.c | 2 +- drivers/net/ethernet/tile/tilegx.c | 9 + drivers/net/ethernet/tile/tilepro.c | 14 -- drivers/net/hamradio/6pack.c | 3 ++- drivers/net/hamradio/baycom_epp.c| 2 +- drivers/net/hamradio/baycom_par.c| 3 ++- drivers/net/hamradio/baycom_ser_fdx.c| 3 ++- drivers/net/hamradio/baycom_ser_hdx.c| 3 ++- drivers/net/hamradio/bpqether.c | 2 +- drivers/net/hamradio/dmascc.c| 5 +++-- drivers/net/hamradio/hdlcdrv.c | 3 ++- drivers/net/hamradio/mkiss.c | 3 ++- drivers/net/hamr
