Re: [PATCH v7 4/5] spi: nxp-fspi: add octal mode flag bit for octal support
On Mon, Jan 28, 2019 at 12:26:31PM +, Mark Brown wrote: > On Tue, Jan 15, 2019 at 10:05:29AM +, Yogesh Narayan Gaur wrote: > > diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c > > index e23ad9ef028e..adc3c0e14f38 100644 > > --- a/drivers/spi/spi-nxp-fspi.c > > +++ b/drivers/spi/spi-nxp-fspi.c > > @@ -952,8 +952,8 @@ static int nxp_fspi_probe(struct platform_device *pdev) > This does not apply against current code, the above file is not present > upstream. Please do not submit patches to out of tree code upstream. So it turns out your other series was adding that driver. Please if you're doing this make sure you call out any interdependencies in either the patch itself or the cover letter, if you're sending separate patch serieses you should expect them to be handled separately. signature.asc Description: PGP signature
Re: [PATCH v7 4/5] spi: nxp-fspi: add octal mode flag bit for octal support
On Tue, Jan 15, 2019 at 10:05:29AM +, Yogesh Narayan Gaur wrote: > diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c > index e23ad9ef028e..adc3c0e14f38 100644 > --- a/drivers/spi/spi-nxp-fspi.c > +++ b/drivers/spi/spi-nxp-fspi.c > @@ -952,8 +952,8 @@ static int nxp_fspi_probe(struct platform_device *pdev) This does not apply against current code, the above file is not present upstream. Please do not submit patches to out of tree code upstream. signature.asc Description: PGP signature
[PATCH v7 4/5] spi: nxp-fspi: add octal mode flag bit for octal support
Add octal mode flags for octal I/O data transfer support. NXP FlexSPI controller supports 8 lines Rx/Tx data transfer. Signed-off-by: Yogesh Narayan Gaur --- drivers/spi/spi-nxp-fspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index e23ad9ef028e..adc3c0e14f38 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -952,8 +952,8 @@ static int nxp_fspi_probe(struct platform_device *pdev) if (!ctlr) return -ENOMEM; - ctlr->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD | - SPI_TX_DUAL | SPI_TX_QUAD; + ctlr->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTAL | + SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTAL; f = spi_controller_get_devdata(ctlr); f->dev = dev; -- 2.17.1
