subject:"\[PATCH v8 3\/5\] arm64\: dts\: lx2160a\: add FlexSPI node property"

RE: [PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property

2019-01-31 Thread Yogesh Narayan Gaur




> -Original Message-
> From: Shawn Guo [mailto:shawn...@kernel.org]
> Sent: Friday, February 1, 2019 8:24 AM
> To: Yogesh Narayan Gaur 
> Cc: linux-...@lists.infradead.org; bbrezil...@kernel.org;
> marek.va...@gmail.com; broo...@kernel.org; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; mark.rutl...@arm.com; r...@kernel.org; linux-
> ker...@vger.kernel.org; frieder.schre...@kontron.de;
> computersforpe...@gmail.com; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property
> 
> On Tue, Jan 15, 2019 at 12:00:26PM +, Yogesh Narayan Gaur wrote:
> > Add fspi node property for LX2160A SoC for FlexSPI driver.
> > Property added for the FlexSPI controller and for the connected slave
> > device for the LX2160ARDB target.
> > This is having two SPI-NOR flash device, mt35xu512aba, connected at
> > CS0 and CS1.
> >
> > Signed-off-by: Yogesh Narayan Gaur 
> > ---
> > Changes for v8:
> > - None
> > Changes for v7:
> > - None
> > Changes for v6:
> > - None
> > Changes for v5:
> > - None
> > Changes for v4:
> > - Incorporated Rob review comments.
> > Changes for v3:
> > - None.
> > Changes for v2:
> > - Incorporated Shawn review comments.
> >
> >  .../boot/dts/freescale/fsl-lx2160a-rdb.dts| 22 +++
> >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 13 +++
> >  2 files changed, 35 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > index 6481e5f20e69..70658946fbbe 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > @@ -50,6 +50,28 @@
> > status = "okay";
> >  };
> >
> > + {
> > +   status = "okay";
> > +
> > +   mt35xu512aba0: flash@0 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   compatible = "spansion,m25p80";
> > +   m25p,fast-read;
> > +   spi-max-frequency = <5000>;
> > +   reg = <0>;
> > +   };
> > +
> > +   mt35xu512aba1: flash@1 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   compatible = "spansion,m25p80";
> > +   m25p,fast-read;
> > +   spi-max-frequency = <5000>;
> > +   reg = <1>;
> > +   };
> > +};
> > +
> >   {
> > status = "okay";
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > index a79f5c1ea56d..e3ff86201f73 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > @@ -762,5 +762,18 @@
> >  ;
> > dma-coherent;
> > };
> > +
> > +   fspi: spi@20c {
> 
> To keep the nodes sorted in unit-address, it should go after i2c@207.
> 
> > +   compatible = "nxp,lx2160a-fspi";
> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +   reg = <0x0 0x20c 0x0 0x1>,
> > +   <0x0 0x2000 0x0 0x1000>;
> 
> I would align the indentation with the above.
> 
> > +   reg-names = "fspi_base", "fspi_mmap";
> > +   interrupts = <0 25 0x4>; /* Level high type */
> 
> interrupts = ; so that we can save the
> comment there.
> 
> I fixed up all these small things and applied the patch.
> 
Ok, Thanks.

--
Regards
Yogesh Gaur.

> Shawn
> 
> > +   clocks = < 4 3>, < 4 3>;
> > +   clock-names = "fspi_en", "fspi";
> > +   status = "disabled";
> > +   };
> > };
> >  };
> > --
> > 2.17.1
> >
> >
> > ___
> > linux-arm-kernel mailing list
> > linux-arm-ker...@lists.infradead.org
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flist
> > s.infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-
> kerneldata=02%7C
> >
> 01%7Cyogeshnarayan.gaur%40nxp.com%7C6308464db1a541247dfd08d687f09
> 124%7
> >
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636845864632818753
> mp;sda
> >
> ta=urGFUKDP6ZZZOTXS1ccfLceCV2OBV5%2BiZq9foCu7ZX8%3Dreserved=
> 0

Re: [PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property

2019-01-31 Thread Shawn Guo

On Tue, Jan 15, 2019 at 12:00:26PM +, Yogesh Narayan Gaur wrote:
> Add fspi node property for LX2160A SoC for FlexSPI driver.
> Property added for the FlexSPI controller and for the connected
> slave device for the LX2160ARDB target.
> This is having two SPI-NOR flash device, mt35xu512aba, connected
> at CS0 and CS1.
> 
> Signed-off-by: Yogesh Narayan Gaur 
> ---
> Changes for v8:
> - None
> Changes for v7:
> - None
> Changes for v6:
> - None
> Changes for v5:
> - None
> Changes for v4:
> - Incorporated Rob review comments.
> Changes for v3:
> - None.
> Changes for v2:
> - Incorporated Shawn review comments.
> 
>  .../boot/dts/freescale/fsl-lx2160a-rdb.dts| 22 +++
>  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 13 +++
>  2 files changed, 35 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> index 6481e5f20e69..70658946fbbe 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> @@ -50,6 +50,28 @@
>   status = "okay";
>  };
>  
> + {
> + status = "okay";
> +
> + mt35xu512aba0: flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "spansion,m25p80";
> + m25p,fast-read;
> + spi-max-frequency = <5000>;
> + reg = <0>;
> + };
> +
> + mt35xu512aba1: flash@1 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "spansion,m25p80";
> + m25p,fast-read;
> + spi-max-frequency = <5000>;
> + reg = <1>;
> + };
> +};
> +
>   {
>   status = "okay";
>  
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi 
> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index a79f5c1ea56d..e3ff86201f73 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -762,5 +762,18 @@
>;
>   dma-coherent;
>   };
> +
> + fspi: spi@20c {

To keep the nodes sorted in unit-address, it should go after
i2c@207.

> + compatible = "nxp,lx2160a-fspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x20c 0x0 0x1>,
> + <0x0 0x2000 0x0 0x1000>;

I would align the indentation with the above.

> + reg-names = "fspi_base", "fspi_mmap";
> + interrupts = <0 25 0x4>; /* Level high type */

interrupts = ; so that we can save the
comment there.

I fixed up all these small things and applied the patch.

Shawn

> + clocks = < 4 3>, < 4 3>;
> + clock-names = "fspi_en", "fspi";
> + status = "disabled";
> + };
>   };
>  };
> -- 
> 2.17.1
> 
> 
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property

2019-01-15 Thread Yogesh Narayan Gaur

Add fspi node property for LX2160A SoC for FlexSPI driver.
Property added for the FlexSPI controller and for the connected
slave device for the LX2160ARDB target.
This is having two SPI-NOR flash device, mt35xu512aba, connected
at CS0 and CS1.

Signed-off-by: Yogesh Narayan Gaur 
---
Changes for v8:
- None
Changes for v7:
- None
Changes for v6:
- None
Changes for v5:
- None
Changes for v4:
- Incorporated Rob review comments.
Changes for v3:
- None.
Changes for v2:
- Incorporated Shawn review comments.

 .../boot/dts/freescale/fsl-lx2160a-rdb.dts| 22 +++
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 13 +++
 2 files changed, 35 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts 
b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
index 6481e5f20e69..70658946fbbe 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
@@ -50,6 +50,28 @@
status = "okay";
 };
 
+ {
+   status = "okay";
+
+   mt35xu512aba0: flash@0 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "spansion,m25p80";
+   m25p,fast-read;
+   spi-max-frequency = <5000>;
+   reg = <0>;
+   };
+
+   mt35xu512aba1: flash@1 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "spansion,m25p80";
+   m25p,fast-read;
+   spi-max-frequency = <5000>;
+   reg = <1>;
+   };
+};
+
  {
status = "okay";
 
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi 
b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index a79f5c1ea56d..e3ff86201f73 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -762,5 +762,18 @@
 ;
dma-coherent;
};
+
+   fspi: spi@20c {
+   compatible = "nxp,lx2160a-fspi";
+   #address-cells = <1>;
+   #size-cells = <0>;
+   reg = <0x0 0x20c 0x0 0x1>,
+   <0x0 0x2000 0x0 0x1000>;
+   reg-names = "fspi_base", "fspi_mmap";
+   interrupts = <0 25 0x4>; /* Level high type */
+   clocks = < 4 3>, < 4 3>;
+   clock-names = "fspi_en", "fspi";
+   status = "disabled";
+   };
};
 };
-- 
2.17.1

RE: [PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property

Re: [PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property

[PATCH v8 3/5] arm64: dts: lx2160a: add FlexSPI node property

3 matches

Site Navigation

Mail list logo

Footer information