Re: [PATCH v9 7/8] clk: qcom: Add WCSSAON reset

2024-06-21 Thread Dmitry Baryshkov 
On Fri, Jun 21, 2024 at 05:16:58PM GMT, Gokul Sriram Palanisamy wrote:
> Add WCSSAON reset required for Q6v5 on IPQ8074 SoC.
> 
> Signed-off-by: Nikhil Prakash V 
> Signed-off-by: Sricharan R 
> Signed-off-by: Gokul Sriram Palanisamy 

Three authors for a single line?

> Acked-by: Stephen Boyd 
> ---
>  drivers/clk/qcom/gcc-ipq8074.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> index 32fd01ef469a..d382d16b9c10 100644
> --- a/drivers/clk/qcom/gcc-ipq8074.c
> +++ b/drivers/clk/qcom/gcc-ipq8074.c
> @@ -4712,6 +4712,7 @@ static const struct qcom_reset_map gcc_ipq8074_resets[] 
> = {
>   [GCC_NSSPORT4_RESET] = { .reg = 0x68014, .bitmask = BIT(27) | 
> GENMASK(9, 8) },
>   [GCC_NSSPORT5_RESET] = { .reg = 0x68014, .bitmask = BIT(28) | 
> GENMASK(11, 10) },
>   [GCC_NSSPORT6_RESET] = { .reg = 0x68014, .bitmask = BIT(29) | 
> GENMASK(13, 12) },
> + [GCC_WCSSAON_RESET] = { 0x59010, 0 },

Do you notice that you line is pretty significantly different from the
previous lines? The time has passed since Stephen has acked this line in
2019.

>  };
>  
>  static struct gdsc *gcc_ipq8074_gdscs[] = {
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

Re: [PATCH v9 7/8] clk: qcom: Add WCSSAON reset

2024-06-21 Thread Kathiravan Thirumoorthy 




On 6/21/2024 5:16 PM, Gokul Sriram Palanisamy wrote:

Add WCSSAON reset required for Q6v5 on IPQ8074 SoC.


Commit title can be written as "clk: qcom: ipq8074: Add WCSSAON reset" ?

With that,

Reviewed-by: Kathiravan Thirumoorthy 



Signed-off-by: Nikhil Prakash V 
Signed-off-by: Sricharan R 
Signed-off-by: Gokul Sriram Palanisamy 
Acked-by: Stephen Boyd 
---
  drivers/clk/qcom/gcc-ipq8074.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
index 32fd01ef469a..d382d16b9c10 100644
--- a/drivers/clk/qcom/gcc-ipq8074.c
+++ b/drivers/clk/qcom/gcc-ipq8074.c
@@ -4712,6 +4712,7 @@ static const struct qcom_reset_map gcc_ipq8074_resets[] = 
{
[GCC_NSSPORT4_RESET] = { .reg = 0x68014, .bitmask = BIT(27) | 
GENMASK(9, 8) },
[GCC_NSSPORT5_RESET] = { .reg = 0x68014, .bitmask = BIT(28) | 
GENMASK(11, 10) },
[GCC_NSSPORT6_RESET] = { .reg = 0x68014, .bitmask = BIT(29) | 
GENMASK(13, 12) },
+   [GCC_WCSSAON_RESET] = { 0x59010, 0 },
  };
  
  static struct gdsc *gcc_ipq8074_gdscs[] = {

[PATCH v9 7/8] clk: qcom: Add WCSSAON reset

2024-06-21 Thread Gokul Sriram Palanisamy 
Add WCSSAON reset required for Q6v5 on IPQ8074 SoC.

Signed-off-by: Nikhil Prakash V 
Signed-off-by: Sricharan R 
Signed-off-by: Gokul Sriram Palanisamy 
Acked-by: Stephen Boyd 
---
 drivers/clk/qcom/gcc-ipq8074.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
index 32fd01ef469a..d382d16b9c10 100644
--- a/drivers/clk/qcom/gcc-ipq8074.c
+++ b/drivers/clk/qcom/gcc-ipq8074.c
@@ -4712,6 +4712,7 @@ static const struct qcom_reset_map gcc_ipq8074_resets[] = 
{
[GCC_NSSPORT4_RESET] = { .reg = 0x68014, .bitmask = BIT(27) | 
GENMASK(9, 8) },
[GCC_NSSPORT5_RESET] = { .reg = 0x68014, .bitmask = BIT(28) | 
GENMASK(11, 10) },
[GCC_NSSPORT6_RESET] = { .reg = 0x68014, .bitmask = BIT(29) | 
GENMASK(13, 12) },
+   [GCC_WCSSAON_RESET] = { 0x59010, 0 },
 };
 
 static struct gdsc *gcc_ipq8074_gdscs[] = {
-- 
2.34.1