Re: [PATCHSET v2] arch: unify task dump debug info
On Wed, Apr 03, 2013 at 12:14:50PM -0700, Tejun Heo wrote: > Andrew, I think it's about ready and nobody seems to be against the > proposed changes. Can you please take these into -mm? > > This v2 of this patchset. Changes from the last posting[1] are, So, I've just tried to apply this patch to my current testing tree, and it fails because I'm not using -mm... That means I can't put these in my nightly testing tree. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET v2] arch: unify task dump debug info
> On Mon, Apr 08, 2013 at 08:31:07AM -0700, Tejun Heo wrote: >> Andrew, ping? > > Ping #2. Workqueue conversion of writeback in the block tree needs > these patches to avoid losing debug information over the conversion, > so it'd be great if this can be scheduled for 3.10. > > Thanks. > > -- > tejun > Sorry for the late reply; wasn't able to test this until today. Hexagon could use the same "don't print into stacktrace machinery", but I can add that to my tree. So for the Hexagon bits: Acked-by: Richard Kuo -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET v2] arch: unify task dump debug info
* Tejun Heo wrote: > On Mon, Apr 08, 2013 at 08:31:07AM -0700, Tejun Heo wrote: > > Andrew, ping? > > Ping #2. Workqueue conversion of writeback in the block tree needs > these patches to avoid losing debug information over the conversion, > so it'd be great if this can be scheduled for 3.10. The x86 bits look good to me, assuming it's tested, etc. Acked-by: Ingo Molnar Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET v2] arch: unify task dump debug info
On Mon, Apr 08, 2013 at 08:31:07AM -0700, Tejun Heo wrote: > Andrew, ping? Ping #2. Workqueue conversion of writeback in the block tree needs these patches to avoid losing debug information over the conversion, so it'd be great if this can be scheduled for 3.10. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET v2] arch: unify task dump debug info
On Wed, Apr 03, 2013 at 12:14:50PM -0700, Tejun Heo wrote: > Andrew, I think it's about ready and nobody seems to be against the > proposed changes. Can you please take these into -mm? Andrew, ping? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCHSET v2] arch: unify task dump debug info
Hello,
Andrew, I think it's about ready and nobody seems to be against the
proposed changes. Can you please take these into -mm?
This v2 of this patchset. Changes from the last posting[1] are,
* CPU is now printed for both dump_stack() and show_regs() which s390
folks tell me should be enough to allow converting s390 to use the
generic version.
* s390 converted.
* DMI arch ID now uses the same ID string as the debug "DMI: "
printout during boot as suggested by Bjorn Helgaas.
* arc duplicate removal patch folded in.
* Build breakage on blackfin should be fixed now.
* Rebased on top of -mm.
There are multiple ways a task can be dumped - explicit call to
dump_stack(), triggering WARN() or BUG(), through sysrq-t and so on.
Most of what gets printed is upto each architecture and the current
state is not particularly pretty. Different pieces of information are
presented differently depending on which path the dump takes and which
architecture it's running on. This is messy for no good reason and
makes it exceedingly difficult to add or modify debug information to
task dumps.
In all archs except for s390, there's nothing arch-specific about the
printed debug information. This patchset updates all those archs to
use the same helpers to consistently print out the same debug
information.
An example WARN dump after this patchset.
WARNING: at /work/os/work/kernel/workqueue.c:4841 init_workqueues+0x35/0x505()
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.9.0-rc1-work+ #3
Hardware name: empty empty/S3992, BIOS 080011 10/26/2007
0009 88007c861e08 81c614dc 88007c861e48
8108f500 82228240 0040 8234a08e
88007c861e58
Call Trace:
[] dump_stack+0x19/0x1b
[] warn_slowpath_common+0x70/0xa0
[] warn_slowpath_null+0x1a/0x20
[] init_workqueues+0x35/0x505
...
And BUG dump.
kernel BUG at /work/os/work/kernel/workqueue.c:4841!
invalid opcode: [#1] PREEMPT SMP DEBUG_PAGEALLOC
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.9.0-rc1-work+ #7
Hardware name: empty empty/S3992, BIOS 080011 10/26/2007
task: 88007c85e040 ti: 88007c86 task.ti: 88007c86
RIP: 0010:[] [] init_workqueues+0x4/0x6
RSP: :88007c861ec8 EFLAGS: 00010246
RAX: 88007c861fd8 RBX: 824466a8 RCX: 0001
RDX: 0046 RSI: 0001 RDI: 8234a07a
RBP: 88007c861ec8 R08: R09:
R10: 0001 R11: R12: 8234a07a
R13: R14: R15:
FS: () GS:88007dc0() knlGS:
CS: 0010 DS: ES: CR0: 8005003b
CR2: 88015f7ff000 CR3: 021f1000 CR4: 07f0
DR0: DR1: DR2:
DR3: DR6: 0ff0 DR7: 0400
Stack:
88007c861ef8 81000312 824466a8 88007c85e650
0003 88007c861f38 82335e5d
88007c862080 8223d8c0 88007c862080 81c47760
Call Trace:
[] do_one_initcall+0x122/0x170
[] kernel_init_freeable+0x9b/0x1c8
[] ? rest_init+0x140/0x140
[] kernel_init+0xe/0xf0
[] ret_from_fork+0x7c/0xb0
[] ? rest_init+0x140/0x140
...
This patchset contains the following seven patches.
0001-x86-don-t-show-trace-beyond-show_stack-NULL-NULL.patch
0002-sparc32-make-show_stack-acquire-fp-if-_ksp-is-not-sp.patch
0003-dump_stack-consolidate-dump_stack-implementations-an.patch
0004-dmi-morph-dmi_dump_ids-into-dmi_format_ids-which-for.patch
0005-dump_stack-implement-arch-specific-hardware-descript.patch
0006-dump_stack-unify-debug-information-printed-by-show_r.patch
0007-arc-print-fatal-signals-reduce-duplicated-informatio.patch
0001-0002 update stack dumping functions in x86 and sparc32 in
preparation.
0003 makes all arches except blackfin use generic dump_stack().
blackfin still uses the generic helper to print the same info.
0004-0005 properly abstract DMI identifier printing in WARN() and
show_regs() so that all dumps print out the information. This enables
show_regs() to use the same debug info message.
0006 updates show_regs() of all arches to use a common generic helper
to print debug info.
0007 removes somem duplicate information from arc dumps.
While this patchset changes how debug info is printed on some archs,
the printed information is always superset of what used to be there.
This patchset makes task dump debug messages consistent and enables
adding more information. Workqueue is scheduled to add worker
information including the workqueue in use and work item specific
description.
This patchset is based on top of -mm as of 2013/04/03 and available in
the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/mi
