Re: [PATCH_V2 1/3] dt-bindings: dma: Add binding for jz4780-dma

2015-02-25 Thread Zubair Lutfullah Kakakhel


On 24/02/15 18:08, Zubair Lutfullah Kakakhel wrote:
> From: Alex Smith 
> 
> Add device tree bindings for the DMA controller on JZ4780 SoCs, used by
> the dma-jz4780 driver.
> 
> Signed-off-by: Alex Smith 
> Signed-off-by: Zubair Lutfullah Kakakhel 
> 
> ---
> V1 -> V2 None
> ---
>  .../devicetree/bindings/dma/jz4780-dma.txt | 61 
> ++
>  1 file changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/jz4780-dma.txt
> 
> diff --git a/Documentation/devicetree/bindings/dma/jz4780-dma.txt 
> b/Documentation/devicetree/bindings/dma/jz4780-dma.txt
> new file mode 100644
> index 000..ce90011
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/jz4780-dma.txt
> @@ -0,0 +1,61 @@
> +* Ingenic JZ4780 DMA Controller
> +
> +Required properties:
> +
> +- compatible: Should be "ingenic,jz4780-dma"
> +- reg: Should contain the DMA controller registers location and length.
> +- interrupts: Should contain the interrupt specifier of the DMA controller.
> +- interrupt-parent: Should be the phandle of the interrupt controller that
> +- clocks: Should contain a clock specifier for the JZ4780 PDMA clock.
> +- #dma-cells: Must be <3>. Number of integer cells in the dmas property of
> +  DMA clients (see below).
> +
> +Optional properties:
> +
> +- ingenic,reserved-channels: Bitmask of channels to reserve for devices that
> +  need a specific channel. These channels will only be assigned when 
> explicitly
> +  requested by a client. The primary use for this is channels 0 and 1, which
> +  can be configured to have special behaviour for NAND/BCH when using
> +  programmable firmware.
> +
> +Example:
> +
> +dma: dma@1342 {
> + compatible = "ingenic,jz4780-dma";
> + reg = <0x1342 0x1>;
> +
> + interrupt-parent = <>;
> + interrupts = <10>;
> +
> + clocks = < JZ4780_CLK_PDMA>;
> +
> + #dma-cells = <3>;
> +
> + ingenic,reserved-channels = <0x3>;
> +};
> +
> +DMA clients must use the format described in dma.txt, giving a phandle to the
> +DMA controller plus the following 3 integer cells:
> +
> +1. Transmit request type: The DMA request type for transfers to the device on
> +   the allocated channel, as defined in the SoC documentation. If set to 0,
> +   transfers to the device will not be allowed on the channel.
> +
> +2. Receive request type: The DMA request type for transfers from the device 
> on
> +   the allocated channel, as defined in the SoC documentation. If set to 0,
> +   transfers from the device will not be allowed on the channel.
> +
> +3. Channel: If set to 0x, any available channel will be allocated for
> +   the client. Otherwise, the exact channel specified will be used. The 
> channel
> +   should be reserved on the DMA controller using the 
> ingenic,reserved-channels
> +   property.

Update. 
I'm taking a look at these bindings again and see if Transmit/Receive request 
types 'need' to be separate.
mmc driver is the only one using it like that.

Sorry for the spam.

Regards,
ZubairLK

> +
> +Example:
> +
> +uart0: serial@1003 {
> + ...
> + dmas = < 0x14 0 0x
> +  0 0x15 0x>;
> + dma-names = "tx", "rx";
> + ...
> +};
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH_V2 1/3] dt-bindings: dma: Add binding for jz4780-dma

2015-02-25 Thread Zubair Lutfullah Kakakhel


On 24/02/15 18:08, Zubair Lutfullah Kakakhel wrote:
 From: Alex Smith alex.sm...@imgtec.com
 
 Add device tree bindings for the DMA controller on JZ4780 SoCs, used by
 the dma-jz4780 driver.
 
 Signed-off-by: Alex Smith alex.sm...@imgtec.com
 Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com
 
 ---
 V1 - V2 None
 ---
  .../devicetree/bindings/dma/jz4780-dma.txt | 61 
 ++
  1 file changed, 61 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/dma/jz4780-dma.txt
 
 diff --git a/Documentation/devicetree/bindings/dma/jz4780-dma.txt 
 b/Documentation/devicetree/bindings/dma/jz4780-dma.txt
 new file mode 100644
 index 000..ce90011
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/dma/jz4780-dma.txt
 @@ -0,0 +1,61 @@
 +* Ingenic JZ4780 DMA Controller
 +
 +Required properties:
 +
 +- compatible: Should be ingenic,jz4780-dma
 +- reg: Should contain the DMA controller registers location and length.
 +- interrupts: Should contain the interrupt specifier of the DMA controller.
 +- interrupt-parent: Should be the phandle of the interrupt controller that
 +- clocks: Should contain a clock specifier for the JZ4780 PDMA clock.
 +- #dma-cells: Must be 3. Number of integer cells in the dmas property of
 +  DMA clients (see below).
 +
 +Optional properties:
 +
 +- ingenic,reserved-channels: Bitmask of channels to reserve for devices that
 +  need a specific channel. These channels will only be assigned when 
 explicitly
 +  requested by a client. The primary use for this is channels 0 and 1, which
 +  can be configured to have special behaviour for NAND/BCH when using
 +  programmable firmware.
 +
 +Example:
 +
 +dma: dma@1342 {
 + compatible = ingenic,jz4780-dma;
 + reg = 0x1342 0x1;
 +
 + interrupt-parent = intc;
 + interrupts = 10;
 +
 + clocks = cgu JZ4780_CLK_PDMA;
 +
 + #dma-cells = 3;
 +
 + ingenic,reserved-channels = 0x3;
 +};
 +
 +DMA clients must use the format described in dma.txt, giving a phandle to the
 +DMA controller plus the following 3 integer cells:
 +
 +1. Transmit request type: The DMA request type for transfers to the device on
 +   the allocated channel, as defined in the SoC documentation. If set to 0,
 +   transfers to the device will not be allowed on the channel.
 +
 +2. Receive request type: The DMA request type for transfers from the device 
 on
 +   the allocated channel, as defined in the SoC documentation. If set to 0,
 +   transfers from the device will not be allowed on the channel.
 +
 +3. Channel: If set to 0x, any available channel will be allocated for
 +   the client. Otherwise, the exact channel specified will be used. The 
 channel
 +   should be reserved on the DMA controller using the 
 ingenic,reserved-channels
 +   property.

Update. 
I'm taking a look at these bindings again and see if Transmit/Receive request 
types 'need' to be separate.
mmc driver is the only one using it like that.

Sorry for the spam.

Regards,
ZubairLK

 +
 +Example:
 +
 +uart0: serial@1003 {
 + ...
 + dmas = dma 0x14 0 0x
 + dma 0 0x15 0x;
 + dma-names = tx, rx;
 + ...
 +};
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH_V2 1/3] dt-bindings: dma: Add binding for jz4780-dma

2015-02-24 Thread Zubair Lutfullah Kakakhel
From: Alex Smith 

Add device tree bindings for the DMA controller on JZ4780 SoCs, used by
the dma-jz4780 driver.

Signed-off-by: Alex Smith 
Signed-off-by: Zubair Lutfullah Kakakhel 

---
V1 -> V2 None
---
 .../devicetree/bindings/dma/jz4780-dma.txt | 61 ++
 1 file changed, 61 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/dma/jz4780-dma.txt

diff --git a/Documentation/devicetree/bindings/dma/jz4780-dma.txt 
b/Documentation/devicetree/bindings/dma/jz4780-dma.txt
new file mode 100644
index 000..ce90011
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/jz4780-dma.txt
@@ -0,0 +1,61 @@
+* Ingenic JZ4780 DMA Controller
+
+Required properties:
+
+- compatible: Should be "ingenic,jz4780-dma"
+- reg: Should contain the DMA controller registers location and length.
+- interrupts: Should contain the interrupt specifier of the DMA controller.
+- interrupt-parent: Should be the phandle of the interrupt controller that
+- clocks: Should contain a clock specifier for the JZ4780 PDMA clock.
+- #dma-cells: Must be <3>. Number of integer cells in the dmas property of
+  DMA clients (see below).
+
+Optional properties:
+
+- ingenic,reserved-channels: Bitmask of channels to reserve for devices that
+  need a specific channel. These channels will only be assigned when explicitly
+  requested by a client. The primary use for this is channels 0 and 1, which
+  can be configured to have special behaviour for NAND/BCH when using
+  programmable firmware.
+
+Example:
+
+dma: dma@1342 {
+   compatible = "ingenic,jz4780-dma";
+   reg = <0x1342 0x1>;
+
+   interrupt-parent = <>;
+   interrupts = <10>;
+
+   clocks = < JZ4780_CLK_PDMA>;
+
+   #dma-cells = <3>;
+
+   ingenic,reserved-channels = <0x3>;
+};
+
+DMA clients must use the format described in dma.txt, giving a phandle to the
+DMA controller plus the following 3 integer cells:
+
+1. Transmit request type: The DMA request type for transfers to the device on
+   the allocated channel, as defined in the SoC documentation. If set to 0,
+   transfers to the device will not be allowed on the channel.
+
+2. Receive request type: The DMA request type for transfers from the device on
+   the allocated channel, as defined in the SoC documentation. If set to 0,
+   transfers from the device will not be allowed on the channel.
+
+3. Channel: If set to 0x, any available channel will be allocated for
+   the client. Otherwise, the exact channel specified will be used. The channel
+   should be reserved on the DMA controller using the ingenic,reserved-channels
+   property.
+
+Example:
+
+uart0: serial@1003 {
+   ...
+   dmas = < 0x14 0 0x
+0 0x15 0x>;
+   dma-names = "tx", "rx";
+   ...
+};
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH_V2 1/3] dt-bindings: dma: Add binding for jz4780-dma

2015-02-24 Thread Zubair Lutfullah Kakakhel
From: Alex Smith alex.sm...@imgtec.com

Add device tree bindings for the DMA controller on JZ4780 SoCs, used by
the dma-jz4780 driver.

Signed-off-by: Alex Smith alex.sm...@imgtec.com
Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com

---
V1 - V2 None
---
 .../devicetree/bindings/dma/jz4780-dma.txt | 61 ++
 1 file changed, 61 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/dma/jz4780-dma.txt

diff --git a/Documentation/devicetree/bindings/dma/jz4780-dma.txt 
b/Documentation/devicetree/bindings/dma/jz4780-dma.txt
new file mode 100644
index 000..ce90011
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/jz4780-dma.txt
@@ -0,0 +1,61 @@
+* Ingenic JZ4780 DMA Controller
+
+Required properties:
+
+- compatible: Should be ingenic,jz4780-dma
+- reg: Should contain the DMA controller registers location and length.
+- interrupts: Should contain the interrupt specifier of the DMA controller.
+- interrupt-parent: Should be the phandle of the interrupt controller that
+- clocks: Should contain a clock specifier for the JZ4780 PDMA clock.
+- #dma-cells: Must be 3. Number of integer cells in the dmas property of
+  DMA clients (see below).
+
+Optional properties:
+
+- ingenic,reserved-channels: Bitmask of channels to reserve for devices that
+  need a specific channel. These channels will only be assigned when explicitly
+  requested by a client. The primary use for this is channels 0 and 1, which
+  can be configured to have special behaviour for NAND/BCH when using
+  programmable firmware.
+
+Example:
+
+dma: dma@1342 {
+   compatible = ingenic,jz4780-dma;
+   reg = 0x1342 0x1;
+
+   interrupt-parent = intc;
+   interrupts = 10;
+
+   clocks = cgu JZ4780_CLK_PDMA;
+
+   #dma-cells = 3;
+
+   ingenic,reserved-channels = 0x3;
+};
+
+DMA clients must use the format described in dma.txt, giving a phandle to the
+DMA controller plus the following 3 integer cells:
+
+1. Transmit request type: The DMA request type for transfers to the device on
+   the allocated channel, as defined in the SoC documentation. If set to 0,
+   transfers to the device will not be allowed on the channel.
+
+2. Receive request type: The DMA request type for transfers from the device on
+   the allocated channel, as defined in the SoC documentation. If set to 0,
+   transfers from the device will not be allowed on the channel.
+
+3. Channel: If set to 0x, any available channel will be allocated for
+   the client. Otherwise, the exact channel specified will be used. The channel
+   should be reserved on the DMA controller using the ingenic,reserved-channels
+   property.
+
+Example:
+
+uart0: serial@1003 {
+   ...
+   dmas = dma 0x14 0 0x
+   dma 0 0x15 0x;
+   dma-names = tx, rx;
+   ...
+};
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/