Re: [PATCHv2 1/2] dt-bindings: usb: typec: anx7688: start a binding document
On 11/03/2024 22:22, Pavel Machek wrote: > Hi! > >> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >> but I did best I could. >> >> Signed-off-by: Pavel Machek > > Any more comments here? Automatic system told me I need to replace one > character... Well, I often do not review patches which have build failure so were not compiled. In the terms of bindings `dt_binding_check` is like test compilation of C, so just like no one reviews onbuildable C code, I don't usually look at "unbuildable" bindings. Plus original v2 patch went into some other email thread, because of "References" field, so a bit disappeared from my inbox. Best regards, Krzysztof
Re: [PATCHv2 1/2] dt-bindings: usb: typec: anx7688: start a binding document
Hi! > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > but I did best I could. > > Signed-off-by: Pavel Machek Any more comments here? Automatic system told me I need to replace one character... Best regards, Pavel > --- > > v2: implement review feedback > > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml > b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml > new file mode 100644 > index ..9e887eafb5fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml > @@ -0,0 +1,127 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/analogix,anx7688.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +# Pin names can be deduced from > +# > https://files.pine64.org/doc/PinePhone/PinePhone%20v1.2b%20Released%20Schematic.pdf > + > +title: Analogix ANX7688 Type-C controller > + > +maintainers: > + - Pavel Machek > + > +properties: > + compatible: > +enum: > + - analogix,anx7688 > + > + reg: > +maxItems: 1 > + > + interrupts: > +maxItems: 1 > + > + reset-gpios: > +maxItems: 1 > +description: GPIO controlling RESET_N (B7) pin. > + > + enable-gpios: > +maxItems: 1 > +description: GPIO controlling POWER_EN (D2) pin. > + > + cabledet-gpios: > +maxItems: 1 > +description: GPIO controlling CABLE_DET (C3) pin. > + > + avdd10-supply: > +description: 1.0V power supply going to AVDD10 (A4, ...) pins > + > + dvdd10-supply: > +description: 1.0V power supply going to DVDD10 (D6, ...) pins > + > + avdd18-supply: > +description: 1.8V power supply going to AVDD18 (E3, ...) pins > + > + dvdd18-supply: > +description: 1.8V power supply going to DVDD18 (G4, ...) pins > + > + avdd33-supply: > +description: 3.3V power supply going to AVDD33 (C4, ...) pins > + > + i2c-supply: true > + vconn-supply: true > + hdmi-vt-supply: true > + vbus-supply: true > + vbus-in-supply: true > + > + connector: > +type: object > +$ref: /schemas/connector/usb-connector.yaml > + > +description: > + Properties for usb c connector. > + > +properties: > + compatible: > +const: usb-c-connector > + > +required: > + - compatible > + - reg > + - connector > + > +additionalProperties: false > + > +examples: > + - | > +#include > +#include > + > +i2c { > +#address-cells = <1>; > +#size-cells = <0>; > + > +typec@2c { > +compatible = "analogix,anx7688"; > +reg = <0x2c>; > +interrupts = <8 IRQ_TYPE_EDGE_FALLING>; > +interrupt-parent = <>; > + > +enable-gpios = < 3 10 GPIO_ACTIVE_LOW>; /* PD10 */ > +reset-gpios = < 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */ > +cabledet-gpios = <_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */ > + > +avdd10-supply = <_anx1v0>; > +dvdd10-supply = <_anx1v0>; > +avdd18-supply = <_ldo_io1>; > +dvdd18-supply = <_ldo_io1>; > +avdd33-supply = <_dcdc1>; > +i2c-supply = <_ldo_io0>; > +vconn-supply = <_vconn5v0>; > +hdmi_vt-supply = <_dldo1>; > + > +vbus-supply = <_usb_5v>; > +vbus-in-supply = <_power_supply>; > + > +typec_con: connector { > +compatible = "usb-c-connector"; > +power-role = "dual"; > +data-role = "dual"; > +try-power-role = "source"; > + > +ports { > +#address-cells = <1>; > +#size-cells = <0>; > +port@0 { > +reg = <0>; > +typec_con_ep: endpoint { > +remote-endpoint = <_hs_ep>; > +}; > +}; > +}; > +}; > +}; > +}; > +... > -- People of Russia, stop Putin before his war on Ukraine escalates. signature.asc Description: PGP signature
Re: [PATCHv2 1/2] dt-bindings: usb: typec: anx7688: start a binding document
On Fri, 23 Feb 2024 22:28:42 +0100, Pavel Machek wrote: > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > but I did best I could. > > Signed-off-by: Pavel Machek > > --- > > v2: implement review feedback > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/analogix,anx7688.example.dtb: typec@2c: 'hdmi_vt-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/usb/analogix,anx7688.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ZdkOCqPKqa/u9...@duo.ucw.cz The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
[PATCHv2 1/2] dt-bindings: usb: typec: anx7688: start a binding document
Add binding for anx7688 usb type-c bridge. I don't have a datasheet, but I did best I could. Signed-off-by: Pavel Machek --- v2: implement review feedback diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml new file mode 100644 index ..9e887eafb5fc --- /dev/null +++ b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml @@ -0,0 +1,127 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/analogix,anx7688.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +# Pin names can be deduced from +# https://files.pine64.org/doc/PinePhone/PinePhone%20v1.2b%20Released%20Schematic.pdf + +title: Analogix ANX7688 Type-C controller + +maintainers: + - Pavel Machek + +properties: + compatible: +enum: + - analogix,anx7688 + + reg: +maxItems: 1 + + interrupts: +maxItems: 1 + + reset-gpios: +maxItems: 1 +description: GPIO controlling RESET_N (B7) pin. + + enable-gpios: +maxItems: 1 +description: GPIO controlling POWER_EN (D2) pin. + + cabledet-gpios: +maxItems: 1 +description: GPIO controlling CABLE_DET (C3) pin. + + avdd10-supply: +description: 1.0V power supply going to AVDD10 (A4, ...) pins + + dvdd10-supply: +description: 1.0V power supply going to DVDD10 (D6, ...) pins + + avdd18-supply: +description: 1.8V power supply going to AVDD18 (E3, ...) pins + + dvdd18-supply: +description: 1.8V power supply going to DVDD18 (G4, ...) pins + + avdd33-supply: +description: 3.3V power supply going to AVDD33 (C4, ...) pins + + i2c-supply: true + vconn-supply: true + hdmi-vt-supply: true + vbus-supply: true + vbus-in-supply: true + + connector: +type: object +$ref: /schemas/connector/usb-connector.yaml + +description: + Properties for usb c connector. + +properties: + compatible: +const: usb-c-connector + +required: + - compatible + - reg + - connector + +additionalProperties: false + +examples: + - | +#include +#include + +i2c { +#address-cells = <1>; +#size-cells = <0>; + +typec@2c { +compatible = "analogix,anx7688"; +reg = <0x2c>; +interrupts = <8 IRQ_TYPE_EDGE_FALLING>; +interrupt-parent = <>; + +enable-gpios = < 3 10 GPIO_ACTIVE_LOW>; /* PD10 */ +reset-gpios = < 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */ +cabledet-gpios = <_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */ + +avdd10-supply = <_anx1v0>; +dvdd10-supply = <_anx1v0>; +avdd18-supply = <_ldo_io1>; +dvdd18-supply = <_ldo_io1>; +avdd33-supply = <_dcdc1>; +i2c-supply = <_ldo_io0>; +vconn-supply = <_vconn5v0>; +hdmi_vt-supply = <_dldo1>; + +vbus-supply = <_usb_5v>; +vbus-in-supply = <_power_supply>; + +typec_con: connector { +compatible = "usb-c-connector"; +power-role = "dual"; +data-role = "dual"; +try-power-role = "source"; + +ports { +#address-cells = <1>; +#size-cells = <0>; +port@0 { +reg = <0>; +typec_con_ep: endpoint { +remote-endpoint = <_hs_ep>; +}; +}; +}; +}; +}; +}; +... -- People of Russia, stop Putin before his war on Ukraine escalates. signature.asc Description: PGP signature