Re: [PATCHv3 05/16] hwmon: lm75: expose to thermal fw via DT nodes
On 09/21/2013 05:23 PM, Eduardo Valentin wrote: On 21-09-2013 19:56, Guenter Roeck wrote: On 09/21/2013 04:30 PM, Eduardo Valentin wrote: On 21-09-2013 14:06, Guenter Roeck wrote: On 09/18/2013 09:21 AM, Eduardo Valentin wrote: This patch adds to lm75 temperature sensor the possibility to expose itself as thermal zone device, registered on the thermal framework. The thermal zone is built only if a device tree node describing a thermal zone for this sensor is present inside the lm75 DT node. Otherwise, the driver behavior will be the same. Cc: Jean Delvare Cc: Guenter Roeck Cc: lm-sens...@lm-sensors.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin Acked-by: Guenter Roeck Cool! thanks again for taking the time to review this. I assume this will be sent upstream through the thermal tree ? Yeah, that is the idea, at least for the core part. The hwmon changes I believe goes via hwmon tree, right? Not necessarily, as the hwmon code depends on the core code. In such cases it is quite common that both are sent through the same tree. If this works for you I can queue these changes via the thermal tree. Ok with me. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3 05/16] hwmon: lm75: expose to thermal fw via DT nodes
On 21-09-2013 19:56, Guenter Roeck wrote: > On 09/21/2013 04:30 PM, Eduardo Valentin wrote: >> On 21-09-2013 14:06, Guenter Roeck wrote: >>> On 09/18/2013 09:21 AM, Eduardo Valentin wrote: This patch adds to lm75 temperature sensor the possibility to expose itself as thermal zone device, registered on the thermal framework. The thermal zone is built only if a device tree node describing a thermal zone for this sensor is present inside the lm75 DT node. Otherwise, the driver behavior will be the same. Cc: Jean Delvare Cc: Guenter Roeck Cc: lm-sens...@lm-sensors.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin >>> >>> Acked-by: Guenter Roeck >>> >> >> Cool! thanks again for taking the time to review this. >> >>> I assume this will be sent upstream through the thermal tree ? >> >> Yeah, that is the idea, at least for the core part. The hwmon changes I >> believe goes via hwmon tree, right? >> > > Not necessarily, as the hwmon code depends on the core code. > In such cases it is quite common that both are sent through the same tree. If this works for you I can queue these changes via the thermal tree. > > Guenter > > > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin signature.asc Description: OpenPGP digital signature
Re: [PATCHv3 05/16] hwmon: lm75: expose to thermal fw via DT nodes
On 09/21/2013 04:30 PM, Eduardo Valentin wrote: On 21-09-2013 14:06, Guenter Roeck wrote: On 09/18/2013 09:21 AM, Eduardo Valentin wrote: This patch adds to lm75 temperature sensor the possibility to expose itself as thermal zone device, registered on the thermal framework. The thermal zone is built only if a device tree node describing a thermal zone for this sensor is present inside the lm75 DT node. Otherwise, the driver behavior will be the same. Cc: Jean Delvare Cc: Guenter Roeck Cc: lm-sens...@lm-sensors.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin Acked-by: Guenter Roeck Cool! thanks again for taking the time to review this. I assume this will be sent upstream through the thermal tree ? Yeah, that is the idea, at least for the core part. The hwmon changes I believe goes via hwmon tree, right? Not necessarily, as the hwmon code depends on the core code. In such cases it is quite common that both are sent through the same tree. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHv3 05/16] hwmon: lm75: expose to thermal fw via DT nodes
On 21-09-2013 14:06, Guenter Roeck wrote: > On 09/18/2013 09:21 AM, Eduardo Valentin wrote: >> This patch adds to lm75 temperature sensor the possibility >> to expose itself as thermal zone device, registered on the >> thermal framework. >> >> The thermal zone is built only if a device tree node >> describing a thermal zone for this sensor is present >> inside the lm75 DT node. Otherwise, the driver behavior >> will be the same. >> >> Cc: Jean Delvare >> Cc: Guenter Roeck >> Cc: lm-sens...@lm-sensors.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin > > Acked-by: Guenter Roeck > Cool! thanks again for taking the time to review this. > I assume this will be sent upstream through the thermal tree ? Yeah, that is the idea, at least for the core part. The hwmon changes I believe goes via hwmon tree, right? I still need acks from device tree maintainers before moving forward, though. > > Guenter > > > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin signature.asc Description: OpenPGP digital signature
Re: [PATCHv3 05/16] hwmon: lm75: expose to thermal fw via DT nodes
On 09/18/2013 09:21 AM, Eduardo Valentin wrote: This patch adds to lm75 temperature sensor the possibility to expose itself as thermal zone device, registered on the thermal framework. The thermal zone is built only if a device tree node describing a thermal zone for this sensor is present inside the lm75 DT node. Otherwise, the driver behavior will be the same. Cc: Jean Delvare Cc: Guenter Roeck Cc: lm-sens...@lm-sensors.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin Acked-by: Guenter Roeck I assume this will be sent upstream through the thermal tree ? Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCHv3 05/16] hwmon: lm75: expose to thermal fw via DT nodes
This patch adds to lm75 temperature sensor the possibility
to expose itself as thermal zone device, registered on the
thermal framework.
The thermal zone is built only if a device tree node
describing a thermal zone for this sensor is present
inside the lm75 DT node. Otherwise, the driver behavior
will be the same.
Cc: Jean Delvare
Cc: Guenter Roeck
Cc: lm-sens...@lm-sensors.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Eduardo Valentin
---
drivers/hwmon/lm75.c | 35 ++-
1 file changed, 30 insertions(+), 5 deletions(-)
---
Hi Guenter,
Very minor change, removing comment, as requested.
Eduardo
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index c03b490..1d3600a 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -27,6 +27,8 @@
#include
#include
#include
+#include
+#include
#include "lm75.h"
@@ -70,6 +72,7 @@ static const u8 LM75_REG_TEMP[3] = {
/* Each client has this additional data */
struct lm75_data {
struct device *hwmon_dev;
+ struct thermal_zone_device *tz;
struct mutexupdate_lock;
u8 orig_conf;
u8 resolution; /* In bits, between 9 and 12 */
@@ -90,22 +93,36 @@ static struct lm75_data *lm75_update_device(struct device
*dev);
/*---*/
+static inline long lm75_reg_to_mc(s16 temp, u8 resolution)
+{
+ return ((temp >> (16 - resolution)) * 1000) >> (resolution - 8);
+}
+
/* sysfs attributes for hwmon */
+static int lm75_read_temp(void *dev, long *temp)
+{
+ struct lm75_data *data = lm75_update_device(dev);
+
+ if (IS_ERR(data))
+ return PTR_ERR(data);
+
+ *temp = lm75_reg_to_mc(data->temp[0], data->resolution);
+
+ return 0;
+}
+
static ssize_t show_temp(struct device *dev, struct device_attribute *da,
char *buf)
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
struct lm75_data *data = lm75_update_device(dev);
- long temp;
if (IS_ERR(data))
return PTR_ERR(data);
- temp = ((data->temp[attr->index] >> (16 - data->resolution)) * 1000)
- >> (data->resolution - 8);
-
- return sprintf(buf, "%ld\n", temp);
+ return sprintf(buf, "%ld\n", lm75_reg_to_mc(data->temp[attr->index],
+ data->resolution));
}
static ssize_t set_temp(struct device *dev, struct device_attribute *da,
@@ -271,6 +288,13 @@ lm75_probe(struct i2c_client *client, const struct
i2c_device_id *id)
goto exit_remove;
}
+ data->tz = thermal_zone_of_sensor_register(&client->dev,
+ 0,
+ &client->dev,
+ lm75_read_temp, NULL);
+ if (IS_ERR(data->tz))
+ data->tz = NULL;
+
dev_info(&client->dev, "%s: sensor '%s'\n",
dev_name(data->hwmon_dev), client->name);
@@ -285,6 +309,7 @@ static int lm75_remove(struct i2c_client *client)
{
struct lm75_data *data = i2c_get_clientdata(client);
+ thermal_zone_of_sensor_unregister(&client->dev, data->tz);
hwmon_device_unregister(data->hwmon_dev);
sysfs_remove_group(&client->dev.kobj, &lm75_group);
lm75_write_value(client, LM75_REG_CONF, data->orig_conf);
--
1.8.2.1.342.gfa7285d
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
