RE: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-17 Thread Kukjin Kim
Jonathan Cameron wrote:
> 
> On 27/06/14 05:30, Chanwoo Choi wrote:
> > Changes from v4:
> > - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
> >and remove enum variable of ADC version
> > - Fix wrong name of special clock (sclk_tsadc -> sclk_adc)
> > - Add reviewed message by Naveen Krishna Chatradhi
> > - Add functions for ADC clock control
> >
> > Changes from v3:
> > - Add new 'exynos_adc_ops' structure to improve readability according to
> >   Tomasz Figa comment[1]
> >   [1] https://lkml.org/lkml/2014/4/16/238
> > - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
> > - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file
> >
> > Changes from v2:
> > - Check return value of clock function to deal with error exception
> > - Fix minor coding style to improve readability
> >
> > Changes from v1:
> > - Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC
> > - Add a patch about DT binding documentation
> >
> > Chanwoo Choi (4):
> >iio: adc: exynos_adc: Add exynos_adc_data structure to improve 
> > readability
> >iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 
> > ADC
> >iio: devicetree: Add DT binding documentation for Exynos3250 ADC
> >ARM: dts: Fix wrong compatible string for Exynos3250 ADC
> >
> >   .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
> >   arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
> >   drivers/iio/adc/exynos_adc.c   | 326 
> > +++--
> >   3 files changed, 268 insertions(+), 88 deletions(-)
> >
> I am happy with this series, but given it touches some exynos bindings, I 
> would
> like an ack from Kukjin Kim (or according to MAINTAINERS Ben Dooks) before 
> taking it
> all through IIO.
> 
Hi,

Sorry for late response...

The change looks good to me, so please go ahead with my ack on exynos stuff.

Acked-by: Kukjin Kim 

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-17 Thread Kukjin Kim
Jonathan Cameron wrote:
 
 On 27/06/14 05:30, Chanwoo Choi wrote:
  Changes from v4:
  - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
 and remove enum variable of ADC version
  - Fix wrong name of special clock (sclk_tsadc - sclk_adc)
  - Add reviewed message by Naveen Krishna Chatradhi
  - Add functions for ADC clock control
 
  Changes from v3:
  - Add new 'exynos_adc_ops' structure to improve readability according to
Tomasz Figa comment[1]
[1] https://lkml.org/lkml/2014/4/16/238
  - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
  - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file
 
  Changes from v2:
  - Check return value of clock function to deal with error exception
  - Fix minor coding style to improve readability
 
  Changes from v1:
  - Add new samsung,exynos-adc-v3 compatible to support Exynos3250 ADC
  - Add a patch about DT binding documentation
 
  Chanwoo Choi (4):
 iio: adc: exynos_adc: Add exynos_adc_data structure to improve 
  readability
 iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 
  ADC
 iio: devicetree: Add DT binding documentation for Exynos3250 ADC
 ARM: dts: Fix wrong compatible string for Exynos3250 ADC
 
.../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
drivers/iio/adc/exynos_adc.c   | 326 
  +++--
3 files changed, 268 insertions(+), 88 deletions(-)
 
 I am happy with this series, but given it touches some exynos bindings, I 
 would
 like an ack from Kukjin Kim (or according to MAINTAINERS Ben Dooks) before 
 taking it
 all through IIO.
 
Hi,

Sorry for late response...

The change looks good to me, so please go ahead with my ack on exynos stuff.

Acked-by: Kukjin Kim kgene@samsung.com

Thanks,
Kukjin

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-09 Thread Chanwoo Choi
Dear Kukjin Kim,

This patch modified Exynos3250 dtsi to support ADC with IIO.
Could you please reivew this patchset about exynos3250.dtsi?

Best Regards,
Chanwoo Choi

On 06/30/2014 10:51 AM, Chanwoo Choi wrote:
> Dear Kukjin,
> 
> On 06/29/2014 08:50 PM, Jonathan Cameron wrote:
>> On 27/06/14 05:30, Chanwoo Choi wrote:
>>> Changes from v4:
>>> - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
>>>and remove enum variable of ADC version
>>> - Fix wrong name of special clock (sclk_tsadc -> sclk_adc)
>>> - Add reviewed message by Naveen Krishna Chatradhi
>>> - Add functions for ADC clock control
>>>
>>> Changes from v3:
>>> - Add new 'exynos_adc_ops' structure to improve readability according to
>>>   Tomasz Figa comment[1]
>>>   [1] https://lkml.org/lkml/2014/4/16/238
>>> - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
>>> - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file
>>>
>>> Changes from v2:
>>> - Check return value of clock function to deal with error exception
>>> - Fix minor coding style to improve readability
>>>
>>> Changes from v1:
>>> - Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC
>>> - Add a patch about DT binding documentation
>>>
>>> Chanwoo Choi (4):
>>>iio: adc: exynos_adc: Add exynos_adc_data structure to improve 
>>> readability
>>>iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 
>>> ADC
>>>iio: devicetree: Add DT binding documentation for Exynos3250 ADC
>>>ARM: dts: Fix wrong compatible string for Exynos3250 ADC
>>>
>>>   .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
>>>   arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
>>>   drivers/iio/adc/exynos_adc.c   | 326 
>>> +++--
>>>   3 files changed, 268 insertions(+), 88 deletions(-)
>>>
>> I am happy with this series, but given it touches some exynos bindings, I 
>> would
>> like an ack from Kukjin Kim (or according to MAINTAINERS Ben Dooks) before 
>> taking it
>> all through IIO.
> 
> Could you please review this patchset about exynos dtsi and bindings?
> 
> Best Regards,
> Chanwoo Choi
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-07-09 Thread Chanwoo Choi
Dear Kukjin Kim,

This patch modified Exynos3250 dtsi to support ADC with IIO.
Could you please reivew this patchset about exynos3250.dtsi?

Best Regards,
Chanwoo Choi

On 06/30/2014 10:51 AM, Chanwoo Choi wrote:
 Dear Kukjin,
 
 On 06/29/2014 08:50 PM, Jonathan Cameron wrote:
 On 27/06/14 05:30, Chanwoo Choi wrote:
 Changes from v4:
 - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
and remove enum variable of ADC version
 - Fix wrong name of special clock (sclk_tsadc - sclk_adc)
 - Add reviewed message by Naveen Krishna Chatradhi
 - Add functions for ADC clock control

 Changes from v3:
 - Add new 'exynos_adc_ops' structure to improve readability according to
   Tomasz Figa comment[1]
   [1] https://lkml.org/lkml/2014/4/16/238
 - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
 - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file

 Changes from v2:
 - Check return value of clock function to deal with error exception
 - Fix minor coding style to improve readability

 Changes from v1:
 - Add new samsung,exynos-adc-v3 compatible to support Exynos3250 ADC
 - Add a patch about DT binding documentation

 Chanwoo Choi (4):
iio: adc: exynos_adc: Add exynos_adc_data structure to improve 
 readability
iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 
 ADC
iio: devicetree: Add DT binding documentation for Exynos3250 ADC
ARM: dts: Fix wrong compatible string for Exynos3250 ADC

   .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
   arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
   drivers/iio/adc/exynos_adc.c   | 326 
 +++--
   3 files changed, 268 insertions(+), 88 deletions(-)

 I am happy with this series, but given it touches some exynos bindings, I 
 would
 like an ack from Kukjin Kim (or according to MAINTAINERS Ben Dooks) before 
 taking it
 all through IIO.
 
 Could you please review this patchset about exynos dtsi and bindings?
 
 Best Regards,
 Chanwoo Choi
 
 
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/
 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-29 Thread Chanwoo Choi
Dear Kukjin,

On 06/29/2014 08:50 PM, Jonathan Cameron wrote:
> On 27/06/14 05:30, Chanwoo Choi wrote:
>> Changes from v4:
>> - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
>>and remove enum variable of ADC version
>> - Fix wrong name of special clock (sclk_tsadc -> sclk_adc)
>> - Add reviewed message by Naveen Krishna Chatradhi
>> - Add functions for ADC clock control
>>
>> Changes from v3:
>> - Add new 'exynos_adc_ops' structure to improve readability according to
>>   Tomasz Figa comment[1]
>>   [1] https://lkml.org/lkml/2014/4/16/238
>> - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
>> - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file
>>
>> Changes from v2:
>> - Check return value of clock function to deal with error exception
>> - Fix minor coding style to improve readability
>>
>> Changes from v1:
>> - Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC
>> - Add a patch about DT binding documentation
>>
>> Chanwoo Choi (4):
>>iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
>>iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 
>> ADC
>>iio: devicetree: Add DT binding documentation for Exynos3250 ADC
>>ARM: dts: Fix wrong compatible string for Exynos3250 ADC
>>
>>   .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
>>   arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
>>   drivers/iio/adc/exynos_adc.c   | 326 
>> +++--
>>   3 files changed, 268 insertions(+), 88 deletions(-)
>>
> I am happy with this series, but given it touches some exynos bindings, I 
> would
> like an ack from Kukjin Kim (or according to MAINTAINERS Ben Dooks) before 
> taking it
> all through IIO.

Could you please review this patchset about exynos dtsi and bindings?

Best Regards,
Chanwoo Choi



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-29 Thread Chanwoo Choi
Hi Tomasz,

On 06/27/2014 08:26 PM, Tomasz Figa wrote:
> Hi Chanwoo,
> 
> On 27.06.2014 06:30, Chanwoo Choi wrote:
>> Changes from v4:
>> - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
>>   and remove enum variable of ADC version
>> - Fix wrong name of special clock (sclk_tsadc -> sclk_adc)
>> - Add reviewed message by Naveen Krishna Chatradhi
>> - Add functions for ADC clock control
>>
>> Changes from v3:
>> - Add new 'exynos_adc_ops' structure to improve readability according to
>>  Tomasz Figa comment[1]
>>  [1] https://lkml.org/lkml/2014/4/16/238
>> - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
>> - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file
>>
>> Changes from v2:
>> - Check return value of clock function to deal with error exception
>> - Fix minor coding style to improve readability
>>
>> Changes from v1:
>> - Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC
>> - Add a patch about DT binding documentation
>>
>> Chanwoo Choi (4):
>>   iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
>>   iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 
>> ADC
>>   iio: devicetree: Add DT binding documentation for Exynos3250 ADC
>>   ARM: dts: Fix wrong compatible string for Exynos3250 ADC
>>
>>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
>>  arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
>>  drivers/iio/adc/exynos_adc.c   | 326 
>> +++--
>>  3 files changed, 268 insertions(+), 88 deletions(-)
>>
> 
> For the whole series:
> 
> Reviewed-by: Tomasz Figa 

Thanks for your review.

Best Regards,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-29 Thread Jonathan Cameron

On 27/06/14 05:30, Chanwoo Choi wrote:

Changes from v4:
- Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
   and remove enum variable of ADC version
- Fix wrong name of special clock (sclk_tsadc -> sclk_adc)
- Add reviewed message by Naveen Krishna Chatradhi
- Add functions for ADC clock control

Changes from v3:
- Add new 'exynos_adc_ops' structure to improve readability according to
  Tomasz Figa comment[1]
  [1] https://lkml.org/lkml/2014/4/16/238
- Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
- Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file

Changes from v2:
- Check return value of clock function to deal with error exception
- Fix minor coding style to improve readability

Changes from v1:
- Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC
- Add a patch about DT binding documentation

Chanwoo Choi (4):
   iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
   iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC
   iio: devicetree: Add DT binding documentation for Exynos3250 ADC
   ARM: dts: Fix wrong compatible string for Exynos3250 ADC

  .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
  arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
  drivers/iio/adc/exynos_adc.c   | 326 +++--
  3 files changed, 268 insertions(+), 88 deletions(-)


I am happy with this series, but given it touches some exynos bindings, I would
like an ack from Kukjin Kim (or according to MAINTAINERS Ben Dooks) before 
taking it
all through IIO.

Thanks,

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-29 Thread Jonathan Cameron

On 27/06/14 05:30, Chanwoo Choi wrote:

Changes from v4:
- Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
   and remove enum variable of ADC version
- Fix wrong name of special clock (sclk_tsadc - sclk_adc)
- Add reviewed message by Naveen Krishna Chatradhi
- Add functions for ADC clock control

Changes from v3:
- Add new 'exynos_adc_ops' structure to improve readability according to
  Tomasz Figa comment[1]
  [1] https://lkml.org/lkml/2014/4/16/238
- Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
- Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file

Changes from v2:
- Check return value of clock function to deal with error exception
- Fix minor coding style to improve readability

Changes from v1:
- Add new samsung,exynos-adc-v3 compatible to support Exynos3250 ADC
- Add a patch about DT binding documentation

Chanwoo Choi (4):
   iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
   iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC
   iio: devicetree: Add DT binding documentation for Exynos3250 ADC
   ARM: dts: Fix wrong compatible string for Exynos3250 ADC

  .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
  arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
  drivers/iio/adc/exynos_adc.c   | 326 +++--
  3 files changed, 268 insertions(+), 88 deletions(-)


I am happy with this series, but given it touches some exynos bindings, I would
like an ack from Kukjin Kim (or according to MAINTAINERS Ben Dooks) before 
taking it
all through IIO.

Thanks,

Jonathan
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-29 Thread Chanwoo Choi
Hi Tomasz,

On 06/27/2014 08:26 PM, Tomasz Figa wrote:
 Hi Chanwoo,
 
 On 27.06.2014 06:30, Chanwoo Choi wrote:
 Changes from v4:
 - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
   and remove enum variable of ADC version
 - Fix wrong name of special clock (sclk_tsadc - sclk_adc)
 - Add reviewed message by Naveen Krishna Chatradhi
 - Add functions for ADC clock control

 Changes from v3:
 - Add new 'exynos_adc_ops' structure to improve readability according to
  Tomasz Figa comment[1]
  [1] https://lkml.org/lkml/2014/4/16/238
 - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
 - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file

 Changes from v2:
 - Check return value of clock function to deal with error exception
 - Fix minor coding style to improve readability

 Changes from v1:
 - Add new samsung,exynos-adc-v3 compatible to support Exynos3250 ADC
 - Add a patch about DT binding documentation

 Chanwoo Choi (4):
   iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
   iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 
 ADC
   iio: devicetree: Add DT binding documentation for Exynos3250 ADC
   ARM: dts: Fix wrong compatible string for Exynos3250 ADC

  .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
  arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
  drivers/iio/adc/exynos_adc.c   | 326 
 +++--
  3 files changed, 268 insertions(+), 88 deletions(-)

 
 For the whole series:
 
 Reviewed-by: Tomasz Figa t.f...@samsung.com

Thanks for your review.

Best Regards,
Chanwoo Choi

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-29 Thread Chanwoo Choi
Dear Kukjin,

On 06/29/2014 08:50 PM, Jonathan Cameron wrote:
 On 27/06/14 05:30, Chanwoo Choi wrote:
 Changes from v4:
 - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
and remove enum variable of ADC version
 - Fix wrong name of special clock (sclk_tsadc - sclk_adc)
 - Add reviewed message by Naveen Krishna Chatradhi
 - Add functions for ADC clock control

 Changes from v3:
 - Add new 'exynos_adc_ops' structure to improve readability according to
   Tomasz Figa comment[1]
   [1] https://lkml.org/lkml/2014/4/16/238
 - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
 - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file

 Changes from v2:
 - Check return value of clock function to deal with error exception
 - Fix minor coding style to improve readability

 Changes from v1:
 - Add new samsung,exynos-adc-v3 compatible to support Exynos3250 ADC
 - Add a patch about DT binding documentation

 Chanwoo Choi (4):
iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 
 ADC
iio: devicetree: Add DT binding documentation for Exynos3250 ADC
ARM: dts: Fix wrong compatible string for Exynos3250 ADC

   .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
   arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
   drivers/iio/adc/exynos_adc.c   | 326 
 +++--
   3 files changed, 268 insertions(+), 88 deletions(-)

 I am happy with this series, but given it touches some exynos bindings, I 
 would
 like an ack from Kukjin Kim (or according to MAINTAINERS Ben Dooks) before 
 taking it
 all through IIO.

Could you please review this patchset about exynos dtsi and bindings?

Best Regards,
Chanwoo Choi



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-27 Thread Tomasz Figa
Hi Chanwoo,

On 27.06.2014 06:30, Chanwoo Choi wrote:
> Changes from v4:
> - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
>   and remove enum variable of ADC version
> - Fix wrong name of special clock (sclk_tsadc -> sclk_adc)
> - Add reviewed message by Naveen Krishna Chatradhi
> - Add functions for ADC clock control
> 
> Changes from v3:
> - Add new 'exynos_adc_ops' structure to improve readability according to
>  Tomasz Figa comment[1]
>  [1] https://lkml.org/lkml/2014/4/16/238
> - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
> - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file
> 
> Changes from v2:
> - Check return value of clock function to deal with error exception
> - Fix minor coding style to improve readability
> 
> Changes from v1:
> - Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC
> - Add a patch about DT binding documentation
> 
> Chanwoo Choi (4):
>   iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
>   iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC
>   iio: devicetree: Add DT binding documentation for Exynos3250 ADC
>   ARM: dts: Fix wrong compatible string for Exynos3250 ADC
> 
>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
>  arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
>  drivers/iio/adc/exynos_adc.c   | 326 
> +++--
>  3 files changed, 268 insertions(+), 88 deletions(-)
> 

For the whole series:

Reviewed-by: Tomasz Figa 

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-27 Thread Tomasz Figa
Hi Chanwoo,

On 27.06.2014 06:30, Chanwoo Choi wrote:
 Changes from v4:
 - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
   and remove enum variable of ADC version
 - Fix wrong name of special clock (sclk_tsadc - sclk_adc)
 - Add reviewed message by Naveen Krishna Chatradhi
 - Add functions for ADC clock control
 
 Changes from v3:
 - Add new 'exynos_adc_ops' structure to improve readability according to
  Tomasz Figa comment[1]
  [1] https://lkml.org/lkml/2014/4/16/238
 - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
 - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file
 
 Changes from v2:
 - Check return value of clock function to deal with error exception
 - Fix minor coding style to improve readability
 
 Changes from v1:
 - Add new samsung,exynos-adc-v3 compatible to support Exynos3250 ADC
 - Add a patch about DT binding documentation
 
 Chanwoo Choi (4):
   iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
   iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC
   iio: devicetree: Add DT binding documentation for Exynos3250 ADC
   ARM: dts: Fix wrong compatible string for Exynos3250 ADC
 
  .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
  arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
  drivers/iio/adc/exynos_adc.c   | 326 
 +++--
  3 files changed, 268 insertions(+), 88 deletions(-)
 

For the whole series:

Reviewed-by: Tomasz Figa t.f...@samsung.com

Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-26 Thread Chanwoo Choi
Changes from v4:
- Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
  and remove enum variable of ADC version
- Fix wrong name of special clock (sclk_tsadc -> sclk_adc)
- Add reviewed message by Naveen Krishna Chatradhi
- Add functions for ADC clock control

Changes from v3:
- Add new 'exynos_adc_ops' structure to improve readability according to
 Tomasz Figa comment[1]
 [1] https://lkml.org/lkml/2014/4/16/238
- Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
- Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file

Changes from v2:
- Check return value of clock function to deal with error exception
- Fix minor coding style to improve readability

Changes from v1:
- Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC
- Add a patch about DT binding documentation

Chanwoo Choi (4):
  iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
  iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC
  iio: devicetree: Add DT binding documentation for Exynos3250 ADC
  ARM: dts: Fix wrong compatible string for Exynos3250 ADC

 .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
 arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
 drivers/iio/adc/exynos_adc.c   | 326 +++--
 3 files changed, 268 insertions(+), 88 deletions(-)

-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

2014-06-26 Thread Chanwoo Choi
Changes from v4:
- Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
  and remove enum variable of ADC version
- Fix wrong name of special clock (sclk_tsadc - sclk_adc)
- Add reviewed message by Naveen Krishna Chatradhi
- Add functions for ADC clock control

Changes from v3:
- Add new 'exynos_adc_ops' structure to improve readability according to
 Tomasz Figa comment[1]
 [1] https://lkml.org/lkml/2014/4/16/238
- Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
- Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file

Changes from v2:
- Check return value of clock function to deal with error exception
- Fix minor coding style to improve readability

Changes from v1:
- Add new samsung,exynos-adc-v3 compatible to support Exynos3250 ADC
- Add a patch about DT binding documentation

Chanwoo Choi (4):
  iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
  iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC
  iio: devicetree: Add DT binding documentation for Exynos3250 ADC
  ARM: dts: Fix wrong compatible string for Exynos3250 ADC

 .../devicetree/bindings/arm/samsung/exynos-adc.txt |  26 +-
 arch/arm/boot/dts/exynos3250.dtsi  |   4 +-
 drivers/iio/adc/exynos_adc.c   | 326 +++--
 3 files changed, 268 insertions(+), 88 deletions(-)

-- 
1.8.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/