Re: [PATCHv5 1/6] msi: Relax msi_domain_alloc() to support parentless MSI irqdomains

[Thomas Gleixner]

On Fri, 13 Nov 2015, Keith Busch wrote:

> From: Liu Jiang 
> 
> Previously msi_domain_alloc() assumes MSI irqdomains always have parent
> irqdomains, but that's not true for the new Intel VMD devices. So relax
> msi_domain_alloc() to support parentless MSI irqdomains.
> 
> Signed-off-by: Jiang Liu 
> Tested-by: Keith Busch 

Just for the record. This still misses your S-O-B as you are conveying
the patch

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCHv5 1/6] msi: Relax msi_domain_alloc() to support parentless MSI irqdomains

[Keith Busch]

From: Liu Jiang 

Previously msi_domain_alloc() assumes MSI irqdomains always have parent
irqdomains, but that's not true for the new Intel VMD devices. So relax
msi_domain_alloc() to support parentless MSI irqdomains.

Signed-off-by: Jiang Liu 
Tested-by: Keith Busch 
---
 kernel/irq/msi.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 6b0c0b7..5e15cb4 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -109,9 +109,11 @@ static int msi_domain_alloc(struct irq_domain *domain, 
unsigned int virq,
if (irq_find_mapping(domain, hwirq) > 0)
return -EEXIST;
 
-   ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, arg);
-   if (ret < 0)
-   return ret;
+   if (domain->parent) {
+   ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, arg);
+   if (ret < 0)
+   return ret;
+   }
 
for (i = 0; i < nr_irqs; i++) {
ret = ops->msi_init(domain, info, virq + i, hwirq + i, arg);
-- 
2.6.2.307.g37023ba

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCHv5 1/6] msi: Relax msi_domain_alloc() to support parentless MSI irqdomains

[Keith Busch]

From: Liu Jiang 

Previously msi_domain_alloc() assumes MSI irqdomains always have parent
irqdomains, but that's not true for the new Intel VMD devices. So relax
msi_domain_alloc() to support parentless MSI irqdomains.

Signed-off-by: Jiang Liu 
Tested-by: Keith Busch 
---
 kernel/irq/msi.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 6b0c0b7..5e15cb4 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -109,9 +109,11 @@ static int msi_domain_alloc(struct irq_domain *domain, 
unsigned int virq,
if (irq_find_mapping(domain, hwirq) > 0)
return -EEXIST;
 
-   ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, arg);
-   if (ret < 0)
-   return ret;
+   if (domain->parent) {
+   ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, arg);
+   if (ret < 0)
+   return ret;
+   }
 
for (i = 0; i < nr_irqs; i++) {
ret = ops->msi_init(domain, info, virq + i, hwirq + i, arg);
-- 
2.6.2.307.g37023ba

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCHv5 1/6] msi: Relax msi_domain_alloc() to support parentless MSI irqdomains

[Thomas Gleixner]

On Fri, 13 Nov 2015, Keith Busch wrote:

> From: Liu Jiang 
> 
> Previously msi_domain_alloc() assumes MSI irqdomains always have parent
> irqdomains, but that's not true for the new Intel VMD devices. So relax
> msi_domain_alloc() to support parentless MSI irqdomains.
> 
> Signed-off-by: Jiang Liu 
> Tested-by: Keith Busch 

Just for the record. This still misses your S-O-B as you are conveying
the patch

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/