Re: [PATCHv7 6/6] coresight: cpu-debug: Add support for Qualcomm Kryo
On 01/02/2019 00:53, Sai Prakash Ranjan wrote: Add support for coresight CPU debug module on Qualcomm Kryo CPUs. This patch adds the UCI entries for Kryo CPUs found on MSM8996 which shares the same PIDs as ETMs. Without this, below error is observed on MSM8996: [5.429867] OF: graph: no port node found in /soc/debug@381 [5.429938] coresight-etm4x: probe of 381.debug failed with error -22 [5.435415] coresight-cpu-debug 381.debug: Coresight debug-CPU0 initialized [5.446474] OF: graph: no port node found in /soc/debug@391 [5.448927] coresight-etm4x: probe of 391.debug failed with error -22 [5.454681] coresight-cpu-debug 391.debug: Coresight debug-CPU1 initialized [5.487765] OF: graph: no port node found in /soc/debug@3a1 [5.488007] coresight-etm4x: probe of 3a1.debug failed with error -22 [5.493024] coresight-cpu-debug 3a1.debug: Coresight debug-CPU2 initialized [5.501802] OF: graph: no port node found in /soc/debug@3b1 [5.512901] coresight-etm4x: probe of 3b1.debug failed with error -22 [5.513192] coresight-cpu-debug 3b1.debug: Coresight debug-CPU3 initialized Signed-off-by: Sai Prakash Ranjan Reviewed-by: Suzuki K Poulose
Re: [PATCHv7 6/6] coresight: cpu-debug: Add support for Qualcomm Kryo
On 2/8/2019 1:58 AM, Mathieu Poirier wrote: On Thu, 31 Jan 2019 at 17:55, Sai Prakash Ranjan wrote: Add support for coresight CPU debug module on Qualcomm Kryo CPUs. This patch adds the UCI entries for Kryo CPUs found on MSM8996 which shares the same PIDs as ETMs. [..] I have reviewed your work and things look good to me. Once again there isn't much I can do with it right now. Please re-submit when Mike's set has been merged. Sure, thanks. -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCHv7 6/6] coresight: cpu-debug: Add support for Qualcomm Kryo
On Thu, 31 Jan 2019 at 17:55, Sai Prakash Ranjan
wrote:
>
> Add support for coresight CPU debug module on Qualcomm
> Kryo CPUs. This patch adds the UCI entries for Kryo CPUs
> found on MSM8996 which shares the same PIDs as ETMs.
>
> Without this, below error is observed on MSM8996:
>
> [5.429867] OF: graph: no port node found in /soc/debug@381
> [5.429938] coresight-etm4x: probe of 381.debug failed with error -22
> [5.435415] coresight-cpu-debug 381.debug: Coresight debug-CPU0
> initialized
> [5.446474] OF: graph: no port node found in /soc/debug@391
> [5.448927] coresight-etm4x: probe of 391.debug failed with error -22
> [5.454681] coresight-cpu-debug 391.debug: Coresight debug-CPU1
> initialized
> [5.487765] OF: graph: no port node found in /soc/debug@3a1
> [5.488007] coresight-etm4x: probe of 3a1.debug failed with error -22
> [5.493024] coresight-cpu-debug 3a1.debug: Coresight debug-CPU2
> initialized
> [5.501802] OF: graph: no port node found in /soc/debug@3b1
> [5.512901] coresight-etm4x: probe of 3b1.debug failed with error -22
> [5.513192] coresight-cpu-debug 3b1.debug: Coresight debug-CPU3
> initialized
>
> Signed-off-by: Sai Prakash Ranjan
>
> ---
> For testing, all dependent patches are in below tree:
> * https://github.com/saiprakash-ranjan/linux/tree/coresight-next
>
> This patch depends on UCI support by Mike Leach in below link:
> * https://lore.kernel.org/lkml/20190130234051.2294-1-mike.le...@linaro.org/
> ---
> .../hwtracing/coresight/coresight-cpu-debug.c | 33 +--
> 1 file changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> index e8819d750938..50ebf5b7fa4f 100644
> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> @@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
> return 0;
> }
>
> +static const struct amba_cs_uci_id uci_id_debug[] = {
> + {
> + /* CPU Debug UCI data */
> + .devarch= 0x47706a15,
> + .devarch_mask = 0xfff0,
> + .devtype= 0x0015,
> + }
> +};
> +
Thank you for adding that.
> static const struct amba_id debug_ids[] = {
> - { /* Debug for Cortex-A53 */
> - .id = 0x000bbd03,
> - .mask = 0x000f,
> - },
> - { /* Debug for Cortex-A57 */
> - .id = 0x000bbd07,
> - .mask = 0x000f,
> - },
> - { /* Debug for Cortex-A72 */
> - .id = 0x000bbd08,
> - .mask = 0x000f,
> - },
> - { /* Debug for Cortex-A73 */
> - .id = 0x000bbd09,
> - .mask = 0x000f,
> - },
> - { 0, 0 },
> + CS_AMBA_ID(0x000bbd03), /* Cortex-A53 */
> + CS_AMBA_ID(0x000bbd07), /* Cortex-A57 */
> + CS_AMBA_ID(0x000bbd08), /* Cortex-A72 */
> + CS_AMBA_ID(0x000bbd09), /* Cortex-A73 */
> + CS_AMBA_UCI_ID(0x000f0205, uci_id_debug), /* Qualcomm Kryo */
> + CS_AMBA_UCI_ID(0x000f0211, uci_id_debug), /* Qualcomm Kryo */
> + {},
I have reviewed your work and things look good to me. Once again
there isn't much I can do with it right now. Please re-submit when
Mike's set has been merged.
Mathieu
> };
>
> static struct amba_driver debug_driver = {
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
[PATCHv7 6/6] coresight: cpu-debug: Add support for Qualcomm Kryo
Add support for coresight CPU debug module on Qualcomm
Kryo CPUs. This patch adds the UCI entries for Kryo CPUs
found on MSM8996 which shares the same PIDs as ETMs.
Without this, below error is observed on MSM8996:
[5.429867] OF: graph: no port node found in /soc/debug@381
[5.429938] coresight-etm4x: probe of 381.debug failed with error -22
[5.435415] coresight-cpu-debug 381.debug: Coresight debug-CPU0
initialized
[5.446474] OF: graph: no port node found in /soc/debug@391
[5.448927] coresight-etm4x: probe of 391.debug failed with error -22
[5.454681] coresight-cpu-debug 391.debug: Coresight debug-CPU1
initialized
[5.487765] OF: graph: no port node found in /soc/debug@3a1
[5.488007] coresight-etm4x: probe of 3a1.debug failed with error -22
[5.493024] coresight-cpu-debug 3a1.debug: Coresight debug-CPU2
initialized
[5.501802] OF: graph: no port node found in /soc/debug@3b1
[5.512901] coresight-etm4x: probe of 3b1.debug failed with error -22
[5.513192] coresight-cpu-debug 3b1.debug: Coresight debug-CPU3
initialized
Signed-off-by: Sai Prakash Ranjan
---
For testing, all dependent patches are in below tree:
* https://github.com/saiprakash-ranjan/linux/tree/coresight-next
This patch depends on UCI support by Mike Leach in below link:
* https://lore.kernel.org/lkml/20190130234051.2294-1-mike.le...@linaro.org/
---
.../hwtracing/coresight/coresight-cpu-debug.c | 33 +--
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c
b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index e8819d750938..50ebf5b7fa4f 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
return 0;
}
+static const struct amba_cs_uci_id uci_id_debug[] = {
+ {
+ /* CPU Debug UCI data */
+ .devarch= 0x47706a15,
+ .devarch_mask = 0xfff0,
+ .devtype= 0x0015,
+ }
+};
+
static const struct amba_id debug_ids[] = {
- { /* Debug for Cortex-A53 */
- .id = 0x000bbd03,
- .mask = 0x000f,
- },
- { /* Debug for Cortex-A57 */
- .id = 0x000bbd07,
- .mask = 0x000f,
- },
- { /* Debug for Cortex-A72 */
- .id = 0x000bbd08,
- .mask = 0x000f,
- },
- { /* Debug for Cortex-A73 */
- .id = 0x000bbd09,
- .mask = 0x000f,
- },
- { 0, 0 },
+ CS_AMBA_ID(0x000bbd03), /* Cortex-A53 */
+ CS_AMBA_ID(0x000bbd07), /* Cortex-A57 */
+ CS_AMBA_ID(0x000bbd08), /* Cortex-A72 */
+ CS_AMBA_ID(0x000bbd09), /* Cortex-A73 */
+ CS_AMBA_UCI_ID(0x000f0205, uci_id_debug), /* Qualcomm Kryo */
+ CS_AMBA_UCI_ID(0x000f0211, uci_id_debug), /* Qualcomm Kryo */
+ {},
};
static struct amba_driver debug_driver = {
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
