> On 5/16/19 10:35 PM, Pankaj Gupta wrote:
> > Can I take it your reviewed/acked-by? or tested-by tag? for the virtio
> > patch :)I don't feel that I have enough expertise to give the reviewed-by
> > tag, but you can
> take my acked-by + tested-by.
>
> Acked-by: Jakub Staron
> Tested-by: Jakub Staron
>
> No kernel panics/stalls encountered during testing this patches (v9) with
> QEMU + xfstests.
Thank you for testing and confirming the results. I will add your tested &
acked-by in v10.
> Some CPU stalls encountered while testing with crosvm instead of QEMU with
> xfstests
> (test generic/464) but no repro for QEMU, so the fault may be on the side of
> crosvm.
yes, looks like crosvm related as we did not see any of this in my and your
testing with Qemu.
>
>
> The dump for the crosvm/xfstests stall:
> [ 2504.175276] rcu: INFO: rcu_sched detected stalls on CPUs/tasks:
> [ 2504.176681] rcu: 0-...!: (1 GPs behind) idle=9b2/1/0x4000
> softirq=1089198/1089202 fqs=0
> [ 2504.178270] rcu: 2-...!: (1 ticks this GP)
> idle=cfe/1/0x4002 softirq=1055108/1055110 fqs=0
> [ 2504.179802] rcu: 3-...!: (1 GPs behind) idle=1d6/1/0x4002
> softirq=1046798/1046802 fqs=0
> [ 2504.181215] rcu: 4-...!: (2 ticks this GP)
> idle=522/1/0x4002 softirq=1249063/1249064 fqs=0
> [ 2504.182625] rcu: 5-...!: (1 GPs behind) idle=6da/1/0x4000
> softirq=1131036/1131047 fqs=0
> [ 2504.183955] (detected by 3, t=0 jiffies, g=1232529, q=1370)
> [ 2504.184762] Sending NMI from CPU 3 to CPUs 0:
> [ 2504.186400] NMI backtrace for cpu 0
> [ 2504.186401] CPU: 0 PID: 6670 Comm: 464 Not tainted 5.1.0+ #1
> [ 2504.186401] Hardware name: ChromiumOS crosvm, BIOS 0
> [ 2504.186402] RIP: 0010:queued_spin_lock_slowpath+0x1c/0x1e0
> [ 2504.186402] Code: e7 89 c8 f0 44 0f b1 07 39 c1 75 dc f3 c3 0f 1f 44 00 00
> ba 01 00 00 00 8b 07 85 c0 75 0a f0 0f b1 17 85 c0 75 f2 f3 c3 f3 90 ec
> 81 fe 00 01 00 00 0f 84 ab 00 00 00 81 e6 00 ff ff ff 75 44
> [ 2504.186403] RSP: 0018:c9003ee8 EFLAGS: 0002
> [ 2504.186404] RAX: 0001 RBX: 0246 RCX:
> 00404044
> [ 2504.186404] RDX: 0001 RSI: 0001 RDI:
> 8244a280
> [ 2504.186405] RBP: 8244a280 R08: 000f4200 R09:
> 024709ed6c32
> [ 2504.186405] R10: R11: 0001 R12:
> 8244a280
> [ 2504.186405] R13: 0009 R14: 0009 R15:
>
> [ 2504.186406] FS: () GS:8880cc60()
> knlGS:
> [ 2504.186406] CS: 0010 DS: ES: CR0: 80050033
> [ 2504.186406] CR2: 7efd6b0f15d8 CR3: 0260a006 CR4:
> 00360ef0
> [ 2504.186407] DR0: DR1: DR2:
>
> [ 2504.186407] DR3: DR6: fffe0ff0 DR7:
> 0400
> [ 2504.186407] Call Trace:
> [ 2504.186408]
> [ 2504.186408] _raw_spin_lock_irqsave+0x1d/0x30
> [ 2504.186408] rcu_core+0x3b6/0x740
> [ 2504.186408] ? __hrtimer_run_queues+0x133/0x280
> [ 2504.186409] ? recalibrate_cpu_khz+0x10/0x10
> [ 2504.186409] __do_softirq+0xd8/0x2e4
> [ 2504.186409] irq_exit+0xa3/0xb0
> [ 2504.186410] smp_apic_timer_interrupt+0x67/0x120
> [ 2504.186410] apic_timer_interrupt+0xf/0x20
> [ 2504.186410]
> [ 2504.186410] RIP: 0010:unmap_page_range+0x47a/0x9b0
> [ 2504.186411] Code: 0f 46 46 10 49 39 6e 18 49 89 46 10 48 89 e8 49 0f 43 46
> 18 41 80 4e 20 08 4d 85 c9 49 89 46 18 0f 84 68 ff ff ff 49 8b 51 08 <48> 8d
> 42 ff 83 e2 01 49 0f 44 c1 f6 40 18 01 75 38 48 ba ff 0f 00
> [ 2504.186411] RSP: 0018:c900036cbcc8 EFLAGS: 0282 ORIG_RAX:
> ff13
> [ 2504.186412] RAX: RBX: 80003751d045 RCX:
> 0001
> [ 2504.186413] RDX: ea0002e09288 RSI: 0269b000 RDI:
> 8880b6525e40
> [ 2504.186413] RBP: 0269c000 R08: R09:
> eadd4740
> [ 2504.186413] R10: ea0001755700 R11: 8880cc62d120 R12:
> 02794000
> [ 2504.186414] R13: 0269b000 R14: c900036cbdf0 R15:
> 8880572434d8
> [ 2504.186414] ? unmap_page_range+0x420/0x9b0
> [ 2504.186414] ? release_pages+0x175/0x390
> [ 2504.186414] unmap_vmas+0x7c/0xe0
> [ 2504.186415] exit_mmap+0xa4/0x190
> [ 2504.186415] mmput+0x3b/0x100
> [ 2504.186415] do_exit+0x276/0xc10
> [ 2504.186415] do_group_exit+0x35/0xa0
> [ 2504.186415] __x64_sys_exit_group+0xf/0x10
> [ 2504.186416] do_syscall_64+0x43/0x120
> [ 2504.186416] entry_SYSCALL_64_after_hwframe+0x44/0xa9
> [ 2504.186416] RIP: 0033:0x7efd6ae10618
> [ 2504.186416] Code: Bad RIP value.
> [ 2504.186417] RSP: 002b:7ffcac9bde38 EFLAGS: 0246 ORIG_RAX:
> 00e7
> [ 2504.186417] RAX: ffda RBX: RCX:
> 7efd6ae10618
> [ 2504.186418] RDX: RSI: 003c RDI:
>
> [ 2504.186418] RBP: 7efd6b0ed8e0 R08: 00e7 R09:
>
