Re: [RESEND PATCH 10/10] ide-floppy: replace ntoh{s,l} and hton{s,l} calls with the generic byteorder macros

2008-01-03 Thread Bartlomiej Zolnierkiewicz
On Thursday 03 January 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>

minor thing:

WARNING: line over 80 characters
#88: FILE: drivers/ide/ide-floppy.c:759:
+   put_unaligned(cpu_to_be16(blocks), (unsigned short *) 
&pc->c[7]);

seems like it can be fixed by removing space between '(unsigned short *)'
and '&pc->c[7]'

otherwise looks good, please move it at the beginning of the patch series

PS I need some sleep so the rest of patches have to wait till tomorrow...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[RESEND PATCH 10/10] ide-floppy: replace ntoh{s,l} and hton{s,l} calls with the generic byteorder macros

2008-01-03 Thread Borislav Petkov
Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
---
 drivers/ide/ide-floppy.c |   28 ++--
 1 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 6c29b5f..ddab66c 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -695,8 +695,8 @@ static void idefloppy_create_format_unit_cmd(idefloppy_pc_t 
*pc, int b, int l,
pc->buffer[1] ^= 0x20;  /* ... turn off DCRT bit */
pc->buffer[3] = 8;
 
-   put_unaligned(htonl(b), (unsigned int *)(&pc->buffer[4]));
-   put_unaligned(htonl(l), (unsigned int *)(&pc->buffer[8]));
+   put_unaligned(cpu_to_be32(b), (unsigned int *)(&pc->buffer[4]));
+   put_unaligned(cpu_to_be32(l), (unsigned int *)(&pc->buffer[8]));
pc->buffer_size=12;
set_bit(PC_WRITING, &pc->flags);
 }
@@ -723,7 +723,7 @@ static void idefloppy_create_mode_sense_cmd(idefloppy_pc_t 
*pc, u8 page_code,
printk(KERN_ERR "ide-floppy: unsupported page code "
"in create_mode_sense_cmd\n");
}
-   put_unaligned(htons(length), (u16 *) &pc->c[7]);
+   put_unaligned(cpu_to_be16(length), (u16 *) &pc->c[7]);
pc->request_transfer = length;
 }
 
@@ -753,12 +753,12 @@ static void idefloppy_create_rw_cmd(idefloppy_t *floppy, 
idefloppy_pc_t *pc,
idefloppy_init_pc(pc);
if (idefl_use_rw(floppy)) {
pc->c[0] = cmd == READ ? GPCMD_READ_12 : GPCMD_WRITE_12;
-   put_unaligned(htonl(blocks), (unsigned int *) &pc->c[6]);
+   put_unaligned(cpu_to_be32(blocks), (unsigned int *) &pc->c[6]);
} else {
pc->c[0] = cmd == READ ? GPCMD_READ_10 : GPCMD_WRITE_10;
-   put_unaligned(htons(blocks), (unsigned short *) &pc->c[7]);
+   put_unaligned(cpu_to_be16(blocks), (unsigned short *) 
&pc->c[7]);
}
-   put_unaligned(htonl(block), (unsigned int *) &pc->c[2]);
+   put_unaligned(cpu_to_be32(block), (unsigned int *) &pc->c[2]);
pc->callback = &idefloppy_rw_callback;
pc->rq = rq;
pc->b_count = cmd == READ ? 0 : rq->bio->bi_size;
@@ -890,10 +890,10 @@ static int idefloppy_get_flexible_disk_page(ide_drive_t 
*drive)
set_disk_ro(floppy->disk, floppy->wp);
page = (idefloppy_flex_disk_page_t *) (header + 1);
 
-   page->transfer_rate = ntohs(page->transfer_rate);
-   page->sector_size = ntohs(page->sector_size);
-   page->cyls = ntohs(page->cyls);
-   page->rpm = ntohs(page->rpm);
+   page->transfer_rate = be16_to_cpu(page->transfer_rate);
+   page->sector_size = be16_to_cpu(page->sector_size);
+   page->cyls = be16_to_cpu(page->cyls);
+   page->rpm = be16_to_cpu(page->rpm);
capacity = page->cyls * page->heads * page->sectors * page->sector_size;
 
if (memcmp (page, &floppy->flex_disk_page,
@@ -972,8 +972,8 @@ static int idefloppy_get_capacity(ide_drive_t *drive)
descriptor = (idefloppy_cap_desc_t *) (header + 1);
 
for (i = 0; i < descriptors; i++, descriptor++) {
-   blocks = descriptor->blocks = ntohl(descriptor->blocks);
-   length = descriptor->length = ntohs(descriptor->length);
+   blocks = descriptor->blocks = be32_to_cpu(descriptor->blocks);
+   length = descriptor->length = be16_to_cpu(descriptor->length);
 
if (!i)
{
@@ -1100,8 +1100,8 @@ static int idefloppy_get_format_capacities(ide_drive_t 
*drive, int __user *arg)
if (i == 0)
continue;   /* Skip the first descriptor */
 
-   blocks = ntohl(descriptor->blocks);
-   length = ntohs(descriptor->length);
+   blocks = be32_to_cpu(descriptor->blocks);
+   length = be16_to_cpu(descriptor->length);
 
if (put_user(blocks, argp))
return(-EFAULT);
-- 
1.5.3.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/