From: Bartosz Golaszewski <bgolaszew...@baylibre.com>

This field is unused outside of probe(). There's no need to store it.
We can make it into a local variable.

Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com>
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thomp...@linaro.org>
---
 drivers/video/backlight/gpio_backlight.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/video/backlight/gpio_backlight.c 
b/drivers/video/backlight/gpio_backlight.c
index 70882556f047..cd6a75bca9cc 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -21,7 +21,6 @@
 struct gpio_backlight {
        struct device *fbdev;
        struct gpio_desc *gpiod;
-       int def_value;
 };
 
 static int gpio_backlight_update_status(struct backlight_device *bl)
@@ -61,7 +60,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
        struct backlight_device *bl;
        struct gpio_backlight *gbl;
        enum gpiod_flags flags;
-       int ret;
+       int ret, def_value;
 
        gbl = devm_kzalloc(&pdev->dev, sizeof(*gbl), GFP_KERNEL);
        if (gbl == NULL)
@@ -70,8 +69,8 @@ static int gpio_backlight_probe(struct platform_device *pdev)
        if (pdata)
                gbl->fbdev = pdata->fbdev;
 
-       gbl->def_value = device_property_read_bool(&pdev->dev, "default-on");
-       flags = gbl->def_value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
+       def_value = device_property_read_bool(&pdev->dev, "default-on");
+       flags = def_value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
 
        gbl->gpiod = devm_gpiod_get(&pdev->dev, NULL, flags);
        if (IS_ERR(gbl->gpiod)) {
@@ -94,7 +93,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
                return PTR_ERR(bl);
        }
 
-       bl->props.brightness = gbl->def_value;
+       bl->props.brightness = def_value;
        backlight_update_status(bl);
 
        platform_set_drvdata(pdev, bl);
-- 
2.21.0

Reply via email to