Re: [Nouveau] [RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use
On Mon, Dec 1, 2014 at 8:01 PM, Thierry Reding wrote: > I think the subject doesn't need "for module use" because that's > implicit in exporting a symbol. > > On Fri, Nov 28, 2014 at 07:12:58PM +0800, Vince Hsu wrote: >> Some Tegra drivers might be complied as kernel modules, and > > "compiled" > >> they need the fuse information for initialization. One >> example is the GK20A Nouveau driver. It needs the GPU speedo >> value to calculate frequency-voltage table. So export >> the tegra_sku_info. > > Also please wrap the commit message at around 72 characters. If you make > the lines too short it becomes almost as difficult to readable as if > they're too long. > > Other than these small nitpicks this looks like a reasonable change to > me. > >> >> Signed-off-by: Vince Hsu >> --- >> >> v2: add more description why we need this patch >> >> drivers/soc/tegra/fuse/fuse-tegra.c | 1 + >> 1 file changed, 1 insertion(+) > > Ben, patch 3/3 has a dependency on this one. Would you prefer to merge > this as part of the Nouveau tree or do you want me to provide a stable > branch that you can pull in to resolve the dependency? I'll take the patch, seems the simplest option :) Thanks, Ben. > > In case of the former: > > Acked-by: Thierry Reding > > ___ > Nouveau mailing list > nouv...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/nouveau > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use
I think the subject doesn't need "for module use" because that's implicit in exporting a symbol. On Fri, Nov 28, 2014 at 07:12:58PM +0800, Vince Hsu wrote: > Some Tegra drivers might be complied as kernel modules, and "compiled" > they need the fuse information for initialization. One > example is the GK20A Nouveau driver. It needs the GPU speedo > value to calculate frequency-voltage table. So export > the tegra_sku_info. Also please wrap the commit message at around 72 characters. If you make the lines too short it becomes almost as difficult to readable as if they're too long. Other than these small nitpicks this looks like a reasonable change to me. > > Signed-off-by: Vince Hsu > --- > > v2: add more description why we need this patch > > drivers/soc/tegra/fuse/fuse-tegra.c | 1 + > 1 file changed, 1 insertion(+) Ben, patch 3/3 has a dependency on this one. Would you prefer to merge this as part of the Nouveau tree or do you want me to provide a stable branch that you can pull in to resolve the dependency? In case of the former: Acked-by: Thierry Reding pgp5k4jKpxw8j.pgp Description: PGP signature
Re: [Nouveau] [RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use
On Mon, Dec 1, 2014 at 8:01 PM, Thierry Reding thierry.red...@gmail.com wrote: I think the subject doesn't need for module use because that's implicit in exporting a symbol. On Fri, Nov 28, 2014 at 07:12:58PM +0800, Vince Hsu wrote: Some Tegra drivers might be complied as kernel modules, and compiled they need the fuse information for initialization. One example is the GK20A Nouveau driver. It needs the GPU speedo value to calculate frequency-voltage table. So export the tegra_sku_info. Also please wrap the commit message at around 72 characters. If you make the lines too short it becomes almost as difficult to readable as if they're too long. Other than these small nitpicks this looks like a reasonable change to me. Signed-off-by: Vince Hsu vin...@nvidia.com --- v2: add more description why we need this patch drivers/soc/tegra/fuse/fuse-tegra.c | 1 + 1 file changed, 1 insertion(+) Ben, patch 3/3 has a dependency on this one. Would you prefer to merge this as part of the Nouveau tree or do you want me to provide a stable branch that you can pull in to resolve the dependency? I'll take the patch, seems the simplest option :) Thanks, Ben. In case of the former: Acked-by: Thierry Reding tred...@nvidia.com ___ Nouveau mailing list nouv...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use
I think the subject doesn't need for module use because that's implicit in exporting a symbol. On Fri, Nov 28, 2014 at 07:12:58PM +0800, Vince Hsu wrote: Some Tegra drivers might be complied as kernel modules, and compiled they need the fuse information for initialization. One example is the GK20A Nouveau driver. It needs the GPU speedo value to calculate frequency-voltage table. So export the tegra_sku_info. Also please wrap the commit message at around 72 characters. If you make the lines too short it becomes almost as difficult to readable as if they're too long. Other than these small nitpicks this looks like a reasonable change to me. Signed-off-by: Vince Hsu vin...@nvidia.com --- v2: add more description why we need this patch drivers/soc/tegra/fuse/fuse-tegra.c | 1 + 1 file changed, 1 insertion(+) Ben, patch 3/3 has a dependency on this one. Would you prefer to merge this as part of the Nouveau tree or do you want me to provide a stable branch that you can pull in to resolve the dependency? In case of the former: Acked-by: Thierry Reding tred...@nvidia.com pgp5k4jKpxw8j.pgp Description: PGP signature
Re: [RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use
On Fri, Nov 28, 2014 at 8:12 PM, Vince Hsu wrote: > Some Tegra drivers might be complied as kernel modules, and > they need the fuse information for initialization. One > example is the GK20A Nouveau driver. It needs the GPU speedo > value to calculate frequency-voltage table. So export > the tegra_sku_info. Acked-by: Alexandre Courbot This is required for setting the optimal GPU voltage in Nouveau. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use
Some Tegra drivers might be complied as kernel modules, and
they need the fuse information for initialization. One
example is the GK20A Nouveau driver. It needs the GPU speedo
value to calculate frequency-voltage table. So export
the tegra_sku_info.
Signed-off-by: Vince Hsu
---
v2: add more description why we need this patch
drivers/soc/tegra/fuse/fuse-tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c
b/drivers/soc/tegra/fuse/fuse-tegra.c
index 11a5043959dc..011a3363c265 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra.c
@@ -31,6 +31,7 @@
static u32 (*fuse_readl)(const unsigned int offset);
static int fuse_size;
struct tegra_sku_info tegra_sku_info;
+EXPORT_SYMBOL(tegra_sku_info);
static const char *tegra_revision_name[TEGRA_REVISION_MAX] = {
[TEGRA_REVISION_UNKNOWN] = "unknown",
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use
Some Tegra drivers might be complied as kernel modules, and
they need the fuse information for initialization. One
example is the GK20A Nouveau driver. It needs the GPU speedo
value to calculate frequency-voltage table. So export
the tegra_sku_info.
Signed-off-by: Vince Hsu vin...@nvidia.com
---
v2: add more description why we need this patch
drivers/soc/tegra/fuse/fuse-tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c
b/drivers/soc/tegra/fuse/fuse-tegra.c
index 11a5043959dc..011a3363c265 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra.c
@@ -31,6 +31,7 @@
static u32 (*fuse_readl)(const unsigned int offset);
static int fuse_size;
struct tegra_sku_info tegra_sku_info;
+EXPORT_SYMBOL(tegra_sku_info);
static const char *tegra_revision_name[TEGRA_REVISION_MAX] = {
[TEGRA_REVISION_UNKNOWN] = unknown,
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use
On Fri, Nov 28, 2014 at 8:12 PM, Vince Hsu vin...@nvidia.com wrote: Some Tegra drivers might be complied as kernel modules, and they need the fuse information for initialization. One example is the GK20A Nouveau driver. It needs the GPU speedo value to calculate frequency-voltage table. So export the tegra_sku_info. Acked-by: Alexandre Courbot acour...@nvidia.com This is required for setting the optimal GPU voltage in Nouveau. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
