Re: [RESEND v4 0/6] remoteproc: Add driver for STMicroelectronics platforms
On Mon, Dec 28, 2015 at 8:41 PM, Bjorn Andersson wrote: > I interpreted this as you picked patch 1-4 and didn't pay more > attention to them, but I can't find them in your kernel.org trees. So > I've looked through them again. > > Please apply patch 1, 3 and 4 to your tree Ohad. I was unable to find > a v5 of patch 2, but it's unrelated so no need to wait for a new > version of that. I was under the impression that Lee plans to resubmit once the discussion around patch 2 settles, so I haven't picked the series yet. Lee please let me know - I can take 1/3/4 and wait for the new 2 as well. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND v4 0/6] remoteproc: Add driver for STMicroelectronics platforms
On Thu, Nov 26, 2015 at 1:32 AM, Ohad Ben-Cohen wrote: > On Thu, Nov 26, 2015 at 11:10 AM, Lee Jones wrote: >> On Thu, 26 Nov 2015, Ohad Ben-Cohen wrote: >>> On Tue, Nov 24, 2015 at 3:14 PM, Lee Jones wrote: >>> > ST's platforms often have multiple co-processors (usually ST40s or ST231s) >>> > on-board. This provides the Linux-side infrastructure to flash and boot >>> > them successfully. >>> > >>> > This set has been tested on an STiH410-B2120. >>> >>> It would be nice if you could get at least one Reviewed-by tag coming >>> outside of ST (e.g., Suman or Bjorn who are actively using and >>> improving remoteproc). >> >> If you require reviews by these guys, shouldn't they be Maintainers? > > Additional review isn't a requirement, but it's a plus. > >> Please be aware that >> the DTS(I) changes are applied to this set for your information only >> and are not to be applied through the RemoteProc tree. The usual >> process to which we conform is that Maxime (the STi Maintainer) will >> apply the DT changes *after* the main driver has been applied, in this >> case by you. > > Ok, great, so I will not take patches 5 and 6. > I interpreted this as you picked patch 1-4 and didn't pay more attention to them, but I can't find them in your kernel.org trees. So I've looked through them again. Please apply patch 1, 3 and 4 to your tree Ohad. I was unable to find a v5 of patch 2, but it's unrelated so no need to wait for a new version of that. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND v4 0/6] remoteproc: Add driver for STMicroelectronics platforms
On Thu, Nov 26, 2015 at 11:10 AM, Lee Jones wrote: > On Thu, 26 Nov 2015, Ohad Ben-Cohen wrote: >> On Tue, Nov 24, 2015 at 3:14 PM, Lee Jones wrote: >> > ST's platforms often have multiple co-processors (usually ST40s or ST231s) >> > on-board. This provides the Linux-side infrastructure to flash and boot >> > them successfully. >> > >> > This set has been tested on an STiH410-B2120. >> >> It would be nice if you could get at least one Reviewed-by tag coming >> outside of ST (e.g., Suman or Bjorn who are actively using and >> improving remoteproc). > > If you require reviews by these guys, shouldn't they be Maintainers? Additional review isn't a requirement, but it's a plus. > Please be aware that > the DTS(I) changes are applied to this set for your information only > and are not to be applied through the RemoteProc tree. The usual > process to which we conform is that Maxime (the STi Maintainer) will > apply the DT changes *after* the main driver has been applied, in this > case by you. Ok, great, so I will not take patches 5 and 6. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND v4 0/6] remoteproc: Add driver for STMicroelectronics platforms
On Thu, 26 Nov 2015, Ohad Ben-Cohen wrote: > On Tue, Nov 24, 2015 at 3:14 PM, Lee Jones wrote: > > ST's platforms often have multiple co-processors (usually ST40s or ST231s) > > on-board. This provides the Linux-side infrastructure to flash and boot > > them successfully. > > > > This set has been tested on an STiH410-B2120. > > It would be nice if you could get at least one Reviewed-by tag coming > outside of ST (e.g., Suman or Bjorn who are actively using and > improving remoteproc). If you require reviews by these guys, shouldn't they be Maintainers? > > arch/arm/boot/dts/stih407-family.dtsi | 70 + > > Since this is outside of remoteproc, please have it Acked, preferably > by ARM DT maintainer (Olof?). The bindings have already been Acked by Rob. So long as the DTS(I) files conform to them, there should be no issue. Please be aware that the DTS(I) changes are applied to this set for your information only and are not to be applied through the RemoteProc tree. The usual process to which we conform is that Maxime (the STi Maintainer) will apply the DT changes *after* the main driver has been applied, in this case by you. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND v4 0/6] remoteproc: Add driver for STMicroelectronics platforms
Hi Lee, On Tue, Nov 24, 2015 at 3:14 PM, Lee Jones wrote: > ST's platforms often have multiple co-processors (usually ST40s or ST231s) > on-board. This provides the Linux-side infrastructure to flash and boot > them successfully. > > This set has been tested on an STiH410-B2120. It would be nice if you could get at least one Reviewed-by tag coming outside of ST (e.g., Suman or Bjorn who are actively using and improving remoteproc). > arch/arm/boot/dts/stih407-family.dtsi | 70 + Since this is outside of remoteproc, please have it Acked, preferably by ARM DT maintainer (Olof?). Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[RESEND v4 0/6] remoteproc: Add driver for STMicroelectronics platforms
ST's platforms often have multiple co-processors (usually ST40s or ST231s)
on-board. This provides the Linux-side infrastructure to flash and boot
them successfully.
This set has been tested on an STiH410-B2120.
v3 => v4:
Suggested-by: Suman Anna
- Move to using 'reserved-memory' API
- New 'reserved-memory' nodes
- Remove memory locations from RemoteProc's DT node's reg properties
- Remove C code obtaining/allocating DMA memory
- Re-order .start() and .stop() ops
- Add protection around Reset API in error path
- Explicitly set .has_iommu to false
v2 => v3:
- Generify syscon property (st,syscfg-boot => st,syscfg)
- Rename IP in DT bindings doc (Remote Processor => Co-Processor)
- Remove superfluous 'clock-names' property
- Remove superfluous 'reg-names' property
- Populate MAINTAINERS
- Clean-up DTS formatting
- Use strings in debugfs to control procs ('1|0' => 'start|stop')
- Align copyright statement with MODULE() macros
- Rename driver data structure ('st_rproc' => 'ddata')
- Addition of a full error path in .start()
v1 => v2:
- Remove Linux implementation specific comment from binding document
- Force debugfs '0' to shutdown co-processor - rather than !1
- Supply more detailed commit message
- Propagate errors back from .stop()
- Review GPL wording
- Supply original author's SoBs
Lee Jones (6):
remoteproc: dt: Provide bindings for ST's Remote Processor Controller
driver
remoteproc: debugfs: Add ability to boot remote processor using
debugfs
remoteproc: Supply controller driver for ST's Remote Processors
MAINTAINERS: Add ST's Remote Processor Driver to ARM/STI ARCHITECTURE
ARM: STiH407: Add nodes for RemoteProc
ARM: STiH407: Move over to using the 'reserved-memory' API for
obtaining DMA memory
.../devicetree/bindings/remoteproc/st-rproc.txt| 41 +++
MAINTAINERS| 1 +
arch/arm/boot/dts/stih407-family.dtsi | 70 +
drivers/remoteproc/Kconfig | 9 +
drivers/remoteproc/Makefile| 1 +
drivers/remoteproc/remoteproc_debugfs.c| 34 +++
drivers/remoteproc/st_remoteproc.c | 297 +
7 files changed, 453 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/st-rproc.txt
create mode 100644 drivers/remoteproc/st_remoteproc.c
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
