Re: [RFC 0/3] kdbus: extend selftests

[David Herrmann]

Hi

On Thu, Sep 24, 2015 at 2:07 PM, Paul Osmialowski
 wrote:
> This serie extends kdbus selftests with following new features:
>
> - ability to specify TEST_CREATE_CONN without TEST_CREATE_BUS
> - the 'test-send' test case (by Karol Lewandowski)
> - ability to run kdbus test by executable binary name

Could you please provide a rationale for these? Your commit messages
explain what you do, but they lack a reasoning why all this is needed.
I can guess that you want to apply different sec-labels, thus you need
different binaries, but I'd like to have a proper explanation.

Thanks
David

> Paul Osmialowski (3):
>   kdbus: TEST_CREATE_CONN now does no depend on TEST_CREATE_BUS
>   kdbus: selftests extended
>   kdbus: Ability to run kdbus test by executable binary name
>
>  tools/testing/selftests/kdbus/Makefile   |  1 +
>  tools/testing/selftests/kdbus/kdbus-test.c   | 37 ++-
>  tools/testing/selftests/kdbus/kdbus-test.h   |  1 +
>  tools/testing/selftests/kdbus/kdbus-util.c   | 38 +++
>  tools/testing/selftests/kdbus/kdbus-util.h   |  2 +-
>  tools/testing/selftests/kdbus/test-activator.c   | 20 +++---
>  tools/testing/selftests/kdbus/test-chat.c|  6 +-
>  tools/testing/selftests/kdbus/test-connection.c  |  8 ++-
>  tools/testing/selftests/kdbus/test-fd.c  |  2 +-
>  tools/testing/selftests/kdbus/test-message.c | 69 
>  tools/testing/selftests/kdbus/test-metadata-ns.c | 10 +--
>  tools/testing/selftests/kdbus/test-monitor.c |  9 +--
>  tools/testing/selftests/kdbus/test-policy-ns.c   |  8 +--
>  tools/testing/selftests/kdbus/test-policy-priv.c | 48 --
>  tools/testing/selftests/kdbus/test-send.c| 82 
> 
>  tools/testing/selftests/kdbus/test-sync.c|  2 +-
>  tools/testing/selftests/kdbus/test-timeout.c |  2 +-
>  17 files changed, 253 insertions(+), 92 deletions(-)
>  create mode 100644 tools/testing/selftests/kdbus/test-send.c
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC 0/3] kdbus: extend selftests

[David Herrmann]

Hi

On Thu, Sep 24, 2015 at 2:07 PM, Paul Osmialowski
 wrote:
> This serie extends kdbus selftests with following new features:
>
> - ability to specify TEST_CREATE_CONN without TEST_CREATE_BUS
> - the 'test-send' test case (by Karol Lewandowski)
> - ability to run kdbus test by executable binary name

Could you please provide a rationale for these? Your commit messages
explain what you do, but they lack a reasoning why all this is needed.
I can guess that you want to apply different sec-labels, thus you need
different binaries, but I'd like to have a proper explanation.

Thanks
David

> Paul Osmialowski (3):
>   kdbus: TEST_CREATE_CONN now does no depend on TEST_CREATE_BUS
>   kdbus: selftests extended
>   kdbus: Ability to run kdbus test by executable binary name
>
>  tools/testing/selftests/kdbus/Makefile   |  1 +
>  tools/testing/selftests/kdbus/kdbus-test.c   | 37 ++-
>  tools/testing/selftests/kdbus/kdbus-test.h   |  1 +
>  tools/testing/selftests/kdbus/kdbus-util.c   | 38 +++
>  tools/testing/selftests/kdbus/kdbus-util.h   |  2 +-
>  tools/testing/selftests/kdbus/test-activator.c   | 20 +++---
>  tools/testing/selftests/kdbus/test-chat.c|  6 +-
>  tools/testing/selftests/kdbus/test-connection.c  |  8 ++-
>  tools/testing/selftests/kdbus/test-fd.c  |  2 +-
>  tools/testing/selftests/kdbus/test-message.c | 69 
>  tools/testing/selftests/kdbus/test-metadata-ns.c | 10 +--
>  tools/testing/selftests/kdbus/test-monitor.c |  9 +--
>  tools/testing/selftests/kdbus/test-policy-ns.c   |  8 +--
>  tools/testing/selftests/kdbus/test-policy-priv.c | 48 --
>  tools/testing/selftests/kdbus/test-send.c| 82 
> 
>  tools/testing/selftests/kdbus/test-sync.c|  2 +-
>  tools/testing/selftests/kdbus/test-timeout.c |  2 +-
>  17 files changed, 253 insertions(+), 92 deletions(-)
>  create mode 100644 tools/testing/selftests/kdbus/test-send.c
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[RFC 0/3] kdbus: extend selftests

[Paul Osmialowski]

This serie extends kdbus selftests with following new features:

- ability to specify TEST_CREATE_CONN without TEST_CREATE_BUS
- the 'test-send' test case (by Karol Lewandowski)
- ability to run kdbus test by executable binary name

Paul Osmialowski (3):
  kdbus: TEST_CREATE_CONN now does no depend on TEST_CREATE_BUS
  kdbus: selftests extended
  kdbus: Ability to run kdbus test by executable binary name

 tools/testing/selftests/kdbus/Makefile   |  1 +
 tools/testing/selftests/kdbus/kdbus-test.c   | 37 ++-
 tools/testing/selftests/kdbus/kdbus-test.h   |  1 +
 tools/testing/selftests/kdbus/kdbus-util.c   | 38 +++
 tools/testing/selftests/kdbus/kdbus-util.h   |  2 +-
 tools/testing/selftests/kdbus/test-activator.c   | 20 +++---
 tools/testing/selftests/kdbus/test-chat.c|  6 +-
 tools/testing/selftests/kdbus/test-connection.c  |  8 ++-
 tools/testing/selftests/kdbus/test-fd.c  |  2 +-
 tools/testing/selftests/kdbus/test-message.c | 69 
 tools/testing/selftests/kdbus/test-metadata-ns.c | 10 +--
 tools/testing/selftests/kdbus/test-monitor.c |  9 +--
 tools/testing/selftests/kdbus/test-policy-ns.c   |  8 +--
 tools/testing/selftests/kdbus/test-policy-priv.c | 48 --
 tools/testing/selftests/kdbus/test-send.c| 82 
 tools/testing/selftests/kdbus/test-sync.c|  2 +-
 tools/testing/selftests/kdbus/test-timeout.c |  2 +-
 17 files changed, 253 insertions(+), 92 deletions(-)
 create mode 100644 tools/testing/selftests/kdbus/test-send.c

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[RFC 0/3] kdbus: extend selftests

[Paul Osmialowski]

This serie extends kdbus selftests with following new features:

- ability to specify TEST_CREATE_CONN without TEST_CREATE_BUS
- the 'test-send' test case (by Karol Lewandowski)
- ability to run kdbus test by executable binary name

Paul Osmialowski (3):
  kdbus: TEST_CREATE_CONN now does no depend on TEST_CREATE_BUS
  kdbus: selftests extended
  kdbus: Ability to run kdbus test by executable binary name

 tools/testing/selftests/kdbus/Makefile   |  1 +
 tools/testing/selftests/kdbus/kdbus-test.c   | 37 ++-
 tools/testing/selftests/kdbus/kdbus-test.h   |  1 +
 tools/testing/selftests/kdbus/kdbus-util.c   | 38 +++
 tools/testing/selftests/kdbus/kdbus-util.h   |  2 +-
 tools/testing/selftests/kdbus/test-activator.c   | 20 +++---
 tools/testing/selftests/kdbus/test-chat.c|  6 +-
 tools/testing/selftests/kdbus/test-connection.c  |  8 ++-
 tools/testing/selftests/kdbus/test-fd.c  |  2 +-
 tools/testing/selftests/kdbus/test-message.c | 69 
 tools/testing/selftests/kdbus/test-metadata-ns.c | 10 +--
 tools/testing/selftests/kdbus/test-monitor.c |  9 +--
 tools/testing/selftests/kdbus/test-policy-ns.c   |  8 +--
 tools/testing/selftests/kdbus/test-policy-priv.c | 48 --
 tools/testing/selftests/kdbus/test-send.c| 82 
 tools/testing/selftests/kdbus/test-sync.c|  2 +-
 tools/testing/selftests/kdbus/test-timeout.c |  2 +-
 17 files changed, 253 insertions(+), 92 deletions(-)
 create mode 100644 tools/testing/selftests/kdbus/test-send.c

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/