Re: [RFC 02/11] mm: remove unncessary ret in page_referenced

2017-03-07 Thread Kirill A. Shutemov 
On Thu, Mar 02, 2017 at 03:39:16PM +0900, Minchan Kim wrote:
> Anyone doesn't use ret variable. Remove it.
> 
> Signed-off-by: Minchan Kim 

Acked-by: Kirill A. Shutemov 

-- 
 Kirill A. Shutemov

Re: [RFC 02/11] mm: remove unncessary ret in page_referenced

2017-03-02 Thread Minchan Kim 
On Thu, Mar 02, 2017 at 08:03:16PM +0530, Anshuman Khandual wrote:
> On 03/02/2017 12:09 PM, Minchan Kim wrote:
> > Anyone doesn't use ret variable. Remove it.
> > 
> 
> This change is correct. But not sure how this is related to
> try_to_unmap() clean up though.

In this patchset, I made rmap_walk void function with upcoming
patch so it's a preparation step for it.

> 
> 
> > Signed-off-by: Minchan Kim 
> > ---
> >  mm/rmap.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/mm/rmap.c b/mm/rmap.c
> > index bb45712..8076347 100644
> > --- a/mm/rmap.c
> > +++ b/mm/rmap.c
> > @@ -805,7 +805,6 @@ int page_referenced(struct page *page,
> > struct mem_cgroup *memcg,
> > unsigned long *vm_flags)
> >  {
> > -   int ret;
> > int we_locked = 0;
> > struct page_referenced_arg pra = {
> > .mapcount = total_mapcount(page),
> > @@ -839,7 +838,7 @@ int page_referenced(struct page *page,
> > rwc.invalid_vma = invalid_page_referenced_vma;
> > }
> >  
> > -   ret = rmap_walk(page, &rwc);
> > +   rmap_walk(page, &rwc);
> > *vm_flags = pra.vm_flags;
> >  
> > if (we_locked)
> > 
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majord...@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: mailto:"d...@kvack.org";> em...@kvack.org

Re: [RFC 02/11] mm: remove unncessary ret in page_referenced

2017-03-02 Thread Anshuman Khandual 
On 03/02/2017 12:09 PM, Minchan Kim wrote:
> Anyone doesn't use ret variable. Remove it.
> 

This change is correct. But not sure how this is related to
try_to_unmap() clean up though.


> Signed-off-by: Minchan Kim 
> ---
>  mm/rmap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index bb45712..8076347 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -805,7 +805,6 @@ int page_referenced(struct page *page,
>   struct mem_cgroup *memcg,
>   unsigned long *vm_flags)
>  {
> - int ret;
>   int we_locked = 0;
>   struct page_referenced_arg pra = {
>   .mapcount = total_mapcount(page),
> @@ -839,7 +838,7 @@ int page_referenced(struct page *page,
>   rwc.invalid_vma = invalid_page_referenced_vma;
>   }
>  
> - ret = rmap_walk(page, &rwc);
> + rmap_walk(page, &rwc);
>   *vm_flags = pra.vm_flags;
>  
>   if (we_locked)
>

[RFC 02/11] mm: remove unncessary ret in page_referenced

2017-03-01 Thread Minchan Kim 
Anyone doesn't use ret variable. Remove it.

Signed-off-by: Minchan Kim 
---
 mm/rmap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/rmap.c b/mm/rmap.c
index bb45712..8076347 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -805,7 +805,6 @@ int page_referenced(struct page *page,
struct mem_cgroup *memcg,
unsigned long *vm_flags)
 {
-   int ret;
int we_locked = 0;
struct page_referenced_arg pra = {
.mapcount = total_mapcount(page),
@@ -839,7 +838,7 @@ int page_referenced(struct page *page,
rwc.invalid_vma = invalid_page_referenced_vma;
}
 
-   ret = rmap_walk(page, &rwc);
+   rmap_walk(page, &rwc);
*vm_flags = pra.vm_flags;
 
if (we_locked)
-- 
2.7.4