[RFC 1/3] kdbus: TEST_CREATE_CONN now does no depend on TEST_CREATE_BUS

[Paul Osmialowski]

Without this patch, it is impossible to specify test case able to
connect to a bus already created (e.g. by 'test-daemon' test case), you can
only specify:

1) TEST_CREATE_BUS which creates new bus, or
2) TEST_CREATE_CONN OR'ed with TEST_CREATE_BUS which creates new bus and
creates connection to it.

This patch adds the missing ability to specify TEST_CREATE_CONN alone.

It will be used by a new test case (will be added by separate commit) which
is supposed to connect to already started test-daemon case.

Signed-off-by: Paul Osmialowski 
---
 tools/testing/selftests/kdbus/kdbus-test.c | 21 +
 tools/testing/selftests/kdbus/kdbus-util.c | 18 +++---
 2 files changed, 32 insertions(+), 7 deletions(-)

diff --git a/tools/testing/selftests/kdbus/kdbus-test.c 
b/tools/testing/selftests/kdbus/kdbus-test.c
index db57381..bde4283 100644
--- a/tools/testing/selftests/kdbus/kdbus-test.c
+++ b/tools/testing/selftests/kdbus/kdbus-test.c
@@ -314,6 +314,27 @@ static int test_prepare_env(const struct kdbus_test *t,
}
 
if (t->flags & TEST_CREATE_CONN) {
+   if (!env->buspath) {
+   char *s = NULL;
+   char *n = NULL;
+   int ret;
+
+   if (!args->busname) {
+   n = unique_name("test-bus");
+   ASSERT_RETURN(n);
+   }
+
+   ret = kdbus_create_bus(-1,
+  args->busname ?: n,
+  0,
+  );
+   free(n);
+   ASSERT_RETURN(ret == 0);
+
+   asprintf(>buspath, "%s/%s/bus", args->root, s);
+   free(s);
+   }
+   ASSERT_RETURN(env->buspath);
env->conn = kdbus_hello(env->buspath, 0, NULL, 0);
ASSERT_RETURN(env->conn);
}
diff --git a/tools/testing/selftests/kdbus/kdbus-util.c 
b/tools/testing/selftests/kdbus/kdbus-util.c
index 82fa89b..5129487 100644
--- a/tools/testing/selftests/kdbus/kdbus-util.c
+++ b/tools/testing/selftests/kdbus/kdbus-util.c
@@ -140,7 +140,7 @@ int kdbus_create_bus(int control_fd, const char *name,
char str[64];
} name;
} bus_make;
-   int ret;
+   int ret = 0;
 
memset(_make, 0, sizeof(bus_make));
bus_make.bp.size = sizeof(bus_make.bp);
@@ -165,13 +165,17 @@ int kdbus_create_bus(int control_fd, const char *name,
 bus_make.attach.size +
 bus_make.name.size;
 
-   kdbus_printf("Creating bus with name >%s< on control fd %d ...\n",
-name, control_fd);
+   if (control_fd != -1) {
+   kdbus_printf(
+   "Creating bus with name >%s< on control fd %d ...\n",
+   name, control_fd);
 
-   ret = kdbus_cmd_bus_make(control_fd, _make.cmd);
-   if (ret < 0) {
-   kdbus_printf("--- error when making bus: %d (%m)\n", ret);
-   return ret;
+   ret = kdbus_cmd_bus_make(control_fd, _make.cmd);
+   if (ret < 0) {
+   kdbus_printf("--- error when making bus: %d (%m)\n",
+ret);
+   return ret;
+   }
}
 
if (ret == 0 && path)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[RFC 1/3] kdbus: TEST_CREATE_CONN now does no depend on TEST_CREATE_BUS

[Paul Osmialowski]

Without this patch, it is impossible to specify test case able to
connect to a bus already created (e.g. by 'test-daemon' test case), you can
only specify:

1) TEST_CREATE_BUS which creates new bus, or
2) TEST_CREATE_CONN OR'ed with TEST_CREATE_BUS which creates new bus and
creates connection to it.

This patch adds the missing ability to specify TEST_CREATE_CONN alone.

It will be used by a new test case (will be added by separate commit) which
is supposed to connect to already started test-daemon case.

Signed-off-by: Paul Osmialowski 
---
 tools/testing/selftests/kdbus/kdbus-test.c | 21 +
 tools/testing/selftests/kdbus/kdbus-util.c | 18 +++---
 2 files changed, 32 insertions(+), 7 deletions(-)

diff --git a/tools/testing/selftests/kdbus/kdbus-test.c 
b/tools/testing/selftests/kdbus/kdbus-test.c
index db57381..bde4283 100644
--- a/tools/testing/selftests/kdbus/kdbus-test.c
+++ b/tools/testing/selftests/kdbus/kdbus-test.c
@@ -314,6 +314,27 @@ static int test_prepare_env(const struct kdbus_test *t,
}
 
if (t->flags & TEST_CREATE_CONN) {
+   if (!env->buspath) {
+   char *s = NULL;
+   char *n = NULL;
+   int ret;
+
+   if (!args->busname) {
+   n = unique_name("test-bus");
+   ASSERT_RETURN(n);
+   }
+
+   ret = kdbus_create_bus(-1,
+  args->busname ?: n,
+  0,
+  );
+   free(n);
+   ASSERT_RETURN(ret == 0);
+
+   asprintf(>buspath, "%s/%s/bus", args->root, s);
+   free(s);
+   }
+   ASSERT_RETURN(env->buspath);
env->conn = kdbus_hello(env->buspath, 0, NULL, 0);
ASSERT_RETURN(env->conn);
}
diff --git a/tools/testing/selftests/kdbus/kdbus-util.c 
b/tools/testing/selftests/kdbus/kdbus-util.c
index 82fa89b..5129487 100644
--- a/tools/testing/selftests/kdbus/kdbus-util.c
+++ b/tools/testing/selftests/kdbus/kdbus-util.c
@@ -140,7 +140,7 @@ int kdbus_create_bus(int control_fd, const char *name,
char str[64];
} name;
} bus_make;
-   int ret;
+   int ret = 0;
 
memset(_make, 0, sizeof(bus_make));
bus_make.bp.size = sizeof(bus_make.bp);
@@ -165,13 +165,17 @@ int kdbus_create_bus(int control_fd, const char *name,
 bus_make.attach.size +
 bus_make.name.size;
 
-   kdbus_printf("Creating bus with name >%s< on control fd %d ...\n",
-name, control_fd);
+   if (control_fd != -1) {
+   kdbus_printf(
+   "Creating bus with name >%s< on control fd %d ...\n",
+   name, control_fd);
 
-   ret = kdbus_cmd_bus_make(control_fd, _make.cmd);
-   if (ret < 0) {
-   kdbus_printf("--- error when making bus: %d (%m)\n", ret);
-   return ret;
+   ret = kdbus_cmd_bus_make(control_fd, _make.cmd);
+   if (ret < 0) {
+   kdbus_printf("--- error when making bus: %d (%m)\n",
+ret);
+   return ret;
+   }
}
 
if (ret == 0 && path)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/