RE: [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property has_axieth_connected
Hi Vinod, > -Original Message- > From: Vinod Koul [mailto:vinod.k...@intel.com] > Sent: Wednesday, April 11, 2018 2:35 PM > To: Radhey Shyam Pandey ; Rob Herring > ; devicet...@vger.kernel.org > Cc: dan.j.willi...@intel.com; michal.si...@xilinx.com; Appana Durga > Kedareswara Rao ; Radhey Shyam Pandey > ; l...@metafoo.de; dmaeng...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property > has_axieth_connected > > On Mon, Apr 02, 2018 at 04:09:01PM +0530, Radhey Shyam Pandey wrote: > > Add an optional AXI DMA property 'has_axieth_connected'. This can be > > specified to indicate that AXI DMA is connected to AXI Ethernet in > > hardware design and dma driver needs to do some additional handling. > > 1. why are DT people and list not added to this? I have added that Sorry missed it. I will add in v2. Thanks. > 2. should we have a property for a specific peripheral? Wouldn't it help to > have > a generic property for peripheral connected which can be scaled to more IPs > being connected in future? Good point! I will rename this property to xlnx,axistream-connected and update description. It can then be reused for other usecases as well. > 3. Please use right subsystem name, it damengine: not dma: I will fix. > > > > > Signed-off-by: Radhey Shyam Pandey > > --- > > .../devicetree/bindings/dma/xilinx/xilinx_dma.txt |1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > > index a2b8bfa..5d592e3 100644 > > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > > @@ -42,6 +42,7 @@ Optional properties: > > the hardware. > > Optional properties for AXI DMA: > > - xlnx,mcdma: Tells whether configured for multi-channel mode in the > hardware. > > +- xlnx,axieth-connected: Tells whether AXI DMA is connected to AXI > Ethernet. > > Optional properties for VDMA: > > - xlnx,flush-fsync: Tells which channel to Flush on Frame sync. > > It takes following values: > > -- > > 1.7.1 > > > > -- > ~Vinod
Re: [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property has_axieth_connected
On Mon, Apr 02, 2018 at 04:09:01PM +0530, Radhey Shyam Pandey wrote: > Add an optional AXI DMA property 'has_axieth_connected'. This can be > specified to indicate that AXI DMA is connected to AXI Ethernet in > hardware design and dma driver needs to do some additional handling. 1. why are DT people and list not added to this? I have added that 2. should we have a property for a specific peripheral? Wouldn't it help to have a generic property for peripheral connected which can be scaled to more IPs being connected in future? 3. Please use right subsystem name, it damengine: not dma: > > Signed-off-by: Radhey Shyam Pandey > --- > .../devicetree/bindings/dma/xilinx/xilinx_dma.txt |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > index a2b8bfa..5d592e3 100644 > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt > @@ -42,6 +42,7 @@ Optional properties: > the hardware. > Optional properties for AXI DMA: > - xlnx,mcdma: Tells whether configured for multi-channel mode in the > hardware. > +- xlnx,axieth-connected: Tells whether AXI DMA is connected to AXI Ethernet. > Optional properties for VDMA: > - xlnx,flush-fsync: Tells which channel to Flush on Frame sync. > It takes following values: > -- > 1.7.1 > -- ~Vinod
[RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property has_axieth_connected
Add an optional AXI DMA property 'has_axieth_connected'. This can be specified to indicate that AXI DMA is connected to AXI Ethernet in hardware design and dma driver needs to do some additional handling. Signed-off-by: Radhey Shyam Pandey --- .../devicetree/bindings/dma/xilinx/xilinx_dma.txt |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt index a2b8bfa..5d592e3 100644 --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt @@ -42,6 +42,7 @@ Optional properties: the hardware. Optional properties for AXI DMA: - xlnx,mcdma: Tells whether configured for multi-channel mode in the hardware. +- xlnx,axieth-connected: Tells whether AXI DMA is connected to AXI Ethernet. Optional properties for VDMA: - xlnx,flush-fsync: Tells which channel to Flush on Frame sync. It takes following values: -- 1.7.1
