Re: [RFC PATCH 1/8] rcu: Remove superfluous rdp fetch

[Frederic Weisbecker]

On Sat, Jan 09, 2021 at 10:03:33AM +0100, Greg KH wrote:
> On Sat, Jan 09, 2021 at 03:05:29AM +0100, Frederic Weisbecker wrote:
> > Signed-off-by: Frederic Weisbecker 
> > Cc: Paul E. McKenney 
> > Cc: Rafael J. Wysocki 
> > Cc: Peter Zijlstra 
> > Cc: Thomas Gleixner 
> > Cc: Ingo Molnar
> > ---
> >  kernel/rcu/tree.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> I know I will not take patches without any changelog comments, maybe
> other maintainers are more lax.  Please write something real.

I must admit I've been lazy. Also I shoudn't have Cc'ed stable on
this one. Only a few commits are tagged for stable in this set. I'll
fix that on the next round.

Thanks!

> 
> And as for sending this to stable@vger, here's my form letter:
> 
> 
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> 

Re: [RFC PATCH 1/8] rcu: Remove superfluous rdp fetch

[Greg KH]

On Sat, Jan 09, 2021 at 03:05:29AM +0100, Frederic Weisbecker wrote:
> Signed-off-by: Frederic Weisbecker 
> Cc: Paul E. McKenney 
> Cc: Rafael J. Wysocki 
> Cc: Peter Zijlstra 
> Cc: Thomas Gleixner 
> Cc: Ingo Molnar
> ---
>  kernel/rcu/tree.c | 1 -
>  1 file changed, 1 deletion(-)

I know I will not take patches without any changelog comments, maybe
other maintainers are more lax.  Please write something real.

And as for sending this to stable@vger, here's my form letter:



This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

[RFC PATCH 1/8] rcu: Remove superfluous rdp fetch

[Frederic Weisbecker]

Signed-off-by: Frederic Weisbecker 
Cc: Paul E. McKenney 
Cc: Rafael J. Wysocki 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: Ingo Molnar
---
 kernel/rcu/tree.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 40e5e3dd253e..fef90c467670 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -643,7 +643,6 @@ static noinstr void rcu_eqs_enter(bool user)
instrumentation_begin();
trace_rcu_dyntick(TPS("Start"), rdp->dynticks_nesting, 0, 
atomic_read(>dynticks));
WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && !user && 
!is_idle_task(current));
-   rdp = this_cpu_ptr(_data);
do_nocb_deferred_wakeup(rdp);
rcu_prepare_for_idle();
rcu_preempt_deferred_qs(current);
-- 
2.25.1