Re: [RFC PATCH 13/13] vsock: fix bind() behaviour taking care of CID

2019-10-09 Thread Stefan Hajnoczi
On Fri, Sep 27, 2019 at 01:27:03PM +0200, Stefano Garzarella wrote:
> When we are looking for a socket bound to a specific address,
> we also have to take into account the CID.
> 
> This patch is useful with multi-transports support because it
> allows the binding of the same port with different CID, and
> it prevents a connection to a wrong socket bound to the same
> port, but with different CID.
> 
> Signed-off-by: Stefano Garzarella 
> ---
>  net/vmw_vsock/af_vsock.c | 10 --
>  1 file changed, 8 insertions(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature


[RFC PATCH 13/13] vsock: fix bind() behaviour taking care of CID

2019-09-27 Thread Stefano Garzarella
When we are looking for a socket bound to a specific address,
we also have to take into account the CID.

This patch is useful with multi-transports support because it
allows the binding of the same port with different CID, and
it prevents a connection to a wrong socket bound to the same
port, but with different CID.

Signed-off-by: Stefano Garzarella 
---
 net/vmw_vsock/af_vsock.c | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 750b62711b01..bffa6fa7b8e5 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -230,10 +230,16 @@ static struct sock *__vsock_find_bound_socket(struct 
sockaddr_vm *addr)
 {
struct vsock_sock *vsk;
 
-   list_for_each_entry(vsk, vsock_bound_sockets(addr), bound_table)
-   if (addr->svm_port == vsk->local_addr.svm_port)
+   list_for_each_entry(vsk, vsock_bound_sockets(addr), bound_table) {
+   if (vsock_addr_equals_addr(addr, >local_addr))
return sk_vsock(vsk);
 
+   if (addr->svm_port == vsk->local_addr.svm_port &&
+   (vsk->local_addr.svm_cid == VMADDR_CID_ANY ||
+addr->svm_cid == VMADDR_CID_ANY))
+   return sk_vsock(vsk);
+   }
+
return NULL;
 }
 
-- 
2.21.0