Re: [Resend][PATCH -mm] Hibernation: Enter platform hibernation state in a consistent way (rev. 4)

2007-09-14 Thread Rafael J. Wysocki 
On Saturday, 15 September 2007 01:37, Andrew Morton wrote:
> On Wed, 12 Sep 2007 13:14:08 +0200
> "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote:
> 
> > +   if (!hibernation_ops)
> > +   return -ENOSYS;
> > +
> > +   /*
> > +* We have cancelled the power transition by running
> > +* hibernation_ops->finish() before saving the image, so we should let
> > +* the firmware know that we're going to enter the sleep state after all
> > +*/
> > +   error = hibernation_ops->start();
> > +   if (error)
> > +   return error;
> > +
> > +   suspend_console();
> > +   error = device_suspend(PMSG_SUSPEND);
> > +   if (error)
> > +   return error;
> > +
> > +   error = hibernation_ops->prepare();
> > +   if (error)
> > +   goto Resume_devices;
> > +
> > +   error = disable_nonboot_cpus();
> > +   if (error)
> > +   goto Finish;
> > +
> > +   local_irq_disable();
> > +   error = device_power_down(PMSG_SUSPEND);
> > +   if (!error) {
> > +   hibernation_ops->enter();
> > +   /* We should never get here */
> > +   while (1);
> > }
> > +   local_irq_enable();
> > +
> 
> Confused.  afacit there's no way for the caller of this function to know
> whether or not suspend_console() was called, so the error recovery doesn't
> know whether or not to run resume_console().  How does all that work?

Well, if this fails, we try to power off and if that fails, we halt.

Resuming devices in case of an error is needed so that kernel_power_off()
can work, but the consoles need not be resumed for that.

Still, now that I think of it, the resuming of consoles in case of an error
will probably be useful in diagnostics.  I'll post a fix on top of this patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [Resend][PATCH -mm] Hibernation: Enter platform hibernation state in a consistent way (rev. 4)

2007-09-14 Thread Andrew Morton 
On Wed, 12 Sep 2007 13:14:08 +0200
"Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote:

> + if (!hibernation_ops)
> + return -ENOSYS;
> +
> + /*
> +  * We have cancelled the power transition by running
> +  * hibernation_ops->finish() before saving the image, so we should let
> +  * the firmware know that we're going to enter the sleep state after all
> +  */
> + error = hibernation_ops->start();
> + if (error)
> + return error;
> +
> + suspend_console();
> + error = device_suspend(PMSG_SUSPEND);
> + if (error)
> + return error;
> +
> + error = hibernation_ops->prepare();
> + if (error)
> + goto Resume_devices;
> +
> + error = disable_nonboot_cpus();
> + if (error)
> + goto Finish;
> +
> + local_irq_disable();
> + error = device_power_down(PMSG_SUSPEND);
> + if (!error) {
> + hibernation_ops->enter();
> + /* We should never get here */
> + while (1);
>   }
> + local_irq_enable();
> +

Confused.  afacit there's no way for the caller of this function to know
whether or not suspend_console() was called, so the error recovery doesn't
know whether or not to run resume_console().  How does all that work?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [Resend][PATCH -mm] Hibernation: Enter platform hibernation state in a consistent way (rev. 4)

2007-09-14 Thread Andrew Morton 
On Wed, 12 Sep 2007 13:14:08 +0200
Rafael J. Wysocki [EMAIL PROTECTED] wrote:

 + if (!hibernation_ops)
 + return -ENOSYS;
 +
 + /*
 +  * We have cancelled the power transition by running
 +  * hibernation_ops-finish() before saving the image, so we should let
 +  * the firmware know that we're going to enter the sleep state after all
 +  */
 + error = hibernation_ops-start();
 + if (error)
 + return error;
 +
 + suspend_console();
 + error = device_suspend(PMSG_SUSPEND);
 + if (error)
 + return error;
 +
 + error = hibernation_ops-prepare();
 + if (error)
 + goto Resume_devices;
 +
 + error = disable_nonboot_cpus();
 + if (error)
 + goto Finish;
 +
 + local_irq_disable();
 + error = device_power_down(PMSG_SUSPEND);
 + if (!error) {
 + hibernation_ops-enter();
 + /* We should never get here */
 + while (1);
   }
 + local_irq_enable();
 +

Confused.  afacit there's no way for the caller of this function to know
whether or not suspend_console() was called, so the error recovery doesn't
know whether or not to run resume_console().  How does all that work?
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [Resend][PATCH -mm] Hibernation: Enter platform hibernation state in a consistent way (rev. 4)

2007-09-14 Thread Rafael J. Wysocki 
On Saturday, 15 September 2007 01:37, Andrew Morton wrote:
 On Wed, 12 Sep 2007 13:14:08 +0200
 Rafael J. Wysocki [EMAIL PROTECTED] wrote:
 
  +   if (!hibernation_ops)
  +   return -ENOSYS;
  +
  +   /*
  +* We have cancelled the power transition by running
  +* hibernation_ops-finish() before saving the image, so we should let
  +* the firmware know that we're going to enter the sleep state after all
  +*/
  +   error = hibernation_ops-start();
  +   if (error)
  +   return error;
  +
  +   suspend_console();
  +   error = device_suspend(PMSG_SUSPEND);
  +   if (error)
  +   return error;
  +
  +   error = hibernation_ops-prepare();
  +   if (error)
  +   goto Resume_devices;
  +
  +   error = disable_nonboot_cpus();
  +   if (error)
  +   goto Finish;
  +
  +   local_irq_disable();
  +   error = device_power_down(PMSG_SUSPEND);
  +   if (!error) {
  +   hibernation_ops-enter();
  +   /* We should never get here */
  +   while (1);
  }
  +   local_irq_enable();
  +
 
 Confused.  afacit there's no way for the caller of this function to know
 whether or not suspend_console() was called, so the error recovery doesn't
 know whether or not to run resume_console().  How does all that work?

Well, if this fails, we try to power off and if that fails, we halt.

Resuming devices in case of an error is needed so that kernel_power_off()
can work, but the consoles need not be resumed for that.

Still, now that I think of it, the resuming of consoles in case of an error
will probably be useful in diagnostics.  I'll post a fix on top of this patch.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Resend][PATCH -mm] Hibernation: Enter platform hibernation state in a consistent way (rev. 4)

2007-09-12 Thread Rafael J. Wysocki 
From: Rafael J. Wysocki <[EMAIL PROTECTED]>

Make hibernation_platform_enter() execute the enter-a-sleep-state sequence
instead of the mixed shutdown-with-entering-S4 thing.

Replace the shutting down of devices done by kernel_shutdown_prepare(), before
entering the ACPI S4 sleep state, with suspending them and the shutting down of
sysdevs with calling device_power_down(PMSG_SUSPEND) (just like before entering
S1 or S3, but the target state is now S4).  Also, disable the nonboot CPUs
before entering the sleep state (S4), which generally always is a good idea.

This is known to fix the "double disk spin down during hibernation" on some
machines, eg. HPC nx6325 (ref. http://lkml.org/lkml/2007/8/7/316 and the
following thread).  Moreover, it has been reported to make
/sys/class/rtc/rtc0/wakealarm work correctly with hibernation for some users.
It also generally causes the hibernation state (ACPI S4) to be entered faster.

Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
Acked-by: Pavel Machek <[EMAIL PROTECTED]>
---
 kernel/power/disk.c |   61 +---
 1 file changed, 44 insertions(+), 17 deletions(-)

Index: linux-2.6.23-rc6/kernel/power/disk.c
===
--- linux-2.6.23-rc6.orig/kernel/power/disk.c
+++ linux-2.6.23-rc6/kernel/power/disk.c
@@ -222,21 +222,48 @@ int hibernation_platform_enter(void)
 {
int error;
 
-   if (hibernation_ops) {
-   kernel_shutdown_prepare(SYSTEM_SUSPEND_DISK);
-   /*
-* We have cancelled the power transition by running
-* hibernation_ops->finish() before saving the image, so we
-* should let the firmware know that we're going to enter the
-* sleep state after all
-*/
-   error = hibernation_ops->prepare();
-   sysdev_shutdown();
-   if (!error)
-   error = hibernation_ops->enter();
-   } else {
-   error = -ENOSYS;
+   if (!hibernation_ops)
+   return -ENOSYS;
+
+   /*
+* We have cancelled the power transition by running
+* hibernation_ops->finish() before saving the image, so we should let
+* the firmware know that we're going to enter the sleep state after all
+*/
+   error = hibernation_ops->start();
+   if (error)
+   return error;
+
+   suspend_console();
+   error = device_suspend(PMSG_SUSPEND);
+   if (error)
+   return error;
+
+   error = hibernation_ops->prepare();
+   if (error)
+   goto Resume_devices;
+
+   error = disable_nonboot_cpus();
+   if (error)
+   goto Finish;
+
+   local_irq_disable();
+   error = device_power_down(PMSG_SUSPEND);
+   if (!error) {
+   hibernation_ops->enter();
+   /* We should never get here */
+   while (1);
}
+   local_irq_enable();
+
+   /*
+* We don't need to reenable the nonboot CPUs or resume consoles, since
+* the system is going to be halted anyway.
+*/
+ Finish:
+   hibernation_ops->finish();
+ Resume_devices:
+   device_resume();
return error;
 }
 
@@ -253,14 +280,14 @@ static void power_down(void)
case HIBERNATION_TEST:
case HIBERNATION_TESTPROC:
break;
-   case HIBERNATION_SHUTDOWN:
-   kernel_power_off();
-   break;
case HIBERNATION_REBOOT:
kernel_restart(NULL);
break;
case HIBERNATION_PLATFORM:
hibernation_platform_enter();
+   case HIBERNATION_SHUTDOWN:
+   kernel_power_off();
+   break;
}
kernel_halt();
/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Resend][PATCH -mm] Hibernation: Enter platform hibernation state in a consistent way (rev. 4)

2007-09-12 Thread Rafael J. Wysocki 
From: Rafael J. Wysocki [EMAIL PROTECTED]

Make hibernation_platform_enter() execute the enter-a-sleep-state sequence
instead of the mixed shutdown-with-entering-S4 thing.

Replace the shutting down of devices done by kernel_shutdown_prepare(), before
entering the ACPI S4 sleep state, with suspending them and the shutting down of
sysdevs with calling device_power_down(PMSG_SUSPEND) (just like before entering
S1 or S3, but the target state is now S4).  Also, disable the nonboot CPUs
before entering the sleep state (S4), which generally always is a good idea.

This is known to fix the double disk spin down during hibernation on some
machines, eg. HPC nx6325 (ref. http://lkml.org/lkml/2007/8/7/316 and the
following thread).  Moreover, it has been reported to make
/sys/class/rtc/rtc0/wakealarm work correctly with hibernation for some users.
It also generally causes the hibernation state (ACPI S4) to be entered faster.

Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED]
Acked-by: Pavel Machek [EMAIL PROTECTED]
---
 kernel/power/disk.c |   61 +---
 1 file changed, 44 insertions(+), 17 deletions(-)

Index: linux-2.6.23-rc6/kernel/power/disk.c
===
--- linux-2.6.23-rc6.orig/kernel/power/disk.c
+++ linux-2.6.23-rc6/kernel/power/disk.c
@@ -222,21 +222,48 @@ int hibernation_platform_enter(void)
 {
int error;
 
-   if (hibernation_ops) {
-   kernel_shutdown_prepare(SYSTEM_SUSPEND_DISK);
-   /*
-* We have cancelled the power transition by running
-* hibernation_ops-finish() before saving the image, so we
-* should let the firmware know that we're going to enter the
-* sleep state after all
-*/
-   error = hibernation_ops-prepare();
-   sysdev_shutdown();
-   if (!error)
-   error = hibernation_ops-enter();
-   } else {
-   error = -ENOSYS;
+   if (!hibernation_ops)
+   return -ENOSYS;
+
+   /*
+* We have cancelled the power transition by running
+* hibernation_ops-finish() before saving the image, so we should let
+* the firmware know that we're going to enter the sleep state after all
+*/
+   error = hibernation_ops-start();
+   if (error)
+   return error;
+
+   suspend_console();
+   error = device_suspend(PMSG_SUSPEND);
+   if (error)
+   return error;
+
+   error = hibernation_ops-prepare();
+   if (error)
+   goto Resume_devices;
+
+   error = disable_nonboot_cpus();
+   if (error)
+   goto Finish;
+
+   local_irq_disable();
+   error = device_power_down(PMSG_SUSPEND);
+   if (!error) {
+   hibernation_ops-enter();
+   /* We should never get here */
+   while (1);
}
+   local_irq_enable();
+
+   /*
+* We don't need to reenable the nonboot CPUs or resume consoles, since
+* the system is going to be halted anyway.
+*/
+ Finish:
+   hibernation_ops-finish();
+ Resume_devices:
+   device_resume();
return error;
 }
 
@@ -253,14 +280,14 @@ static void power_down(void)
case HIBERNATION_TEST:
case HIBERNATION_TESTPROC:
break;
-   case HIBERNATION_SHUTDOWN:
-   kernel_power_off();
-   break;
case HIBERNATION_REBOOT:
kernel_restart(NULL);
break;
case HIBERNATION_PLATFORM:
hibernation_platform_enter();
+   case HIBERNATION_SHUTDOWN:
+   kernel_power_off();
+   break;
}
kernel_halt();
/*
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/