Re: [TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
> Use the new vsprintf extension to avoid any possible
> message interleaving.
>
> Signed-off-by: Joe Perches
Sorry for my last email, which should not reply all.
Acked-by: Guan Xuetao
> ---
> arch/unicore32/kernel/process.c |5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/unicore32/kernel/process.c
> b/arch/unicore32/kernel/process.c
> index 62bad9f..d17a893 100644
> --- a/arch/unicore32/kernel/process.c
> +++ b/arch/unicore32/kernel/process.c
> @@ -169,8 +169,9 @@ void __show_regs(struct pt_regs *regs)
> init_utsname()->release,
> (int)strcspn(init_utsname()->version, " "),
> init_utsname()->version);
> - print_symbol("PC is at %s\n", instruction_pointer(regs));
> - print_symbol("LR is at %s\n", regs->UCreg_lr);
> + printk(KERN_DEFAULT "PC is at %pSR\n",
> +(void *)instruction_pointer(regs));
> + printk(KERN_DEFAULT "LR is at %pSR\n", (void *)regs->UCreg_lr);
> printk(KERN_DEFAULT "pc : [<%08lx>]lr : [<%08lx>]psr: %08lx\n"
> "sp : %08lx ip : %08lx fp : %08lx\n",
> regs->UCreg_pc, regs->UCreg_lr, regs->UCreg_asr,
> --
> 1.7.8.112.g3fd21
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: 答复: [TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
On Thu, 2012-12-13 at 09:00 +0800, Guan Xuetao wrote:
> 确认下面的patch可以正常编译，无warning信息
There is no unicore32 cross compiler available
on kernel.org.
ftp://ftp.kernel.org/pub/tools/crosstool/index.html
These are unsigned long cast to (void *)
What is the warning and how does it differ
from any existing warning?
> > diff --git a/arch/unicore32/kernel/process.c
[]
> > @@ -169,8 +169,9 @@ void __show_regs(struct pt_regs *regs)
> > init_utsname()->release,
> > (int)strcspn(init_utsname()->version, " "),
> > init_utsname()->version);
> > - print_symbol("PC is at %s\n", instruction_pointer(regs));
> > - print_symbol("LR is at %s\n", regs->UCreg_lr);
> > + printk(KERN_DEFAULT "PC is at %pSR\n",
> > + (void *)instruction_pointer(regs));
> > + printk(KERN_DEFAULT "LR is at %pSR\n", (void *)regs->UCreg_lr);
> > printk(KERN_DEFAULT "pc : [<%08lx>]lr : [<%08lx>]psr:
> %08lx\n"
> >"sp : %08lx ip : %08lx fp : %08lx\n",
> > regs->UCreg_pc, regs->UCreg_lr, regs->UCreg_asr,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: 答复: [TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
于 2012年12月13日 09:21, Joe Perches 写道: > On Thu, 2012-12-13 at 09:00 +0800, Guan Xuetao wrote: >> 确认下面的patch可以正常编译，无warning信息 please be sure that the patch below can pass compiling, without warnings > > I'm afraid I can't read this. > Anyone have an English translation? > I can try (although I do not known the details of this patch) :-) > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 答复: [TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
On Thu, 2012-12-13 at 09:00 +0800, Guan Xuetao wrote: > 确认下面的patch可以正常编译，无warning信息 I'm afraid I can't read this. Anyone have an English translation? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
Use the new vsprintf extension to avoid any possible
message interleaving.
Signed-off-by: Joe Perches
---
arch/unicore32/kernel/process.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/unicore32/kernel/process.c b/arch/unicore32/kernel/process.c
index 62bad9f..d17a893 100644
--- a/arch/unicore32/kernel/process.c
+++ b/arch/unicore32/kernel/process.c
@@ -169,8 +169,9 @@ void __show_regs(struct pt_regs *regs)
init_utsname()->release,
(int)strcspn(init_utsname()->version, " "),
init_utsname()->version);
- print_symbol("PC is at %s\n", instruction_pointer(regs));
- print_symbol("LR is at %s\n", regs->UCreg_lr);
+ printk(KERN_DEFAULT "PC is at %pSR\n",
+ (void *)instruction_pointer(regs));
+ printk(KERN_DEFAULT "LR is at %pSR\n", (void *)regs->UCreg_lr);
printk(KERN_DEFAULT "pc : [<%08lx>]lr : [<%08lx>]psr: %08lx\n"
"sp : %08lx ip : %08lx fp : %08lx\n",
regs->UCreg_pc, regs->UCreg_lr, regs->UCreg_asr,
--
1.7.8.112.g3fd21
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
Use the new vsprintf extension to avoid any possible message interleaving. Signed-off-by: Joe Perches j...@perches.com --- arch/unicore32/kernel/process.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/unicore32/kernel/process.c b/arch/unicore32/kernel/process.c index 62bad9f..d17a893 100644 --- a/arch/unicore32/kernel/process.c +++ b/arch/unicore32/kernel/process.c @@ -169,8 +169,9 @@ void __show_regs(struct pt_regs *regs) init_utsname()-release, (int)strcspn(init_utsname()-version, ), init_utsname()-version); - print_symbol(PC is at %s\n, instruction_pointer(regs)); - print_symbol(LR is at %s\n, regs-UCreg_lr); + printk(KERN_DEFAULT PC is at %pSR\n, + (void *)instruction_pointer(regs)); + printk(KERN_DEFAULT LR is at %pSR\n, (void *)regs-UCreg_lr); printk(KERN_DEFAULT pc : [%08lx]lr : [%08lx]psr: %08lx\n sp : %08lx ip : %08lx fp : %08lx\n, regs-UCreg_pc, regs-UCreg_lr, regs-UCreg_asr, -- 1.7.8.112.g3fd21 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 答复: [TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
On Thu, 2012-12-13 at 09:00 +0800, Guan Xuetao wrote: 确认下面的patch可以正常编译，无warning信息 I'm afraid I can't read this. Anyone have an English translation? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 答复: [TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
于 2012年12月13日 09:21, Joe Perches 写道: On Thu, 2012-12-13 at 09:00 +0800, Guan Xuetao wrote: 确认下面的patch可以正常编译，无warning信息 please be sure that the patch below can pass compiling, without warnings I'm afraid I can't read this. Anyone have an English translation? I can try (although I do not known the details of this patch) :-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 答复: [TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
On Thu, 2012-12-13 at 09:00 +0800, Guan Xuetao wrote: 确认下面的patch可以正常编译，无warning信息 There is no unicore32 cross compiler available on kernel.org. ftp://ftp.kernel.org/pub/tools/crosstool/index.html These are unsigned long cast to (void *) What is the warning and how does it differ from any existing warning? diff --git a/arch/unicore32/kernel/process.c [] @@ -169,8 +169,9 @@ void __show_regs(struct pt_regs *regs) init_utsname()-release, (int)strcspn(init_utsname()-version, ), init_utsname()-version); - print_symbol(PC is at %s\n, instruction_pointer(regs)); - print_symbol(LR is at %s\n, regs-UCreg_lr); + printk(KERN_DEFAULT PC is at %pSR\n, + (void *)instruction_pointer(regs)); + printk(KERN_DEFAULT LR is at %pSR\n, (void *)regs-UCreg_lr); printk(KERN_DEFAULT pc : [%08lx]lr : [%08lx]psr: %08lx\n sp : %08lx ip : %08lx fp : %08lx\n, regs-UCreg_pc, regs-UCreg_lr, regs-UCreg_asr, -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [TRIVIAL PATCH 15/26] unicore32: Convert print_symbol to %pSR
Use the new vsprintf extension to avoid any possible message interleaving. Signed-off-by: Joe Perches j...@perches.com Sorry for my last email, which should not reply all. Acked-by: Guan Xuetao g...@mprc.pku.edu.cn --- arch/unicore32/kernel/process.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/unicore32/kernel/process.c b/arch/unicore32/kernel/process.c index 62bad9f..d17a893 100644 --- a/arch/unicore32/kernel/process.c +++ b/arch/unicore32/kernel/process.c @@ -169,8 +169,9 @@ void __show_regs(struct pt_regs *regs) init_utsname()-release, (int)strcspn(init_utsname()-version, ), init_utsname()-version); - print_symbol(PC is at %s\n, instruction_pointer(regs)); - print_symbol(LR is at %s\n, regs-UCreg_lr); + printk(KERN_DEFAULT PC is at %pSR\n, +(void *)instruction_pointer(regs)); + printk(KERN_DEFAULT LR is at %pSR\n, (void *)regs-UCreg_lr); printk(KERN_DEFAULT pc : [%08lx]lr : [%08lx]psr: %08lx\n sp : %08lx ip : %08lx fp : %08lx\n, regs-UCreg_pc, regs-UCreg_lr, regs-UCreg_asr, -- 1.7.8.112.g3fd21 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
