Re: [V2 2/2] dmaengine: fsl-qdma: Add improvement

2019-05-20 Thread Vinod Koul
On 06-05-19, 10:21, Peng Ma wrote:
> When an error occurs we should clean the error register then to return

Applied, thanks

-- 
~Vinod


[V2 2/2] dmaengine: fsl-qdma: Add improvement

2019-05-05 Thread Peng Ma
When an error occurs we should clean the error register then to return

Signed-off-by: Peng Ma 
---
changed for V2:
- Separate one patch to two patchs

 drivers/dma/fsl-qdma.c |4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
index 2e8b46b..542765a 100644
--- a/drivers/dma/fsl-qdma.c
+++ b/drivers/dma/fsl-qdma.c
@@ -710,10 +710,8 @@ static irqreturn_t fsl_qdma_error_handler(int irq, void 
*dev_id)
 
intr = qdma_readl(fsl_qdma, status + FSL_QDMA_DEDR);
 
-   if (intr) {
+   if (intr)
dev_err(fsl_qdma->dma_dev.dev, "DMA transaction error!\n");
-   return IRQ_NONE;
-   }
 
qdma_writel(fsl_qdma, FSL_QDMA_DEDR_CLEAR, status + FSL_QDMA_DEDR);
return IRQ_HANDLED;
-- 
1.7.1