Re: [V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390
On Thu, May 28, 2020 at 11:17 PM Rob Herring wrote:
>
> On Thu, May 28, 2020 at 07:37:55PM +0900, Steve Lee wrote:
> > Add DT binding of max98390 amplifier driver.
> >
> > Signed-off-by: Steve Lee
> > ---
> > Changed since V5:
> > * Change txt to yaml and fix up the examples.
> > Changed since V4:
> > * No changes.
> > Changed since V3:
> > * No changes.
> > Changed since V2:
> > * No changes.
> > Changed since V1:
> > * Modified sample text in example
> >
> > .../bindings/sound/maxim,max98390.yaml| 39 +++
> > 1 file changed, 39 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> > b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> > new file mode 100644
> > index ..1ed4ab9e1c37
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> > @@ -0,0 +1,39 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/maxim,max98390.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic
> > Speaker Management
> > +
> > +maintainers:
> > + - Steve Lee
> > +
> > +properties:
> > + compatible:
> > + const: maxim,max98390
> > +
> > + reg:
> > +maxItems: 1
> > +description: I2C address of the device.
> > +
> > + temperature_calib:
>
> s/_/-/
This is follow as coreboot in Chromium OS case.
I'd follow this name unchanged.
>
> And missing 'maxim' prefix.
Added missed prefix maxim prefix.
>
> > +$ref: /schemas/types.yaml#/definitions/uint32
> > +description: The calculated temperature data was measured while doing
> > the calibration. Data : Temp / 100 * 2^12
>
> Any constraints? 0-2^32 are valid values?
I added range of the values
>
> > +
> > + r0_calib:
>
> Same here.
I added range of the values.
>
> > +$ref: /schemas/types.yaml#/definitions/uint32
> > +description: This is r0 calibration data which was measured in factory
> > mode.
> > +
> > +required:
> > + - compatible
> > + - reg
>
> Add:
>
> additionalProperties: false
I have added this.
>
> > +
> > +examples:
> > + - |
> > +max98390: amplifier@38 {
> > +compatible = "maxim,max98390";
> > +reg = <0x38>;
> > +maxim,temperature_calib = <1024>;
> > +maxim,r0_calib = <100232>;
> > +};
> > --
> > 2.17.1
> >
Re: [V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390
On Thu, May 28, 2020 at 11:15 PM Rob Herring wrote: > > On Thu, 28 May 2020 19:37:55 +0900, Steve Lee wrote: > > Add DT binding of max98390 amplifier driver. > > > > Signed-off-by: Steve Lee > > --- > > Changed since V5: > > * Change txt to yaml and fix up the examples. > > Changed since V4: > > * No changes. > > Changed since V3: > > * No changes. > > Changed since V2: > > * No changes. > > Changed since V1: > > * Modified sample text in example > > > > .../bindings/sound/maxim,max98390.yaml| 39 +++ > > 1 file changed, 39 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/sound/maxim,max98390.yaml: mapping values > are not allowed in this context > in "", line 22, column 97 > Documentation/devicetree/bindings/Makefile:12: recipe for target > 'Documentation/devicetree/bindings/sound/maxim,max98390.example.dts' failed > make[1]: *** > [Documentation/devicetree/bindings/sound/maxim,max98390.example.dts] Error 1 > make[1]: *** Waiting for unfinished jobs > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: > ignoring, error parsing file > warning: no schema found in file: > ./Documentation/devicetree/bindings/sound/maxim,max98390.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: > ignoring, error parsing file > warning: no schema found in file: > ./Documentation/devicetree/bindings/sound/maxim,max98390.yaml > Makefile:1300: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1299651 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master > --upgrade > > Please check and re-submit. > Thanks for feedback. I re-submit with after dt binding check again.
Re: [V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390
On Thu, May 28, 2020 at 07:37:55PM +0900, Steve Lee wrote:
> Add DT binding of max98390 amplifier driver.
>
> Signed-off-by: Steve Lee
> ---
> Changed since V5:
> * Change txt to yaml and fix up the examples.
> Changed since V4:
> * No changes.
> Changed since V3:
> * No changes.
> Changed since V2:
> * No changes.
> Changed since V1:
> * Modified sample text in example
>
> .../bindings/sound/maxim,max98390.yaml| 39 +++
> 1 file changed, 39 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/sound/maxim,max98390.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> new file mode 100644
> index ..1ed4ab9e1c37
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/maxim,max98390.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic
> Speaker Management
> +
> +maintainers:
> + - Steve Lee
> +
> +properties:
> + compatible:
> + const: maxim,max98390
> +
> + reg:
> +maxItems: 1
> +description: I2C address of the device.
> +
> + temperature_calib:
s/_/-/
And missing 'maxim' prefix.
> +$ref: /schemas/types.yaml#/definitions/uint32
> +description: The calculated temperature data was measured while doing
> the calibration. Data : Temp / 100 * 2^12
Any constraints? 0-2^32 are valid values?
> +
> + r0_calib:
Same here.
> +$ref: /schemas/types.yaml#/definitions/uint32
> +description: This is r0 calibration data which was measured in factory
> mode.
> +
> +required:
> + - compatible
> + - reg
Add:
additionalProperties: false
> +
> +examples:
> + - |
> +max98390: amplifier@38 {
> +compatible = "maxim,max98390";
> +reg = <0x38>;
> +maxim,temperature_calib = <1024>;
> +maxim,r0_calib = <100232>;
> +};
> --
> 2.17.1
>
Re: [V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390
On Thu, 28 May 2020 19:37:55 +0900, Steve Lee wrote: > Add DT binding of max98390 amplifier driver. > > Signed-off-by: Steve Lee > --- > Changed since V5: > * Change txt to yaml and fix up the examples. > Changed since V4: > * No changes. > Changed since V3: > * No changes. > Changed since V2: > * No changes. > Changed since V1: > * Modified sample text in example > > .../bindings/sound/maxim,max98390.yaml| 39 +++ > 1 file changed, 39 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/sound/maxim,max98390.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/sound/maxim,max98390.yaml: mapping values are not allowed in this context in "", line 22, column 97 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/sound/maxim,max98390.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/sound/maxim,max98390.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: ignoring, error parsing file warning: no schema found in file: ./Documentation/devicetree/bindings/sound/maxim,max98390.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: ignoring, error parsing file warning: no schema found in file: ./Documentation/devicetree/bindings/sound/maxim,max98390.yaml Makefile:1300: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1299651 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
[V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390
Add DT binding of max98390 amplifier driver.
Signed-off-by: Steve Lee
---
Changed since V5:
* Change txt to yaml and fix up the examples.
Changed since V4:
* No changes.
Changed since V3:
* No changes.
Changed since V2:
* No changes.
Changed since V1:
* Modified sample text in example
.../bindings/sound/maxim,max98390.yaml| 39 +++
1 file changed, 39 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yaml
diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
new file mode 100644
index ..1ed4ab9e1c37
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/maxim,max98390.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic
Speaker Management
+
+maintainers:
+ - Steve Lee
+
+properties:
+ compatible:
+ const: maxim,max98390
+
+ reg:
+maxItems: 1
+description: I2C address of the device.
+
+ temperature_calib:
+$ref: /schemas/types.yaml#/definitions/uint32
+description: The calculated temperature data was measured while doing the
calibration. Data : Temp / 100 * 2^12
+
+ r0_calib:
+$ref: /schemas/types.yaml#/definitions/uint32
+description: This is r0 calibration data which was measured in factory
mode.
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+max98390: amplifier@38 {
+compatible = "maxim,max98390";
+reg = <0x38>;
+maxim,temperature_calib = <1024>;
+maxim,r0_calib = <100232>;
+};
--
2.17.1
