Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
On 28/09/15 15:02, Boris Ostrovsky wrote: > On 09/28/2015 09:59 AM, Julien Grall wrote: >> Hi David, >> >> On 28/09/15 14:52, David Vrabel wrote: >>> On 28/09/15 14:30, Julien Grall wrote: The PCI support for Xen doesn't compile on ARM/ARM64 when CONFIG_PCI_MMCONFIG=y: drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or directory #include Although, Xen is not currently involved in PCI management for ARM/ARM64. There is plan to support it, but it would require some changes in Linux side. For now, introduce a new config options XEN_PCI which will be turned off for ARM platform. >>> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c >>> is, can you fix this by changing to #ifdef CONFIG_X86? >> Well, it may be possible that we need this code for ARM/ARM64. >> >> From the origin thread [1], it wasn't clear what is the correct >> solution. So I think that disabling the Xen PCI code for now is the >> right solution. >> >> Note, that it's still possible to use PCI in DOM0 on ARM64 platform >> without this code. >> >> Regards, >> >> [1] https://lkml.org/lkml/2015/8/6/510 >> > > Can we then implement Robert's proposals from that thread and have an > arch function for pci_probe? It will be a nop on ARM. (I think that was > the only problem here). H. It looks like that the mmconfig is not yet supported upstream for ARM64. So even with arch function for pci_probe so it won't work. I hit the compilation issue on a 4.2 with patched applied for some hardware enablement. Some of them if for mmconfig. I should have check it before sending it. Sorry for the noise. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
On 28/09/15 15:02, Boris Ostrovsky wrote: > On 09/28/2015 09:59 AM, Julien Grall wrote: >> Hi David, >> >> On 28/09/15 14:52, David Vrabel wrote: >>> On 28/09/15 14:30, Julien Grall wrote: The PCI support for Xen doesn't compile on ARM/ARM64 when CONFIG_PCI_MMCONFIG=y: drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or directory #include Although, Xen is not currently involved in PCI management for ARM/ARM64. There is plan to support it, but it would require some changes in Linux side. For now, introduce a new config options XEN_PCI which will be turned off for ARM platform. >>> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c >>> is, can you fix this by changing to #ifdef CONFIG_X86? This. >> Well, it may be possible that we need this code for ARM/ARM64. >> >> From the origin thread [1], it wasn't clear what is the correct >> solution. So I think that disabling the Xen PCI code for now is the >> right solution. >> >> Note, that it's still possible to use PCI in DOM0 on ARM64 platform >> without this code. >> >> Regards, >> >> [1] https://lkml.org/lkml/2015/8/6/510 >> > > Can we then implement Robert's proposals from that thread and have an > arch function for pci_probe? It will be a nop on ARM. (I think that was > the only problem here). Or preferably this. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
On 09/28/2015 09:59 AM, Julien Grall wrote: Hi David, On 28/09/15 14:52, David Vrabel wrote: On 28/09/15 14:30, Julien Grall wrote: The PCI support for Xen doesn't compile on ARM/ARM64 when CONFIG_PCI_MMCONFIG=y: drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or directory #include Although, Xen is not currently involved in PCI management for ARM/ARM64. There is plan to support it, but it would require some changes in Linux side. For now, introduce a new config options XEN_PCI which will be turned off for ARM platform. Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c is, can you fix this by changing to #ifdef CONFIG_X86? Well, it may be possible that we need this code for ARM/ARM64. From the origin thread [1], it wasn't clear what is the correct solution. So I think that disabling the Xen PCI code for now is the right solution. Note, that it's still possible to use PCI in DOM0 on ARM64 platform without this code. Regards, [1] https://lkml.org/lkml/2015/8/6/510 Can we then implement Robert's proposals from that thread and have an arch function for pci_probe? It will be a nop on ARM. (I think that was the only problem here). -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
Hi David, On 28/09/15 14:52, David Vrabel wrote: > On 28/09/15 14:30, Julien Grall wrote: >> The PCI support for Xen doesn't compile on ARM/ARM64 when >> CONFIG_PCI_MMCONFIG=y: >> >> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or >> directory >> #include >> >> Although, Xen is not currently involved in PCI management for ARM/ARM64. >> There is plan to support it, but it would require some changes in Linux >> side. >> >> For now, introduce a new config options XEN_PCI which will be turned off >> for ARM platform. > > Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c > is, can you fix this by changing to #ifdef CONFIG_X86? Well, it may be possible that we need this code for ARM/ARM64. >From the origin thread [1], it wasn't clear what is the correct solution. So I think that disabling the Xen PCI code for now is the right solution. Note, that it's still possible to use PCI in DOM0 on ARM64 platform without this code. Regards, [1] https://lkml.org/lkml/2015/8/6/510 -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
On 28/09/15 14:30, Julien Grall wrote: > The PCI support for Xen doesn't compile on ARM/ARM64 when > CONFIG_PCI_MMCONFIG=y: > > drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or > directory > #include > > Although, Xen is not currently involved in PCI management for ARM/ARM64. > There is plan to support it, but it would require some changes in Linux > side. > > For now, introduce a new config options XEN_PCI which will be turned off > for ARM platform. Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c is, can you fix this by changing to #ifdef CONFIG_X86? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
On 09/28/2015 09:59 AM, Julien Grall wrote: Hi David, On 28/09/15 14:52, David Vrabel wrote: On 28/09/15 14:30, Julien Grall wrote: The PCI support for Xen doesn't compile on ARM/ARM64 when CONFIG_PCI_MMCONFIG=y: drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or directory #include Although, Xen is not currently involved in PCI management for ARM/ARM64. There is plan to support it, but it would require some changes in Linux side. For now, introduce a new config options XEN_PCI which will be turned off for ARM platform. Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c is, can you fix this by changing to #ifdef CONFIG_X86? Well, it may be possible that we need this code for ARM/ARM64. From the origin thread [1], it wasn't clear what is the correct solution. So I think that disabling the Xen PCI code for now is the right solution. Note, that it's still possible to use PCI in DOM0 on ARM64 platform without this code. Regards, [1] https://lkml.org/lkml/2015/8/6/510 Can we then implement Robert's proposals from that thread and have an arch function for pci_probe? It will be a nop on ARM. (I think that was the only problem here). -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
On 28/09/15 15:02, Boris Ostrovsky wrote: > On 09/28/2015 09:59 AM, Julien Grall wrote: >> Hi David, >> >> On 28/09/15 14:52, David Vrabel wrote: >>> On 28/09/15 14:30, Julien Grall wrote: The PCI support for Xen doesn't compile on ARM/ARM64 when CONFIG_PCI_MMCONFIG=y: drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or directory #include Although, Xen is not currently involved in PCI management for ARM/ARM64. There is plan to support it, but it would require some changes in Linux side. For now, introduce a new config options XEN_PCI which will be turned off for ARM platform. >>> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c >>> is, can you fix this by changing to #ifdef CONFIG_X86? This. >> Well, it may be possible that we need this code for ARM/ARM64. >> >> From the origin thread [1], it wasn't clear what is the correct >> solution. So I think that disabling the Xen PCI code for now is the >> right solution. >> >> Note, that it's still possible to use PCI in DOM0 on ARM64 platform >> without this code. >> >> Regards, >> >> [1] https://lkml.org/lkml/2015/8/6/510 >> > > Can we then implement Robert's proposals from that thread and have an > arch function for pci_probe? It will be a nop on ARM. (I think that was > the only problem here). Or preferably this. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
On 28/09/15 15:02, Boris Ostrovsky wrote: > On 09/28/2015 09:59 AM, Julien Grall wrote: >> Hi David, >> >> On 28/09/15 14:52, David Vrabel wrote: >>> On 28/09/15 14:30, Julien Grall wrote: The PCI support for Xen doesn't compile on ARM/ARM64 when CONFIG_PCI_MMCONFIG=y: drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or directory #include Although, Xen is not currently involved in PCI management for ARM/ARM64. There is plan to support it, but it would require some changes in Linux side. For now, introduce a new config options XEN_PCI which will be turned off for ARM platform. >>> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c >>> is, can you fix this by changing to #ifdef CONFIG_X86? >> Well, it may be possible that we need this code for ARM/ARM64. >> >> From the origin thread [1], it wasn't clear what is the correct >> solution. So I think that disabling the Xen PCI code for now is the >> right solution. >> >> Note, that it's still possible to use PCI in DOM0 on ARM64 platform >> without this code. >> >> Regards, >> >> [1] https://lkml.org/lkml/2015/8/6/510 >> > > Can we then implement Robert's proposals from that thread and have an > arch function for pci_probe? It will be a nop on ARM. (I think that was > the only problem here). H. It looks like that the mmconfig is not yet supported upstream for ARM64. So even with arch function for pci_probe so it won't work. I hit the compilation issue on a 4.2 with patched applied for some hardware enablement. Some of them if for mmconfig. I should have check it before sending it. Sorry for the noise. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
Hi David, On 28/09/15 14:52, David Vrabel wrote: > On 28/09/15 14:30, Julien Grall wrote: >> The PCI support for Xen doesn't compile on ARM/ARM64 when >> CONFIG_PCI_MMCONFIG=y: >> >> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or >> directory >> #include >> >> Although, Xen is not currently involved in PCI management for ARM/ARM64. >> There is plan to support it, but it would require some changes in Linux >> side. >> >> For now, introduce a new config options XEN_PCI which will be turned off >> for ARM platform. > > Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c > is, can you fix this by changing to #ifdef CONFIG_X86? Well, it may be possible that we need this code for ARM/ARM64. >From the origin thread [1], it wasn't clear what is the correct solution. So I think that disabling the Xen PCI code for now is the right solution. Note, that it's still possible to use PCI in DOM0 on ARM64 platform without this code. Regards, [1] https://lkml.org/lkml/2015/8/6/510 -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
On 28/09/15 14:30, Julien Grall wrote: > The PCI support for Xen doesn't compile on ARM/ARM64 when > CONFIG_PCI_MMCONFIG=y: > > drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or > directory > #include > > Although, Xen is not currently involved in PCI management for ARM/ARM64. > There is plan to support it, but it would require some changes in Linux > side. > > For now, introduce a new config options XEN_PCI which will be turned off > for ARM platform. Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c is, can you fix this by changing to #ifdef CONFIG_X86? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
