Re: [Y2038] [PATCH 1/2] ppdev: convert to y2038 safe
On Wednesday 09 December 2015 14:11:37 Bamvor Jian Zhang wrote: > The y2038 issue for ppdev is changes of timeval in the ioctl > (PPSETTIME and PPGETTIME). The size of struct timeval changes from > 8bytes to 16bytes due to the changes of time_t. It lead to the > changes of the command of ioctl, e.g. for PPGETTIME, We have: > > on 32-bit (old): 0x80087095 > on 32-bit (new): 0x80107095 > on 64-bit : 0x80107095 > > This patch define these two ioctl commands to support the 32bit > and 64bit time_t application at the same time. And, introduce > pp_set_timeout to remove some duplicated code. > > Signed-off-by: Bamvor Jian Zhang I've reviewed the previous versions in detail, and am happy with the latest one. Reviewed-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Y2038] [PATCH 1/2] ppdev: convert to y2038 safe
On Wednesday 09 December 2015 14:11:37 Bamvor Jian Zhang wrote: > The y2038 issue for ppdev is changes of timeval in the ioctl > (PPSETTIME and PPGETTIME). The size of struct timeval changes from > 8bytes to 16bytes due to the changes of time_t. It lead to the > changes of the command of ioctl, e.g. for PPGETTIME, We have: > > on 32-bit (old): 0x80087095 > on 32-bit (new): 0x80107095 > on 64-bit : 0x80107095 > > This patch define these two ioctl commands to support the 32bit > and 64bit time_t application at the same time. And, introduce > pp_set_timeout to remove some duplicated code. > > Signed-off-by: Bamvor Jian ZhangI've reviewed the previous versions in detail, and am happy with the latest one. Reviewed-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/