Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Mark Brown]

On Thu, Aug 24, 2017 at 07:44:07PM +0200, Takashi Iwai wrote:

> Good to hear.  Now I merged to for-linus branch and pushed out.

> Mark, could you pull my for-linus branch into your rt5677 branch,
> before Stephen grumbles on the merge conflicts?

Done now.


signature.asc
Description: PGP signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Mark Brown]

On Thu, Aug 24, 2017 at 07:44:07PM +0200, Takashi Iwai wrote:

> Good to hear.  Now I merged to for-linus branch and pushed out.

> Mark, could you pull my for-linus branch into your rt5677 branch,
> before Stephen grumbles on the merge conflicts?

Done now.


signature.asc
Description: PGP signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Fri, 25 Aug 2017 15:09:00 +0200,
Mark Brown wrote:
> 
> On Thu, Aug 24, 2017 at 06:06:20PM +0200, Takashi Iwai wrote:
> 
> > From: Tom Rini 
> > Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
> 
> Acked-by: Mark Brown 
> 
> Can you send me a pull request for -next so I can revert it with the
> better fix being there please?

Could you just pull for-linus branch of my tree?
Or you can pull tags/sound-4.13-rc7 tag instead, too.


thanks,

Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Fri, 25 Aug 2017 15:09:00 +0200,
Mark Brown wrote:
> 
> On Thu, Aug 24, 2017 at 06:06:20PM +0200, Takashi Iwai wrote:
> 
> > From: Tom Rini 
> > Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
> 
> Acked-by: Mark Brown 
> 
> Can you send me a pull request for -next so I can revert it with the
> better fix being there please?

Could you just pull for-linus branch of my tree?
Or you can pull tags/sound-4.13-rc7 tag instead, too.


thanks,

Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Mark Brown]

On Thu, Aug 24, 2017 at 06:06:20PM +0200, Takashi Iwai wrote:

> From: Tom Rini 
> Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

Acked-by: Mark Brown 

Can you send me a pull request for -next so I can revert it with the
better fix being there please?


signature.asc
Description: PGP signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Mark Brown]

On Thu, Aug 24, 2017 at 06:06:20PM +0200, Takashi Iwai wrote:

> From: Tom Rini 
> Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

Acked-by: Mark Brown 

Can you send me a pull request for -next so I can revert it with the
better fix being there please?


signature.asc
Description: PGP signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 19:16:11 +0200,
Andy Shevchenko wrote:
> 
> On Thu, 2017-08-24 at 18:06 +0200, Takashi Iwai wrote:
> > On Thu, 24 Aug 2017 17:54:37 +0200,
> > Tom Rini wrote:
> > > 
> > > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> > > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> > > > 
> > > > > OK, so the fix for 4.13 would be either to cherry-pick this
> > > > > commit, or
> > > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick
> > > > > band-aid
> > > > > fix (and remove again in 4.14).
> > > > > The former is cleaner, but it's bigger, while the latter is a
> > > > > safer
> > > > > oneliner at the late RC stage.
> > > > > I leave the decision to Mark.
> > > > 
> > > > I'm happier with the oneline change TBH, like you say it's pretty
> > > > late
> > > > in the release cycle.  Can you just apply the patch directly and
> > > > send it
> > > > to Linus with my ack or should I put together a pull request?
> > > 
> > > FWIW, I'd be happy to give the change a quick spin and Tested-by it.
> > 
> > Well, it's your patch, after all :)
> > Below is the patch I'm going to queue.
> > 
> > 
> > Takashi
> > 
> > -- 8< --
> > From: Tom Rini 
> > Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
> > 
> > Not all devices with ACPI and this combination of sound devices will
> > have the required information provided via ACPI.  Reintroduce the I2C
> > device ID to restore sound functionality on on the Chromebook 'Samus'
> > model.
> > 
> > [ More background note:
> >  the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...")
> >  moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper
> >  acpi_device_id table.  Although the action itself is correct per se,
> >  the overseen issue is the reference id->driver_data at
> >  rt5677_i2c_probe() for retrieving the corresponding chip model for
> >  the given id.  Since id=NULL is passed for ACPI matching case, we get
> >  an Oops now.
> > 
> >  We already have queued more fixes for 4.14 and they already address
> >  the issue, but they are bigger changes that aren't preferable for the
> >  late 4.13-rc stage.  So, this patch just papers over the bug as a
> >  once-off quick fix for a particular ACPI matching.  -- tiwai ]
> > 
> > Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI
> > enumeration")
> > Signed-off-by: Tom Rini 
> > Acked-by: Mark Brown 
> > Signed-off-by: Takashi Iwai 
> 
> Thanks for this and sorry for bisectability issue. I didn't noticed it
> before Takashi got my attention to the bug report.
> 
> I'm fine with this quick fix for v4.13 only.

Good to hear.  Now I merged to for-linus branch and pushed out.

Mark, could you pull my for-linus branch into your rt5677 branch,
before Stephen grumbles on the merge conflicts?


thanks,

Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 19:16:11 +0200,
Andy Shevchenko wrote:
> 
> On Thu, 2017-08-24 at 18:06 +0200, Takashi Iwai wrote:
> > On Thu, 24 Aug 2017 17:54:37 +0200,
> > Tom Rini wrote:
> > > 
> > > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> > > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> > > > 
> > > > > OK, so the fix for 4.13 would be either to cherry-pick this
> > > > > commit, or
> > > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick
> > > > > band-aid
> > > > > fix (and remove again in 4.14).
> > > > > The former is cleaner, but it's bigger, while the latter is a
> > > > > safer
> > > > > oneliner at the late RC stage.
> > > > > I leave the decision to Mark.
> > > > 
> > > > I'm happier with the oneline change TBH, like you say it's pretty
> > > > late
> > > > in the release cycle.  Can you just apply the patch directly and
> > > > send it
> > > > to Linus with my ack or should I put together a pull request?
> > > 
> > > FWIW, I'd be happy to give the change a quick spin and Tested-by it.
> > 
> > Well, it's your patch, after all :)
> > Below is the patch I'm going to queue.
> > 
> > 
> > Takashi
> > 
> > -- 8< --
> > From: Tom Rini 
> > Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
> > 
> > Not all devices with ACPI and this combination of sound devices will
> > have the required information provided via ACPI.  Reintroduce the I2C
> > device ID to restore sound functionality on on the Chromebook 'Samus'
> > model.
> > 
> > [ More background note:
> >  the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...")
> >  moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper
> >  acpi_device_id table.  Although the action itself is correct per se,
> >  the overseen issue is the reference id->driver_data at
> >  rt5677_i2c_probe() for retrieving the corresponding chip model for
> >  the given id.  Since id=NULL is passed for ACPI matching case, we get
> >  an Oops now.
> > 
> >  We already have queued more fixes for 4.14 and they already address
> >  the issue, but they are bigger changes that aren't preferable for the
> >  late 4.13-rc stage.  So, this patch just papers over the bug as a
> >  once-off quick fix for a particular ACPI matching.  -- tiwai ]
> > 
> > Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI
> > enumeration")
> > Signed-off-by: Tom Rini 
> > Acked-by: Mark Brown 
> > Signed-off-by: Takashi Iwai 
> 
> Thanks for this and sorry for bisectability issue. I didn't noticed it
> before Takashi got my attention to the bug report.
> 
> I'm fine with this quick fix for v4.13 only.

Good to hear.  Now I merged to for-linus branch and pushed out.

Mark, could you pull my for-linus branch into your rt5677 branch,
before Stephen grumbles on the merge conflicts?


thanks,

Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Andy Shevchenko]

On Thu, 2017-08-24 at 18:06 +0200, Takashi Iwai wrote:
> On Thu, 24 Aug 2017 17:54:37 +0200,
> Tom Rini wrote:
> > 
> > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> > > 
> > > > OK, so the fix for 4.13 would be either to cherry-pick this
> > > > commit, or
> > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick
> > > > band-aid
> > > > fix (and remove again in 4.14).
> > > > The former is cleaner, but it's bigger, while the latter is a
> > > > safer
> > > > oneliner at the late RC stage.
> > > > I leave the decision to Mark.
> > > 
> > > I'm happier with the oneline change TBH, like you say it's pretty
> > > late
> > > in the release cycle.  Can you just apply the patch directly and
> > > send it
> > > to Linus with my ack or should I put together a pull request?
> > 
> > FWIW, I'd be happy to give the change a quick spin and Tested-by it.
> 
> Well, it's your patch, after all :)
> Below is the patch I'm going to queue.
> 
> 
> Takashi
> 
> -- 8< --
> From: Tom Rini 
> Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
> 
> Not all devices with ACPI and this combination of sound devices will
> have the required information provided via ACPI.  Reintroduce the I2C
> device ID to restore sound functionality on on the Chromebook 'Samus'
> model.
> 
> [ More background note:
>  the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...")
>  moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper
>  acpi_device_id table.  Although the action itself is correct per se,
>  the overseen issue is the reference id->driver_data at
>  rt5677_i2c_probe() for retrieving the corresponding chip model for
>  the given id.  Since id=NULL is passed for ACPI matching case, we get
>  an Oops now.
> 
>  We already have queued more fixes for 4.14 and they already address
>  the issue, but they are bigger changes that aren't preferable for the
>  late 4.13-rc stage.  So, this patch just papers over the bug as a
>  once-off quick fix for a particular ACPI matching.  -- tiwai ]
> 
> Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI
> enumeration")
> Signed-off-by: Tom Rini 
> Acked-by: Mark Brown 
> Signed-off-by: Takashi Iwai 

Thanks for this and sorry for bisectability issue. I didn't noticed it
before Takashi got my attention to the bug report.

I'm fine with this quick fix for v4.13 only.

> ---
>  sound/soc/codecs/rt5677.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> index 36e530a36c82..6f629278d982 100644
> --- a/sound/soc/codecs/rt5677.c
> +++ b/sound/soc/codecs/rt5677.c
> @@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap
> = {
>  static const struct i2c_device_id rt5677_i2c_id[] = {
>   { "rt5677", RT5677 },
>   { "rt5676", RT5676 },
> + { "RT5677CE:00", RT5677 },
>   { }
>  };
>  MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id);

-- 
Andy Shevchenko 
Intel Finland Oy

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Andy Shevchenko]

On Thu, 2017-08-24 at 18:06 +0200, Takashi Iwai wrote:
> On Thu, 24 Aug 2017 17:54:37 +0200,
> Tom Rini wrote:
> > 
> > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> > > 
> > > > OK, so the fix for 4.13 would be either to cherry-pick this
> > > > commit, or
> > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick
> > > > band-aid
> > > > fix (and remove again in 4.14).
> > > > The former is cleaner, but it's bigger, while the latter is a
> > > > safer
> > > > oneliner at the late RC stage.
> > > > I leave the decision to Mark.
> > > 
> > > I'm happier with the oneline change TBH, like you say it's pretty
> > > late
> > > in the release cycle.  Can you just apply the patch directly and
> > > send it
> > > to Linus with my ack or should I put together a pull request?
> > 
> > FWIW, I'd be happy to give the change a quick spin and Tested-by it.
> 
> Well, it's your patch, after all :)
> Below is the patch I'm going to queue.
> 
> 
> Takashi
> 
> -- 8< --
> From: Tom Rini 
> Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
> 
> Not all devices with ACPI and this combination of sound devices will
> have the required information provided via ACPI.  Reintroduce the I2C
> device ID to restore sound functionality on on the Chromebook 'Samus'
> model.
> 
> [ More background note:
>  the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...")
>  moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper
>  acpi_device_id table.  Although the action itself is correct per se,
>  the overseen issue is the reference id->driver_data at
>  rt5677_i2c_probe() for retrieving the corresponding chip model for
>  the given id.  Since id=NULL is passed for ACPI matching case, we get
>  an Oops now.
> 
>  We already have queued more fixes for 4.14 and they already address
>  the issue, but they are bigger changes that aren't preferable for the
>  late 4.13-rc stage.  So, this patch just papers over the bug as a
>  once-off quick fix for a particular ACPI matching.  -- tiwai ]
> 
> Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI
> enumeration")
> Signed-off-by: Tom Rini 
> Acked-by: Mark Brown 
> Signed-off-by: Takashi Iwai 

Thanks for this and sorry for bisectability issue. I didn't noticed it
before Takashi got my attention to the bug report.

I'm fine with this quick fix for v4.13 only.

> ---
>  sound/soc/codecs/rt5677.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> index 36e530a36c82..6f629278d982 100644
> --- a/sound/soc/codecs/rt5677.c
> +++ b/sound/soc/codecs/rt5677.c
> @@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap
> = {
>  static const struct i2c_device_id rt5677_i2c_id[] = {
>   { "rt5677", RT5677 },
>   { "rt5676", RT5676 },
> + { "RT5677CE:00", RT5677 },
>   { }
>  };
>  MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id);

-- 
Andy Shevchenko 
Intel Finland Oy

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Tom Rini]

On Thu, Aug 24, 2017 at 06:06:20PM +0200, Takashi Iwai wrote:
> On Thu, 24 Aug 2017 17:54:37 +0200,
> Tom Rini wrote:
> > 
> > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> > > 
> > > > OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> > > > fix (and remove again in 4.14).
> > > 
> > > > The former is cleaner, but it's bigger, while the latter is a safer
> > > > oneliner at the late RC stage.
> > > 
> > > > I leave the decision to Mark.
> > > 
> > > I'm happier with the oneline change TBH, like you say it's pretty late
> > > in the release cycle.  Can you just apply the patch directly and send it
> > > to Linus with my ack or should I put together a pull request?
> > 
> > FWIW, I'd be happy to give the change a quick spin and Tested-by it.
> 
> Well, it's your patch, after all :)
> Below is the patch I'm going to queue.
> 
> 
> Takashi
> 
> -- 8< --
> From: Tom Rini 
> Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
> 
> Not all devices with ACPI and this combination of sound devices will
> have the required information provided via ACPI.  Reintroduce the I2C
> device ID to restore sound functionality on on the Chromebook 'Samus'
> model.
> 
> [ More background note:
>  the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...")
>  moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper
>  acpi_device_id table.  Although the action itself is correct per se,
>  the overseen issue is the reference id->driver_data at
>  rt5677_i2c_probe() for retrieving the corresponding chip model for
>  the given id.  Since id=NULL is passed for ACPI matching case, we get
>  an Oops now.
> 
>  We already have queued more fixes for 4.14 and they already address
>  the issue, but they are bigger changes that aren't preferable for the
>  late 4.13-rc stage.  So, this patch just papers over the bug as a
>  once-off quick fix for a particular ACPI matching.  -- tiwai ]
> 
> Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI 
> enumeration")
> Signed-off-by: Tom Rini 
> Acked-by: Mark Brown 
> Signed-off-by: Takashi Iwai 
> ---
>  sound/soc/codecs/rt5677.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> index 36e530a36c82..6f629278d982 100644
> --- a/sound/soc/codecs/rt5677.c
> +++ b/sound/soc/codecs/rt5677.c
> @@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap = {
>  static const struct i2c_device_id rt5677_i2c_id[] = {
>   { "rt5677", RT5677 },
>   { "rt5676", RT5676 },
> + { "RT5677CE:00", RT5677 },
>   { }
>  };
>  MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id);

Looks good, thanks for rewording things!

-- 
Tom


signature.asc
Description: Digital signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Tom Rini]

On Thu, Aug 24, 2017 at 06:06:20PM +0200, Takashi Iwai wrote:
> On Thu, 24 Aug 2017 17:54:37 +0200,
> Tom Rini wrote:
> > 
> > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> > > 
> > > > OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> > > > fix (and remove again in 4.14).
> > > 
> > > > The former is cleaner, but it's bigger, while the latter is a safer
> > > > oneliner at the late RC stage.
> > > 
> > > > I leave the decision to Mark.
> > > 
> > > I'm happier with the oneline change TBH, like you say it's pretty late
> > > in the release cycle.  Can you just apply the patch directly and send it
> > > to Linus with my ack or should I put together a pull request?
> > 
> > FWIW, I'd be happy to give the change a quick spin and Tested-by it.
> 
> Well, it's your patch, after all :)
> Below is the patch I'm going to queue.
> 
> 
> Takashi
> 
> -- 8< --
> From: Tom Rini 
> Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
> 
> Not all devices with ACPI and this combination of sound devices will
> have the required information provided via ACPI.  Reintroduce the I2C
> device ID to restore sound functionality on on the Chromebook 'Samus'
> model.
> 
> [ More background note:
>  the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...")
>  moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper
>  acpi_device_id table.  Although the action itself is correct per se,
>  the overseen issue is the reference id->driver_data at
>  rt5677_i2c_probe() for retrieving the corresponding chip model for
>  the given id.  Since id=NULL is passed for ACPI matching case, we get
>  an Oops now.
> 
>  We already have queued more fixes for 4.14 and they already address
>  the issue, but they are bigger changes that aren't preferable for the
>  late 4.13-rc stage.  So, this patch just papers over the bug as a
>  once-off quick fix for a particular ACPI matching.  -- tiwai ]
> 
> Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI 
> enumeration")
> Signed-off-by: Tom Rini 
> Acked-by: Mark Brown 
> Signed-off-by: Takashi Iwai 
> ---
>  sound/soc/codecs/rt5677.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> index 36e530a36c82..6f629278d982 100644
> --- a/sound/soc/codecs/rt5677.c
> +++ b/sound/soc/codecs/rt5677.c
> @@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap = {
>  static const struct i2c_device_id rt5677_i2c_id[] = {
>   { "rt5677", RT5677 },
>   { "rt5676", RT5676 },
> + { "RT5677CE:00", RT5677 },
>   { }
>  };
>  MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id);

Looks good, thanks for rewording things!

-- 
Tom


signature.asc
Description: Digital signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 17:54:37 +0200,
Tom Rini wrote:
> 
> On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> > 
> > > OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> > > fix (and remove again in 4.14).
> > 
> > > The former is cleaner, but it's bigger, while the latter is a safer
> > > oneliner at the late RC stage.
> > 
> > > I leave the decision to Mark.
> > 
> > I'm happier with the oneline change TBH, like you say it's pretty late
> > in the release cycle.  Can you just apply the patch directly and send it
> > to Linus with my ack or should I put together a pull request?
> 
> FWIW, I'd be happy to give the change a quick spin and Tested-by it.

Well, it's your patch, after all :)
Below is the patch I'm going to queue.


Takashi

-- 8< --
From: Tom Rini 
Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

Not all devices with ACPI and this combination of sound devices will
have the required information provided via ACPI.  Reintroduce the I2C
device ID to restore sound functionality on on the Chromebook 'Samus'
model.

[ More background note:
 the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...")
 moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper
 acpi_device_id table.  Although the action itself is correct per se,
 the overseen issue is the reference id->driver_data at
 rt5677_i2c_probe() for retrieving the corresponding chip model for
 the given id.  Since id=NULL is passed for ACPI matching case, we get
 an Oops now.

 We already have queued more fixes for 4.14 and they already address
 the issue, but they are bigger changes that aren't preferable for the
 late 4.13-rc stage.  So, this patch just papers over the bug as a
 once-off quick fix for a particular ACPI matching.  -- tiwai ]

Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI 
enumeration")
Signed-off-by: Tom Rini 
Acked-by: Mark Brown 
Signed-off-by: Takashi Iwai 
---
 sound/soc/codecs/rt5677.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 36e530a36c82..6f629278d982 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap = {
 static const struct i2c_device_id rt5677_i2c_id[] = {
{ "rt5677", RT5677 },
{ "rt5676", RT5676 },
+   { "RT5677CE:00", RT5677 },
{ }
 };
 MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id);
-- 
2.14.0

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 17:54:37 +0200,
Tom Rini wrote:
> 
> On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> > 
> > > OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> > > fix (and remove again in 4.14).
> > 
> > > The former is cleaner, but it's bigger, while the latter is a safer
> > > oneliner at the late RC stage.
> > 
> > > I leave the decision to Mark.
> > 
> > I'm happier with the oneline change TBH, like you say it's pretty late
> > in the release cycle.  Can you just apply the patch directly and send it
> > to Linus with my ack or should I put together a pull request?
> 
> FWIW, I'd be happy to give the change a quick spin and Tested-by it.

Well, it's your patch, after all :)
Below is the patch I'm going to queue.


Takashi

-- 8< --
From: Tom Rini 
Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

Not all devices with ACPI and this combination of sound devices will
have the required information provided via ACPI.  Reintroduce the I2C
device ID to restore sound functionality on on the Chromebook 'Samus'
model.

[ More background note:
 the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...")
 moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper
 acpi_device_id table.  Although the action itself is correct per se,
 the overseen issue is the reference id->driver_data at
 rt5677_i2c_probe() for retrieving the corresponding chip model for
 the given id.  Since id=NULL is passed for ACPI matching case, we get
 an Oops now.

 We already have queued more fixes for 4.14 and they already address
 the issue, but they are bigger changes that aren't preferable for the
 late 4.13-rc stage.  So, this patch just papers over the bug as a
 once-off quick fix for a particular ACPI matching.  -- tiwai ]

Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI 
enumeration")
Signed-off-by: Tom Rini 
Acked-by: Mark Brown 
Signed-off-by: Takashi Iwai 
---
 sound/soc/codecs/rt5677.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 36e530a36c82..6f629278d982 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap = {
 static const struct i2c_device_id rt5677_i2c_id[] = {
{ "rt5677", RT5677 },
{ "rt5676", RT5676 },
+   { "RT5677CE:00", RT5677 },
{ }
 };
 MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id);
-- 
2.14.0

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Tom Rini]

On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> 
> > OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> > fix (and remove again in 4.14).
> 
> > The former is cleaner, but it's bigger, while the latter is a safer
> > oneliner at the late RC stage.
> 
> > I leave the decision to Mark.
> 
> I'm happier with the oneline change TBH, like you say it's pretty late
> in the release cycle.  Can you just apply the patch directly and send it
> to Linus with my ack or should I put together a pull request?

FWIW, I'd be happy to give the change a quick spin and Tested-by it.

-- 
Tom


signature.asc
Description: Digital signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Tom Rini]

On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote:
> On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> 
> > OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> > fix (and remove again in 4.14).
> 
> > The former is cleaner, but it's bigger, while the latter is a safer
> > oneliner at the late RC stage.
> 
> > I leave the decision to Mark.
> 
> I'm happier with the oneline change TBH, like you say it's pretty late
> in the release cycle.  Can you just apply the patch directly and send it
> to Linus with my ack or should I put together a pull request?

FWIW, I'd be happy to give the change a quick spin and Tested-by it.

-- 
Tom


signature.asc
Description: Digital signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 17:52:35 +0200,
Mark Brown wrote:
> 
> On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> 
> > OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> > fix (and remove again in 4.14).
> 
> > The former is cleaner, but it's bigger, while the latter is a safer
> > oneliner at the late RC stage.
> 
> > I leave the decision to Mark.
> 
> I'm happier with the oneline change TBH, like you say it's pretty late
> in the release cycle.  Can you just apply the patch directly and send it
> to Linus with my ack or should I put together a pull request?

OK, no problem, I'll add Tom's patch with a bit more explanations.


Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 17:52:35 +0200,
Mark Brown wrote:
> 
> On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> 
> > OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> > fix (and remove again in 4.14).
> 
> > The former is cleaner, but it's bigger, while the latter is a safer
> > oneliner at the late RC stage.
> 
> > I leave the decision to Mark.
> 
> I'm happier with the oneline change TBH, like you say it's pretty late
> in the release cycle.  Can you just apply the patch directly and send it
> to Linus with my ack or should I put together a pull request?

OK, no problem, I'll add Tom's patch with a bit more explanations.


Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Mark Brown]

On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:

> OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> fix (and remove again in 4.14).

> The former is cleaner, but it's bigger, while the latter is a safer
> oneliner at the late RC stage.

> I leave the decision to Mark.

I'm happier with the oneline change TBH, like you say it's pretty late
in the release cycle.  Can you just apply the patch directly and send it
to Linus with my ack or should I put together a pull request?


signature.asc
Description: PGP signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Mark Brown]

On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:

> OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> fix (and remove again in 4.14).

> The former is cleaner, but it's bigger, while the latter is a safer
> oneliner at the late RC stage.

> I leave the decision to Mark.

I'm happier with the oneline change TBH, like you say it's pretty late
in the release cycle.  Can you just apply the patch directly and send it
to Linus with my ack or should I put together a pull request?


signature.asc
Description: PGP signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 16:41:52 +0200,
Tom Rini wrote:
> 
> On Thu, Aug 24, 2017 at 04:31:25PM +0200, Takashi Iwai wrote:
> > On Thu, 24 Aug 2017 16:28:29 +0200,
> > Takashi Iwai wrote:
> > > 
> > > On Thu, 24 Aug 2017 02:05:25 +0200,
> > > Tom Rini wrote:
> > > > 
> > > > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > > > 
> > > > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > > > > Not all devices with ACPI and this combination of sound devices 
> > > > > > > will
> > > > > > > have the required information provided via ACPI.  Reintroduce the 
> > > > > > > I2C
> > > > > > > device ID to restore sound functionality on on the Chromebook 
> > > > > > > 'Samus'
> > > > > > > model.
> > > > > > 
> > > > > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > > > > that's not running ChromeOS).  My fault for getting out of the 
> > > > > > > habit
> > > > > > > of
> > > > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm 
> > > > > > > not
> > > > > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > > > > test
> > > > > > > my hardware here, and this does fix my laptop.
> > > > > > 
> > > > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform 
> > > > > > data
> > > > > > in the module sources") does not fix your issue?
> > > > > 
> > > > > As that's not in master yet I can't tell.  Can you give me a pointer 
> > > > > to
> > > > > somewhere?  Thanks!
> > > > 
> > > > OK, my bad, it has a different hash upstream,
> > 
> > BTW, the hash above is correct.  It's in Mark's asoc tree (and in
> > linux-next).  You might have cherry-picked a wrong one, I suppose?
> 
> Alright, I read-things to quickly, and to be clear:
> (a) "ASoC: rt5677: Hide platform data in the module sources" is _not_ in
> Linus' tree (I confused this with a different commit) and _is_ in Mark's
> ASoC for-next branch currently.
> (b) Applying just that patch on top of Linus' tree _does_ fix my
> regression (an Oops and non-functional audio) with audio and now sound
> works well, as expected.
> 
> Can we please get that as a fix for this release?  Thanks!

OK, so the fix for 4.13 would be either to cherry-pick this commit, or
just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
fix (and remove again in 4.14).

The former is cleaner, but it's bigger, while the latter is a safer
oneliner at the late RC stage.

I leave the decision to Mark.


Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 16:41:52 +0200,
Tom Rini wrote:
> 
> On Thu, Aug 24, 2017 at 04:31:25PM +0200, Takashi Iwai wrote:
> > On Thu, 24 Aug 2017 16:28:29 +0200,
> > Takashi Iwai wrote:
> > > 
> > > On Thu, 24 Aug 2017 02:05:25 +0200,
> > > Tom Rini wrote:
> > > > 
> > > > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > > > 
> > > > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > > > > Not all devices with ACPI and this combination of sound devices 
> > > > > > > will
> > > > > > > have the required information provided via ACPI.  Reintroduce the 
> > > > > > > I2C
> > > > > > > device ID to restore sound functionality on on the Chromebook 
> > > > > > > 'Samus'
> > > > > > > model.
> > > > > > 
> > > > > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > > > > that's not running ChromeOS).  My fault for getting out of the 
> > > > > > > habit
> > > > > > > of
> > > > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm 
> > > > > > > not
> > > > > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > > > > test
> > > > > > > my hardware here, and this does fix my laptop.
> > > > > > 
> > > > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform 
> > > > > > data
> > > > > > in the module sources") does not fix your issue?
> > > > > 
> > > > > As that's not in master yet I can't tell.  Can you give me a pointer 
> > > > > to
> > > > > somewhere?  Thanks!
> > > > 
> > > > OK, my bad, it has a different hash upstream,
> > 
> > BTW, the hash above is correct.  It's in Mark's asoc tree (and in
> > linux-next).  You might have cherry-picked a wrong one, I suppose?
> 
> Alright, I read-things to quickly, and to be clear:
> (a) "ASoC: rt5677: Hide platform data in the module sources" is _not_ in
> Linus' tree (I confused this with a different commit) and _is_ in Mark's
> ASoC for-next branch currently.
> (b) Applying just that patch on top of Linus' tree _does_ fix my
> regression (an Oops and non-functional audio) with audio and now sound
> works well, as expected.
> 
> Can we please get that as a fix for this release?  Thanks!

OK, so the fix for 4.13 would be either to cherry-pick this commit, or
just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
fix (and remove again in 4.14).

The former is cleaner, but it's bigger, while the latter is a safer
oneliner at the late RC stage.

I leave the decision to Mark.


Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Tom Rini]

On Thu, Aug 24, 2017 at 04:31:25PM +0200, Takashi Iwai wrote:
> On Thu, 24 Aug 2017 16:28:29 +0200,
> Takashi Iwai wrote:
> > 
> > On Thu, 24 Aug 2017 02:05:25 +0200,
> > Tom Rini wrote:
> > > 
> > > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > > 
> > > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > > > Not all devices with ACPI and this combination of sound devices will
> > > > > > have the required information provided via ACPI.  Reintroduce the 
> > > > > > I2C
> > > > > > device ID to restore sound functionality on on the Chromebook 
> > > > > > 'Samus'
> > > > > > model.
> > > > > 
> > > > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > > > that's not running ChromeOS).  My fault for getting out of the habit
> > > > > > of
> > > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm not
> > > > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > > > test
> > > > > > my hardware here, and this does fix my laptop.
> > > > > 
> > > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform 
> > > > > data
> > > > > in the module sources") does not fix your issue?
> > > > 
> > > > As that's not in master yet I can't tell.  Can you give me a pointer to
> > > > somewhere?  Thanks!
> > > 
> > > OK, my bad, it has a different hash upstream,
> 
> BTW, the hash above is correct.  It's in Mark's asoc tree (and in
> linux-next).  You might have cherry-picked a wrong one, I suppose?

Alright, I read-things to quickly, and to be clear:
(a) "ASoC: rt5677: Hide platform data in the module sources" is _not_ in
Linus' tree (I confused this with a different commit) and _is_ in Mark's
ASoC for-next branch currently.
(b) Applying just that patch on top of Linus' tree _does_ fix my
regression (an Oops and non-functional audio) with audio and now sound
works well, as expected.

Can we please get that as a fix for this release?  Thanks!

-- 
Tom


signature.asc
Description: Digital signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Tom Rini]

On Thu, Aug 24, 2017 at 04:31:25PM +0200, Takashi Iwai wrote:
> On Thu, 24 Aug 2017 16:28:29 +0200,
> Takashi Iwai wrote:
> > 
> > On Thu, 24 Aug 2017 02:05:25 +0200,
> > Tom Rini wrote:
> > > 
> > > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > > 
> > > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > > > Not all devices with ACPI and this combination of sound devices will
> > > > > > have the required information provided via ACPI.  Reintroduce the 
> > > > > > I2C
> > > > > > device ID to restore sound functionality on on the Chromebook 
> > > > > > 'Samus'
> > > > > > model.
> > > > > 
> > > > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > > > that's not running ChromeOS).  My fault for getting out of the habit
> > > > > > of
> > > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm not
> > > > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > > > test
> > > > > > my hardware here, and this does fix my laptop.
> > > > > 
> > > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform 
> > > > > data
> > > > > in the module sources") does not fix your issue?
> > > > 
> > > > As that's not in master yet I can't tell.  Can you give me a pointer to
> > > > somewhere?  Thanks!
> > > 
> > > OK, my bad, it has a different hash upstream,
> 
> BTW, the hash above is correct.  It's in Mark's asoc tree (and in
> linux-next).  You might have cherry-picked a wrong one, I suppose?

Alright, I read-things to quickly, and to be clear:
(a) "ASoC: rt5677: Hide platform data in the module sources" is _not_ in
Linus' tree (I confused this with a different commit) and _is_ in Mark's
ASoC for-next branch currently.
(b) Applying just that patch on top of Linus' tree _does_ fix my
regression (an Oops and non-functional audio) with audio and now sound
works well, as expected.

Can we please get that as a fix for this release?  Thanks!

-- 
Tom


signature.asc
Description: Digital signature

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 16:28:29 +0200,
Takashi Iwai wrote:
> 
> On Thu, 24 Aug 2017 02:05:25 +0200,
> Tom Rini wrote:
> > 
> > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > 
> > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > > Not all devices with ACPI and this combination of sound devices will
> > > > > have the required information provided via ACPI.  Reintroduce the I2C
> > > > > device ID to restore sound functionality on on the Chromebook 'Samus'
> > > > > model.
> > > > 
> > > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > > that's not running ChromeOS).  My fault for getting out of the habit
> > > > > of
> > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm not
> > > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > > test
> > > > > my hardware here, and this does fix my laptop.
> > > > 
> > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data
> > > > in the module sources") does not fix your issue?
> > > 
> > > As that's not in master yet I can't tell.  Can you give me a pointer to
> > > somewhere?  Thanks!
> > 
> > OK, my bad, it has a different hash upstream,

BTW, the hash above is correct.  It's in Mark's asoc tree (and in
linux-next).  You might have cherry-picked a wrong one, I suppose?


Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 16:28:29 +0200,
Takashi Iwai wrote:
> 
> On Thu, 24 Aug 2017 02:05:25 +0200,
> Tom Rini wrote:
> > 
> > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > 
> > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > > Not all devices with ACPI and this combination of sound devices will
> > > > > have the required information provided via ACPI.  Reintroduce the I2C
> > > > > device ID to restore sound functionality on on the Chromebook 'Samus'
> > > > > model.
> > > > 
> > > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > > that's not running ChromeOS).  My fault for getting out of the habit
> > > > > of
> > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm not
> > > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > > test
> > > > > my hardware here, and this does fix my laptop.
> > > > 
> > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data
> > > > in the module sources") does not fix your issue?
> > > 
> > > As that's not in master yet I can't tell.  Can you give me a pointer to
> > > somewhere?  Thanks!
> > 
> > OK, my bad, it has a different hash upstream,

BTW, the hash above is correct.  It's in Mark's asoc tree (and in
linux-next).  You might have cherry-picked a wrong one, I suppose?


Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 02:05:25 +0200,
Tom Rini wrote:
> 
> On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > 
> > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > Not all devices with ACPI and this combination of sound devices will
> > > > have the required information provided via ACPI.  Reintroduce the I2C
> > > > device ID to restore sound functionality on on the Chromebook 'Samus'
> > > > model.
> > > 
> > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > that's not running ChromeOS).  My fault for getting out of the habit
> > > > of
> > > > trying -rc1 when it comes out and not spotting this sooner.  I'm not
> > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > test
> > > > my hardware here, and this does fix my laptop.
> > > 
> > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data
> > > in the module sources") does not fix your issue?
> > 
> > As that's not in master yet I can't tell.  Can you give me a pointer to
> > somewhere?  Thanks!
> 
> OK, my bad, it has a different hash upstream, but no, that change
> doesn't fix things as I see the problem on top of Linus' tree.  Thanks!

Could you double-check?  Your Oops likely comes from the NULL
id->driver_type reference that is removed by the commit ddc9e69b9dc2.

If you still get an Oops, we need to decode it properly now to
understand what's going on.


thanks,

Takashi

Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Takashi Iwai]

On Thu, 24 Aug 2017 02:05:25 +0200,
Tom Rini wrote:
> 
> On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > 
> > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > Not all devices with ACPI and this combination of sound devices will
> > > > have the required information provided via ACPI.  Reintroduce the I2C
> > > > device ID to restore sound functionality on on the Chromebook 'Samus'
> > > > model.
> > > 
> > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > that's not running ChromeOS).  My fault for getting out of the habit
> > > > of
> > > > trying -rc1 when it comes out and not spotting this sooner.  I'm not
> > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > test
> > > > my hardware here, and this does fix my laptop.
> > > 
> > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data
> > > in the module sources") does not fix your issue?
> > 
> > As that's not in master yet I can't tell.  Can you give me a pointer to
> > somewhere?  Thanks!
> 
> OK, my bad, it has a different hash upstream, but no, that change
> doesn't fix things as I see the problem on top of Linus' tree.  Thanks!

Could you double-check?  Your Oops likely comes from the NULL
id->driver_type reference that is removed by the commit ddc9e69b9dc2.

If you still get an Oops, we need to decode it properly now to
understand what's going on.


thanks,

Takashi