Re: [git pull] New firewire stack (updated)

2007-05-10 Thread Stefan Richter
Christoph Hellwig wrote:
> ACK from me.  I still have some comments but none of them is a merge
> blocker.

I put one small fix that Kristian sent on hold (const char * vs char *
for shostt->proc_name) to let a related patch go to scsi-misc first.
So this open item is my fault, not his. :-)
-- 
Stefan Richter
-=-=-=== -=-= -=-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [git pull] New firewire stack (updated)

2007-05-10 Thread Stefan Richter
Christoph Hellwig wrote:
> On Thu, May 10, 2007 at 07:26:56PM +0200, Stefan Richter wrote:
>>   - The drivers still live in drivers/firewire/, i.e. have not been put
>> into mainline's drivers/ieee1394/.
> 
> I don't quite like that.  Then again git handles renames pretty nicely
> and I hope we'll just shift the new drivers in place when the old code
> goes away completely to give people a seamless migration.

There were some comments in this and past reviews pro and contra the
directory split.  For me, it was easier to deal with patch handling that
way since the stack went into -mm, but once the stack is in Linus' tree,
my work will probably be easier anyway.
-- 
Stefan Richter
-=-=-=== -=-= -=-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [git pull] New firewire stack (updated)

2007-05-10 Thread Adrian Bunk
On Thu, May 10, 2007 at 06:38:50PM +0100, Christoph Hellwig wrote:
> On Thu, May 10, 2007 at 07:26:56PM +0200, Stefan Richter wrote:
> > Linus, please pull from the juju branch at
> > 
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git 
> > juju
> > 
> 
> ACK from me.  I still have some comments but none of them is a merge
> blocker.
> 
> > What did _not_ change:
> > 
> >   - The drivers are still named fw-core, fw-ohci, fw-sbp2 (but they
> > feature conditional aliases sbp2 and ohci1394 now).  Adrian
> > suggested the prefix firewire- instead of fw-.
> > 
> >   - The drivers still live in drivers/firewire/, i.e. have not been put
> > into mainline's drivers/ieee1394/.
> 
> I don't quite like that.  Then again git handles renames pretty nicely
> and I hope we'll just shift the new drivers in place when the old code
> goes away completely to give people a seamless migration.

For users it shouldn't matter where the code is located in the kernel 
sources (and "firewire" is IMHO for many people more meaningful than 
"ieee1394").

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [git pull] New firewire stack (updated)

2007-05-10 Thread Christoph Hellwig
On Thu, May 10, 2007 at 07:26:56PM +0200, Stefan Richter wrote:
> Linus, please pull from the juju branch at
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git 
> juju
> 

ACK from me.  I still have some comments but none of them is a merge
blocker.

> What did _not_ change:
> 
>   - The drivers are still named fw-core, fw-ohci, fw-sbp2 (but they
> feature conditional aliases sbp2 and ohci1394 now).  Adrian
> suggested the prefix firewire- instead of fw-.
> 
>   - The drivers still live in drivers/firewire/, i.e. have not been put
> into mainline's drivers/ieee1394/.

I don't quite like that.  Then again git handles renames pretty nicely
and I hope we'll just shift the new drivers in place when the old code
goes away completely to give people a seamless migration.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[git pull] New firewire stack (updated)

2007-05-10 Thread Stefan Richter
Linus, please pull from the juju branch at

git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git 
juju

to receive the new, alternative IEEE 1394 subsystem ( --- unless you
consider it too close to the end of the merge window now or have other
reservations...).

Many thanks to all who reviewed the submission from May 1st.  Your work
is of great help and is very much appreciated.

What changed since last submission:

Ivo van Doorn (1):
  CRC ITU-T V.41

Kristian Høgsberg (14):
  firewire: Use lib/ implementation of CRC ITU-T.
  firewire: Clean up comment style.
  firewire: Convert card_rwsem to a regular mutex.
  firewire: Coding style cleanup: no spaces after function names.
  firewire: Uppercase most macro names.
  firewire: Use linux/*.h instead of asm/*.h header files.
  firewire: Break out shared IEEE1394 constant to separate header file.
  firewire: Add to fw-core-y instead of assigning fw-core-objs in Makefile.
  firewire: Allocate scsi_host up front and allocate the sbp2_device as 
hostdata.
  firewire: Handle the last few DMA mapping error cases.
  firewire: Return SCSI_MLQUEUE_HOST_BUSY for out of memory cases in 
queuecommand.
  firewire: Drop single buffer request support.
  firewire: Always use parens with sizeof.
  firewire: Convert OHCI driver to use standard goto unwinding for error 
handling.

Kristian Høgsberg, Stefan Richter (1):
  firewire: Add a comment to describe why we split the sg list.

Olaf Hering (1):
  firewire: Provide module aliase for backwards compatibility.

What did _not_ change:

  - The drivers are still named fw-core, fw-ohci, fw-sbp2 (but they
feature conditional aliases sbp2 and ohci1394 now).  Adrian
suggested the prefix firewire- instead of fw-.

  - The drivers still live in drivers/firewire/, i.e. have not been put
into mainline's drivers/ieee1394/.

As mentioned in the previous submission, the main item that is still to
do regarding the new codebase is to bring over IP over 1394, currently
known as eth1394.  But the biggest task is certainly to come up with a
transition schedule for the removal of the existing stack.  IMO,
exposure of the new stack at this time will enable the community of IEEE
1394 developers and users to provide us with the necessary feedback to
tackle that schedule.

To rehash the reasons to undertake this transition:

  + Considerably leaner codebase,

  + cleaned-up and improved in-stack APIs
(with the side effect of getting rid of a bunch of old bugs),

  + consolidation of the currently four userspace ABIs into one improved
ABI (which is already supported by the two FireWire low-level
libraries libraw1394 and libdc1394),

  + improved host security and device security.

As noted, linux1394-2.6.git's juju branch is based on 2.6.21-rc3.  I can
rebase it onto 2.6.21 or current git if you wish.  The juju branch
contains a linear series of now 138 commits:

Adrian Bunk (1)
Andrew Morton (4)
Ivo van Doorn (1)
Kristian Høgsberg (106)
Marc Butler (1)
Olaf Hering (1)
Randy Dunlap (1)
Stefan Richter (22)
Thomas Gleixner (1)

 drivers/Makefile   |1 +
 drivers/firewire/Kconfig   |   61 ++
 drivers/firewire/Makefile  |   10 +
 drivers/firewire/fw-card.c |  560 +++
 drivers/firewire/fw-cdev.c |  961 ++
 drivers/firewire/fw-device.c   |  813 +++
 drivers/firewire/fw-device.h   |  146 +++
 drivers/firewire/fw-iso.c  |  163 +++
 drivers/firewire/fw-ohci.c | 1943 
 drivers/firewire/fw-ohci.h |  153 +++
 drivers/firewire/fw-sbp2.c | 1147 +
 drivers/firewire/fw-topology.c |  537 ++
 drivers/firewire/fw-topology.h |   92 ++
 drivers/firewire/fw-transaction.c  |  910 +
 drivers/firewire/fw-transaction.h  |  458 +
 drivers/ieee1394/Kconfig   |2 +
 include/linux/crc-itu-t.h  |   28 +
 include/linux/firewire-cdev.h  |  229 +
 include/linux/firewire-constants.h |   67 ++
 lib/Kconfig|8 +
 lib/Makefile   |1 +
 lib/crc-itu-t.c|   69 ++
 22 files changed, 8359 insertions(+), 0 deletions(-)
 create mode 100644 drivers/firewire/Kconfig
 create mode 100644 drivers/firewire/Makefile
 create mode 100644 drivers/firewire/fw-card.c
 create mode 100644 drivers/firewire/fw-cdev.c
 create mode 100644 drivers/firewire/fw-device.c
 create mode 100644 drivers/firewire/fw-device.h
 create mode 100644 drivers/firewire/fw-iso.c
 create mode 100644 drivers/firewire/fw-ohci.c
 create mode 100644 drivers/firewire/fw-ohci.h
 create mode 100644 drivers/firewire/fw-sbp2.c
 create mode 100644 drivers/firewire/fw-topology.c
 create mode 100644 drivers/firewire/fw-topology.h
 create mode 100644 drivers/firewire/fw-transaction.c
 create mode 100644 drivers/firew