Re: [kernel-hardening] [PATCH 3/5] Protectable Memory Allocator - Debug interface

2017-06-06 Thread Igor Stoppa 


On 05/06/17 23:24, Jann Horn wrote:
> On Mon, Jun 5, 2017 at 9:22 PM, Igor Stoppa  wrote:
>> Debugfs interface: it creates a file

[...]

> You should probably be using %pK to hide the kernel pointers.

ok, will do

---
igor

Re: [kernel-hardening] [PATCH 3/5] Protectable Memory Allocator - Debug interface

2017-06-06 Thread Igor Stoppa 


On 05/06/17 23:24, Jann Horn wrote:
> On Mon, Jun 5, 2017 at 9:22 PM, Igor Stoppa  wrote:
>> Debugfs interface: it creates a file

[...]

> You should probably be using %pK to hide the kernel pointers.

ok, will do

---
igor

Re: [kernel-hardening] [PATCH 3/5] Protectable Memory Allocator - Debug interface

2017-06-05 Thread Jann Horn 
On Mon, Jun 5, 2017 at 9:22 PM, Igor Stoppa  wrote:
> Debugfs interface: it creates a file
>
> /sys/kernel/debug/pmalloc/pools
>
> which exposes statistics about all the pools and memory nodes in use.
>
> Signed-off-by: Igor Stoppa 
[...]
> +   seq_printf(s, " - node:\t\t%p\n", node);
> +   seq_printf(s, "   - start of data ptr:\t%p\n", node->data);
> +   seq_printf(s, "   - end of node ptr:\t%p\n", (void *)end_of_node);
[...]
> +   seq_printf(s, "pool:\t\t\t%p\n", pool);
[...]
> +   debugfs_create_file("pools", 0644, pmalloc_root, NULL,
> +   _file_ops);

You should probably be using %pK to hide the kernel pointers.

Re: [kernel-hardening] [PATCH 3/5] Protectable Memory Allocator - Debug interface

2017-06-05 Thread Jann Horn 
On Mon, Jun 5, 2017 at 9:22 PM, Igor Stoppa  wrote:
> Debugfs interface: it creates a file
>
> /sys/kernel/debug/pmalloc/pools
>
> which exposes statistics about all the pools and memory nodes in use.
>
> Signed-off-by: Igor Stoppa 
[...]
> +   seq_printf(s, " - node:\t\t%p\n", node);
> +   seq_printf(s, "   - start of data ptr:\t%p\n", node->data);
> +   seq_printf(s, "   - end of node ptr:\t%p\n", (void *)end_of_node);
[...]
> +   seq_printf(s, "pool:\t\t\t%p\n", pool);
[...]
> +   debugfs_create_file("pools", 0644, pmalloc_root, NULL,
> +   _file_ops);

You should probably be using %pK to hide the kernel pointers.