Re: [kvm-devel] [GIT PULL][RESEND] Late KVM Updates for the 2.6.23 merge window

2007-07-21 Thread Avi Kivity
Linus Torvalds wrote:
> On Sat, 21 Jul 2007, S.Çağlar Onur wrote:
>   
>> With Linus's latest git, shutting down a guest (fired with -smp 2 -m 512) 
>> sometimes 
>> ends up like [1], this occured as soon as qemu window closed.
>>
>> [1] http://cekirdek.pardus.org.tr/~caglar/kvm/dmesg.latest
>> 
>
> [  737.460654] Bad page state in process 'qemu-kvm'
> [  737.460656] page:f5e68000 flags:0xea02 mapping: mapcount:2 
> count:0
> [  737.460657] Trying to fix it up, but a reboot is needed
> [  737.460659] Backtrace:
> [  737.460691]  [] bad_page+0x64/0x8e
> [  737.460733]  [] free_hot_cold_page+0x68/0x15a
>
> That's the "free_pages_check()", and in particular it seems to be 
> "page_mapcount()" being non-zero that triggered that thing.
>
> So it looks like something in KVM isn't coherent about the mapping vs the 
> usage counters..
>
>   

Far more prosaic.  It calls __free_page() on the cleanup path with the
page's virtual address instead of the struct page.  I guess
__free_page() is happy with a zeroed out blob, which is the most likely
contents.

Trivial patch shortly.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [kvm-devel] [GIT PULL][RESEND] Late KVM Updates for the 2.6.23 merge window

2007-07-21 Thread Avi Kivity
Linus Torvalds wrote:
 On Sat, 21 Jul 2007, S.Çağlar Onur wrote:
   
 With Linus's latest git, shutting down a guest (fired with -smp 2 -m 512) 
 sometimes 
 ends up like [1], this occured as soon as qemu window closed.

 [1] http://cekirdek.pardus.org.tr/~caglar/kvm/dmesg.latest
 

 [  737.460654] Bad page state in process 'qemu-kvm'
 [  737.460656] page:f5e68000 flags:0xea02 mapping: mapcount:2 
 count:0
 [  737.460657] Trying to fix it up, but a reboot is needed
 [  737.460659] Backtrace:
 [  737.460691]  [c0159e70] bad_page+0x64/0x8e
 [  737.460733]  [c015a7ee] free_hot_cold_page+0x68/0x15a

 That's the free_pages_check(), and in particular it seems to be 
 page_mapcount() being non-zero that triggered that thing.

 So it looks like something in KVM isn't coherent about the mapping vs the 
 usage counters..

   

Far more prosaic.  It calls __free_page() on the cleanup path with the
page's virtual address instead of the struct page.  I guess
__free_page() is happy with a zeroed out blob, which is the most likely
contents.

Trivial patch shortly.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [kvm-devel] [GIT PULL][RESEND] Late KVM Updates for the 2.6.23 merge window

2007-07-20 Thread Linus Torvalds


On Sat, 21 Jul 2007, S.Çağlar Onur wrote:
> 
> With Linus's latest git, shutting down a guest (fired with -smp 2 -m 512) 
> sometimes 
> ends up like [1], this occured as soon as qemu window closed.
> 
> [1] http://cekirdek.pardus.org.tr/~caglar/kvm/dmesg.latest

[  737.460654] Bad page state in process 'qemu-kvm'
[  737.460656] page:f5e68000 flags:0xea02 mapping: mapcount:2 
count:0
[  737.460657] Trying to fix it up, but a reboot is needed
[  737.460659] Backtrace:
[  737.460691]  [] bad_page+0x64/0x8e
[  737.460733]  [] free_hot_cold_page+0x68/0x15a

That's the "free_pages_check()", and in particular it seems to be 
"page_mapcount()" being non-zero that triggered that thing.

So it looks like something in KVM isn't coherent about the mapping vs the 
usage counters..

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [kvm-devel] [GIT PULL][RESEND] Late KVM Updates for the 2.6.23 merge window

2007-07-20 Thread S.Çağlar Onur
Hi; 

20 Tem 2007 Cum tarihinde, Avi Kivity şunları yazmıştı: 
> Please pull from the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus
> 
> to get the following changes:
> 
> Avi Kivity (4):
>   KVM: MMU: Store nx bit for large page shadows
>   KVM: Fix memory slot management functions for guest smp
>   KVM: x86 emulator: implement rdmsr and wrmsr
>   KVM: MMU: Fix oopses with SLUB
> 
> The last commit is new since the last pull request.

With Linus's latest git, shutting down a guest (fired with -smp 2 -m 512) 
sometimes 
ends up like [1], this occured as soon as qemu window closed.

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/dmesg.latest

Cheers
-- 
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND] Late KVM Updates for the 2.6.23 merge window

2007-07-20 Thread S.Çağlar Onur
Hi; 

20 Tem 2007 Cum tarihinde, Avi Kivity şunları yazmıştı: 
 Please pull from the git repository at:
 
   git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus
 
 to get the following changes:
 
 Avi Kivity (4):
   KVM: MMU: Store nx bit for large page shadows
   KVM: Fix memory slot management functions for guest smp
   KVM: x86 emulator: implement rdmsr and wrmsr
   KVM: MMU: Fix oopses with SLUB
 
 The last commit is new since the last pull request.

With Linus's latest git, shutting down a guest (fired with -smp 2 -m 512) 
sometimes 
ends up like [1], this occured as soon as qemu window closed.

[1] http://cekirdek.pardus.org.tr/~caglar/kvm/dmesg.latest

Cheers
-- 
S.Çağlar Onur [EMAIL PROTECTED]
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!


signature.asc
Description: This is a digitally signed message part.


Re: [kvm-devel] [GIT PULL][RESEND] Late KVM Updates for the 2.6.23 merge window

2007-07-20 Thread Linus Torvalds


On Sat, 21 Jul 2007, S.Çağlar Onur wrote:
 
 With Linus's latest git, shutting down a guest (fired with -smp 2 -m 512) 
 sometimes 
 ends up like [1], this occured as soon as qemu window closed.
 
 [1] http://cekirdek.pardus.org.tr/~caglar/kvm/dmesg.latest

[  737.460654] Bad page state in process 'qemu-kvm'
[  737.460656] page:f5e68000 flags:0xea02 mapping: mapcount:2 
count:0
[  737.460657] Trying to fix it up, but a reboot is needed
[  737.460659] Backtrace:
[  737.460691]  [c0159e70] bad_page+0x64/0x8e
[  737.460733]  [c015a7ee] free_hot_cold_page+0x68/0x15a

That's the free_pages_check(), and in particular it seems to be 
page_mapcount() being non-zero that triggered that thing.

So it looks like something in KVM isn't coherent about the mapping vs the 
usage counters..

Linus
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/